Add UMA for autoblocking and embargoing.

chrome/browser/permissions/permission_context_base.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/permissions/permission_context_base.h"
 
 #include <stddef.h>
 
 #include <string>
 #include <utility>
@@ skipping 271 matching lines @@
 }
 
 void PermissionContextBase::PermissionDecided(
     const PermissionRequestID& id,
     const GURL& requesting_origin,
     const GURL& embedding_origin,
     bool user_gesture,
     const BrowserPermissionCallback& callback,
     bool persist,
     ContentSetting content_setting) {
+  PermissionUmaUtil::RecordPermissionEmbargoReason(

[dominickn, 2017/01/30 02:41:36]

Nit: add a comment saying:

// If a decision was made, the request cannot have been embargoed.

[meredithl, 2017/01/30 03:52:17]

Done.

+      PermissionEmbargoReason::NOT_EMBARGOED);

[dominickn, 2017/01/30 02:41:36]

You need to move this into an else case on line 321 (otherwise when a prompt
dismissal is embargoed, we'll double count a NOT_EMBARGOED and a
REPEATED_DISMISSAL).

You can add a test for that too (check the embargo histogram after repeated
dismissal). That should just involve adding a histogram check in the existing
repeated dismissal tests.

[meredithl, 2017/01/30 03:52:17]

Done.

   if (PermissionRequestManager::IsEnabled()) {
     // Infobar persistence and its related UMA is tracked on the infobar
     // controller directly.
     PermissionRequestGestureType gesture_type =
         user_gesture ? PermissionRequestGestureType::GESTURE
                      : PermissionRequestGestureType::NO_GESTURE;
     DCHECK(content_setting == CONTENT_SETTING_ALLOW ||
            content_setting == CONTENT_SETTING_BLOCK ||
            content_setting == CONTENT_SETTING_DEFAULT);
     if (content_setting == CONTENT_SETTING_ALLOW) {
@@ skipping 65 matching lines @@
   DCHECK(content_setting == CONTENT_SETTING_ALLOW ||
          content_setting == CONTENT_SETTING_BLOCK);
   DCHECK(!requesting_origin.SchemeIsFile());
   DCHECK(!embedding_origin.SchemeIsFile());
 
   HostContentSettingsMapFactory::GetForProfile(profile_)
       ->SetContentSettingDefaultScope(requesting_origin, embedding_origin,
                                       content_settings_type_, std::string(),
                                       content_setting);
 }