Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2651123002: Migrate content setting PROMPT_NO_DECISION_COUNT to PERMISSION_AUTOBLOCKER_DATA (Closed)

Created:
3 years, 11 months ago by raymes
Modified:
3 years, 10 months ago
Reviewers:
dominickn, meredithl
CC:
chromium-reviews, msramek+watch_chromium.org, michaelpg+watch-md-settings_chromium.org, raymes+watch_chromium.org, mlamouri+watch-permissions_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, markusheintz_, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate content setting PROMPT_NO_DECISION_COUNT to PERMISSION_AUTOBLOCKER_DATA The PROMPT_NO_DECISION_COUNT name is no longer accurate so we migrate the data to a new content setting. The old content setting can be removed after M60. A test is added to ensure the migration works properly. BUG=681709 Review-Url: https://codereview.chromium.org/2651123002 Cr-Commit-Position: refs/heads/master@{#447585} Committed: https://chromium.googlesource.com/chromium/src/+/d9c50e16b337d650bd09aec84be30ca1e76d40ab

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 #

Patch Set 4 : Rename pref #

Patch Set 5 : Rename pref #

Patch Set 6 : Rename pref #

Patch Set 7 : Rename pref #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -13 lines) Patch
M chrome/browser/permissions/permission_context_base_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/permissions/permission_decision_auto_blocker.cc View 1 2 3 7 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/permissions/permission_decision_auto_blocker_unittest.cc View 1 2 3 4 5 3 chunks +81 lines, -0 lines 0 comments Download
M components/content_settings/core/browser/content_settings_pref_provider.cc View 1 2 3 4 5 6 1 chunk +23 lines, -0 lines 0 comments Download
M components/content_settings/core/browser/website_settings_registry.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M components/content_settings/core/common/content_settings.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/content_settings/core/common/content_settings_types.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (17 generated)
raymes
This will need to be rebased on meredithl's CL but PTAL :)
3 years, 11 months ago (2017-01-25 05:03:06 UTC) #4
dominickn
Thanks raymes! lgtm https://codereview.chromium.org/2651123002/diff/20001/chrome/browser/permissions/permission_decision_auto_blocker_unittest.cc File chrome/browser/permissions/permission_decision_auto_blocker_unittest.cc (right): https://codereview.chromium.org/2651123002/diff/20001/chrome/browser/permissions/permission_decision_auto_blocker_unittest.cc#newcode311 chrome/browser/permissions/permission_decision_auto_blocker_unittest.cc:311: MigrateNoDecisionCountToPermissionAutoblockerData) { Sp: AutoBlocker https://codereview.chromium.org/2651123002/diff/20001/chrome/browser/permissions/permission_decision_auto_blocker_unittest.cc#newcode335 chrome/browser/permissions/permission_decision_auto_blocker_unittest.cc:335: ...
3 years, 11 months ago (2017-01-25 06:02:33 UTC) #7
meredithl
lgtm
3 years, 11 months ago (2017-01-25 06:50:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2651123002/120001
3 years, 10 months ago (2017-02-01 19:16:45 UTC) #19
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 20:04:14 UTC) #22
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/d9c50e16b337d650bd09aec84be3...

Powered by Google App Engine
This is Rietveld 408576698