Issue 265103002: Ensure that Y, U and V planes have 16-byte alignment & stride.

Issue 265103002: Ensure that Y, U and V planes have 16-byte alignment & stride. (Closed)

Created:
6 years, 7 months ago by Wez

Modified:
6 years, 7 months ago

Reviewers:
Sergey Ulanov

CC:
chromium-reviews, chromoting-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Ensure that Y, U and V planes have 16-byte alignment & stride. This ensures that we're able to use the fast path during colour conversion operations. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268063

Patch Set 1 #

Patch Set 2 : Make assumption of 16x16 macroblock size more explicit. #

Patch Set 3 : Improve comment. #

Total comments: 3

Patch Set 4 : pick nit #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -26 lines)			Patch
	M	remoting/codec/video_encoder_vpx.cc	View	1 2 3	1 chunk	+23 lines, -26 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

https://codereview.chromium.org/265103002/diff/50001/remoting/codec/video_encoder_vpx.cc File remoting/codec/video_encoder_vpx.cc (right): https://codereview.chromium.org/265103002/diff/50001/remoting/codec/video_encoder_vpx.cc#newcode281 remoting/codec/video_encoder_vpx.cc:281: const int uv_rows = y_rows / 2; should this ...

6 years, 7 months ago (2014-05-03 00:57:26 UTC) #2

Wez

6 years, 7 months ago (2014-05-03 01:19:12 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/265103002/70001

6 years, 7 months ago (2014-05-03 05:17:29 UTC) #6

Message was sent while issue was closed.

Change committed as 268063

Expand Messages | Collapse Messages