Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2651023003:
add TEAM/COMPONENT (Closed)
|
Created:
3 years, 11 months ago by ymzhang1 Modified:
3 years, 10 months ago CC:
abarth-chromium, agrieve+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, dominickn+watch_chromium.org, feature-media-reviews_chromium.org, haraken, jam, media-router+watch_chromium.org, mlamouri+watch-manifest_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-screen-orientation_chromium.org, mlamouri+watch-permissions_chromium.org, mlamouri+watch-blink_chromium.org, pkotwicz+watch_chromium.org, raymes+watch_chromium.org, zpeng+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionadd TEAM/COMPONENT
BUG=679905
R=mlamouri
Review-Url: https://codereview.chromium.org/2651023003
Cr-Commit-Position: refs/heads/master@{#449507}
Committed: https://chromium.googlesource.com/chromium/src/+/55fad71126046d6d84bd763c34a45476444fce09
Patch Set 1 #
Total comments: 24
Patch Set 2 : update TEAM/COMPONENT #
Total comments: 1
Patch Set 3 : update team #
Total comments: 31
Patch Set 4 : update team #
Total comments: 16
Patch Set 5 : update team/compo #
Total comments: 2
Patch Set 6 : update component #Messages
Total messages: 46 (13 generated)
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS file? Thank you very much!
mfoltz@chromium.org changed reviewers: + mfoltz@chromium.org
https://codereview.chromium.org/2651023003/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/media/router/OWNERS (right): https://codereview.chromium.org/2651023003/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/router/OWNERS:5: # COMPONENT: Blink>Media Blink>PresentationAPI https://codereview.chromium.org/2651023003/diff/1/chrome/android/junit/src/or... File chrome/android/junit/src/org/chromium/chrome/browser/media/router/OWNERS (right): https://codereview.chromium.org/2651023003/diff/1/chrome/android/junit/src/or... chrome/android/junit/src/org/chromium/chrome/browser/media/router/OWNERS:5: # COMPONENT: Blink>Media Blink>PresentationAPI https://codereview.chromium.org/2651023003/diff/1/chrome/browser/media/androi... File chrome/browser/media/android/router/OWNERS (right): https://codereview.chromium.org/2651023003/diff/1/chrome/browser/media/androi... chrome/browser/media/android/router/OWNERS:5: # COMPONENT: Blink>Media Blink>PresentationAPI https://codereview.chromium.org/2651023003/diff/1/content/browser/presentatio... File content/browser/presentation/OWNERS (right): https://codereview.chromium.org/2651023003/diff/1/content/browser/presentatio... content/browser/presentation/OWNERS:17: # TEAM: chrome-media-lon@chromium.org chrome-multiscreen@google.com https://codereview.chromium.org/2651023003/diff/1/third_party/WebKit/Source/m... File third_party/WebKit/Source/modules/presentation/OWNERS (right): https://codereview.chromium.org/2651023003/diff/1/third_party/WebKit/Source/m... third_party/WebKit/Source/modules/presentation/OWNERS:6: # TEAM: chrome-media-lon@chromium.org chrome-multiscreen@google.com https://codereview.chromium.org/2651023003/diff/1/third_party/WebKit/public/p... File third_party/WebKit/public/platform/modules/presentation/OWNERS (right): https://codereview.chromium.org/2651023003/diff/1/third_party/WebKit/public/p... third_party/WebKit/public/platform/modules/presentation/OWNERS:9: # TEAM: chrome-media-lon@chromium.org chrome-multiscreen@google.com
https://codereview.chromium.org/2651023003/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/media/router/OWNERS (right): https://codereview.chromium.org/2651023003/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/router/OWNERS:5: # COMPONENT: Blink>Media On 2017/01/24 20:35:52, mark a. foltz wrote: > Blink>PresentationAPI Done. https://codereview.chromium.org/2651023003/diff/1/chrome/android/junit/src/or... File chrome/android/junit/src/org/chromium/chrome/browser/media/router/OWNERS (right): https://codereview.chromium.org/2651023003/diff/1/chrome/android/junit/src/or... chrome/android/junit/src/org/chromium/chrome/browser/media/router/OWNERS:5: # COMPONENT: Blink>Media On 2017/01/24 20:35:52, mark a. foltz wrote: > Blink>PresentationAPI Done. https://codereview.chromium.org/2651023003/diff/1/chrome/browser/media/androi... File chrome/browser/media/android/router/OWNERS (right): https://codereview.chromium.org/2651023003/diff/1/chrome/browser/media/androi... chrome/browser/media/android/router/OWNERS:5: # COMPONENT: Blink>Media On 2017/01/24 20:35:52, mark a. foltz wrote: > Blink>PresentationAPI Done. https://codereview.chromium.org/2651023003/diff/1/content/browser/presentatio... File content/browser/presentation/OWNERS (right): https://codereview.chromium.org/2651023003/diff/1/content/browser/presentatio... content/browser/presentation/OWNERS:17: # TEAM: chrome-media-lon@chromium.org On 2017/01/24 20:35:52, mark a. foltz wrote: > mailto:chrome-multiscreen@google.com We would like to have only one team for each component among all OWNERS. The team will be the primary team to triage this component. Shall I replace chrome-media-lon@chromium.org with chrome-multiscreen@google.com for Blink>PresentationAPI in all OWNERS files?
raymes@chromium.org changed reviewers: + raymes@chromium.org
Some suggestions for permissions. https://codereview.chromium.org/2651023003/diff/1/chrome/browser/permissions/... File chrome/browser/permissions/OWNERS (right): https://codereview.chromium.org/2651023003/diff/1/chrome/browser/permissions/... chrome/browser/permissions/OWNERS:7: # TEAM: chrome-media-lon@chromium.org chrome-permissions-team@google.com https://codereview.chromium.org/2651023003/diff/1/chrome/browser/permissions/... chrome/browser/permissions/OWNERS:8: # COMPONENT: Blink>PermissionsAPI Internals>Permissions https://codereview.chromium.org/2651023003/diff/1/content/browser/permissions... File content/browser/permissions/OWNERS (right): https://codereview.chromium.org/2651023003/diff/1/content/browser/permissions... content/browser/permissions/OWNERS:3: # TEAM: chrome-media-lon@chromium.org chrome-permissions-team@google.com https://codereview.chromium.org/2651023003/diff/1/content/browser/permissions... content/browser/permissions/OWNERS:4: # COMPONENT: Blink>PermissionsAPI Internals>Permissions https://codereview.chromium.org/2651023003/diff/1/third_party/WebKit/Source/m... File third_party/WebKit/Source/modules/permissions/OWNERS (right): https://codereview.chromium.org/2651023003/diff/1/third_party/WebKit/Source/m... third_party/WebKit/Source/modules/permissions/OWNERS:3: # TEAM: chrome-media-lon@chromium.org chrome-permissions-team@google.com https://codereview.chromium.org/2651023003/diff/1/third_party/WebKit/public/p... File third_party/WebKit/public/platform/modules/permissions/OWNERS (right): https://codereview.chromium.org/2651023003/diff/1/third_party/WebKit/public/p... third_party/WebKit/public/platform/modules/permissions/OWNERS:6: # TEAM: chrome-media-lon@chromium.org chrome-permissions-team@google.com
On 2017/01/24 at 21:11:12, ymzhang wrote: > https://codereview.chromium.org/2651023003/diff/1/chrome/android/java/src/org... > File chrome/android/java/src/org/chromium/chrome/browser/media/router/OWNERS (right): > > https://codereview.chromium.org/2651023003/diff/1/chrome/android/java/src/org... > chrome/android/java/src/org/chromium/chrome/browser/media/router/OWNERS:5: # COMPONENT: Blink>Media > On 2017/01/24 20:35:52, mark a. foltz wrote: > > Blink>PresentationAPI > > Done. > > https://codereview.chromium.org/2651023003/diff/1/chrome/android/junit/src/or... > File chrome/android/junit/src/org/chromium/chrome/browser/media/router/OWNERS (right): > > https://codereview.chromium.org/2651023003/diff/1/chrome/android/junit/src/or... > chrome/android/junit/src/org/chromium/chrome/browser/media/router/OWNERS:5: # COMPONENT: Blink>Media > On 2017/01/24 20:35:52, mark a. foltz wrote: > > Blink>PresentationAPI > > Done. > > https://codereview.chromium.org/2651023003/diff/1/chrome/browser/media/androi... > File chrome/browser/media/android/router/OWNERS (right): > > https://codereview.chromium.org/2651023003/diff/1/chrome/browser/media/androi... > chrome/browser/media/android/router/OWNERS:5: # COMPONENT: Blink>Media > On 2017/01/24 20:35:52, mark a. foltz wrote: > > Blink>PresentationAPI > > Done. > > https://codereview.chromium.org/2651023003/diff/1/content/browser/presentatio... > File content/browser/presentation/OWNERS (right): > > https://codereview.chromium.org/2651023003/diff/1/content/browser/presentatio... > content/browser/presentation/OWNERS:17: # TEAM: chrome-media-lon@chromium.org > On 2017/01/24 20:35:52, mark a. foltz wrote: > > mailto:chrome-multiscreen@google.com > > We would like to have only one team for each component among all OWNERS. The team will be the primary team to triage this component. Shall I replace chrome-media-lon@chromium.org with chrome-multiscreen@google.com for Blink>PresentationAPI in all OWNERS files? No, chrome-multiscreen@ doesn't own permissions or a bunch of the other features in this patch. Only Media Router and Presentation API.
On 2017/01/25 00:04:26, mark a. foltz wrote: > On 2017/01/24 at 21:11:12, ymzhang wrote: > > > https://codereview.chromium.org/2651023003/diff/1/chrome/android/java/src/org... > > File chrome/android/java/src/org/chromium/chrome/browser/media/router/OWNERS > (right): > > > > > https://codereview.chromium.org/2651023003/diff/1/chrome/android/java/src/org... > > chrome/android/java/src/org/chromium/chrome/browser/media/router/OWNERS:5: # > COMPONENT: Blink>Media > > On 2017/01/24 20:35:52, mark a. foltz wrote: > > > Blink>PresentationAPI > > > > Done. > > > > > https://codereview.chromium.org/2651023003/diff/1/chrome/android/junit/src/or... > > File chrome/android/junit/src/org/chromium/chrome/browser/media/router/OWNERS > (right): > > > > > https://codereview.chromium.org/2651023003/diff/1/chrome/android/junit/src/or... > > chrome/android/junit/src/org/chromium/chrome/browser/media/router/OWNERS:5: # > COMPONENT: Blink>Media > > On 2017/01/24 20:35:52, mark a. foltz wrote: > > > Blink>PresentationAPI > > > > Done. > > > > > https://codereview.chromium.org/2651023003/diff/1/chrome/browser/media/androi... > > File chrome/browser/media/android/router/OWNERS (right): > > > > > https://codereview.chromium.org/2651023003/diff/1/chrome/browser/media/androi... > > chrome/browser/media/android/router/OWNERS:5: # COMPONENT: Blink>Media > > On 2017/01/24 20:35:52, mark a. foltz wrote: > > > Blink>PresentationAPI > > > > Done. > > > > > https://codereview.chromium.org/2651023003/diff/1/content/browser/presentatio... > > File content/browser/presentation/OWNERS (right): > > > > > https://codereview.chromium.org/2651023003/diff/1/content/browser/presentatio... > > content/browser/presentation/OWNERS:17: # TEAM: mailto:chrome-media-lon@chromium.org > > On 2017/01/24 20:35:52, mark a. foltz wrote: > > > mailto:chrome-multiscreen@google.com > > > > We would like to have only one team for each component among all OWNERS. The > team will be the primary team to triage this component. Shall I replace > mailto:chrome-media-lon@chromium.org with mailto:chrome-multiscreen@google.com for > Blink>PresentationAPI in all OWNERS files? > > No, chrome-multiscreen@ doesn't own permissions or a bunch of the other features > in this patch. Only Media Router and Presentation API. Thanks for the explanation. Then could we keep using chrome-media-lon@chromium.org for Blink>PresentationAPI in all OWNERS files? Or is there any other component that maps to chrome-multiscreen@google.com that we could use here?
On 2017/01/25 at 18:13:28, ymzhang wrote: > On 2017/01/25 00:04:26, mark a. foltz wrote: > > On 2017/01/24 at 21:11:12, ymzhang wrote: > > > > > https://codereview.chromium.org/2651023003/diff/1/chrome/android/java/src/org... > > > File chrome/android/java/src/org/chromium/chrome/browser/media/router/OWNERS > > (right): > > > > > > > > https://codereview.chromium.org/2651023003/diff/1/chrome/android/java/src/org... > > > chrome/android/java/src/org/chromium/chrome/browser/media/router/OWNERS:5: # > > COMPONENT: Blink>Media > > > On 2017/01/24 20:35:52, mark a. foltz wrote: > > > > Blink>PresentationAPI > > > > > > Done. > > > > > > > > https://codereview.chromium.org/2651023003/diff/1/chrome/android/junit/src/or... > > > File chrome/android/junit/src/org/chromium/chrome/browser/media/router/OWNERS > > (right): > > > > > > > > https://codereview.chromium.org/2651023003/diff/1/chrome/android/junit/src/or... > > > chrome/android/junit/src/org/chromium/chrome/browser/media/router/OWNERS:5: # > > COMPONENT: Blink>Media > > > On 2017/01/24 20:35:52, mark a. foltz wrote: > > > > Blink>PresentationAPI > > > > > > Done. > > > > > > > > https://codereview.chromium.org/2651023003/diff/1/chrome/browser/media/androi... > > > File chrome/browser/media/android/router/OWNERS (right): > > > > > > > > https://codereview.chromium.org/2651023003/diff/1/chrome/browser/media/androi... > > > chrome/browser/media/android/router/OWNERS:5: # COMPONENT: Blink>Media > > > On 2017/01/24 20:35:52, mark a. foltz wrote: > > > > Blink>PresentationAPI > > > > > > Done. > > > > > > > > https://codereview.chromium.org/2651023003/diff/1/content/browser/presentatio... > > > File content/browser/presentation/OWNERS (right): > > > > > > > > https://codereview.chromium.org/2651023003/diff/1/content/browser/presentatio... > > > content/browser/presentation/OWNERS:17: # TEAM: mailto:chrome-media-lon@chromium.org > > > On 2017/01/24 20:35:52, mark a. foltz wrote: > > > > mailto:chrome-multiscreen@google.com > > > > > > We would like to have only one team for each component among all OWNERS. The > > team will be the primary team to triage this component. Shall I replace > > mailto:chrome-media-lon@chromium.org with mailto:chrome-multiscreen@google.com for > > Blink>PresentationAPI in all OWNERS files? > > > > No, chrome-multiscreen@ doesn't own permissions or a bunch of the other features > > in this patch. Only Media Router and Presentation API. > > Thanks for the explanation. Then could we keep using chrome-media-lon@chromium.org for Blink>PresentationAPI in all OWNERS files? Or is there any other component that maps to chrome-multiscreen@google.com that we could use here? The implementation of the PresentationAPI is shared between two teams, but if you need to assign a single owner then use chrome-multiscreen@google.com and we can make sure the relevant parties are subscribed. What is this information going to be used for? If it is for automated bots/scripts then we don't want that alias at all.
Description was changed from ========== add TEAM/COMPONENT BUG=679905 R=mlamouri ========== to ========== add TEAM/COMPONENT BUG=679905 R=mlamouri ==========
ymzhang@chromium.org changed reviewers: + sshruthi@chromium.org
On 2017/01/25 18:27:03, mark a. foltz wrote: > On 2017/01/25 at 18:13:28, ymzhang wrote: > > On 2017/01/25 00:04:26, mark a. foltz wrote: > > > On 2017/01/24 at 21:11:12, ymzhang wrote: > > > > > > > > https://codereview.chromium.org/2651023003/diff/1/chrome/android/java/src/org... > > > > File > chrome/android/java/src/org/chromium/chrome/browser/media/router/OWNERS > > > (right): > > > > > > > > > > > > https://codereview.chromium.org/2651023003/diff/1/chrome/android/java/src/org... > > > > chrome/android/java/src/org/chromium/chrome/browser/media/router/OWNERS:5: > # > > > COMPONENT: Blink>Media > > > > On 2017/01/24 20:35:52, mark a. foltz wrote: > > > > > Blink>PresentationAPI > > > > > > > > Done. > > > > > > > > > > > > https://codereview.chromium.org/2651023003/diff/1/chrome/android/junit/src/or... > > > > File > chrome/android/junit/src/org/chromium/chrome/browser/media/router/OWNERS > > > (right): > > > > > > > > > > > > https://codereview.chromium.org/2651023003/diff/1/chrome/android/junit/src/or... > > > > > chrome/android/junit/src/org/chromium/chrome/browser/media/router/OWNERS:5: # > > > COMPONENT: Blink>Media > > > > On 2017/01/24 20:35:52, mark a. foltz wrote: > > > > > Blink>PresentationAPI > > > > > > > > Done. > > > > > > > > > > > > https://codereview.chromium.org/2651023003/diff/1/chrome/browser/media/androi... > > > > File chrome/browser/media/android/router/OWNERS (right): > > > > > > > > > > > > https://codereview.chromium.org/2651023003/diff/1/chrome/browser/media/androi... > > > > chrome/browser/media/android/router/OWNERS:5: # COMPONENT: Blink>Media > > > > On 2017/01/24 20:35:52, mark a. foltz wrote: > > > > > Blink>PresentationAPI > > > > > > > > Done. > > > > > > > > > > > > https://codereview.chromium.org/2651023003/diff/1/content/browser/presentatio... > > > > File content/browser/presentation/OWNERS (right): > > > > > > > > > > > > https://codereview.chromium.org/2651023003/diff/1/content/browser/presentatio... > > > > content/browser/presentation/OWNERS:17: # TEAM: > mailto:chrome-media-lon@chromium.org > > > > On 2017/01/24 20:35:52, mark a. foltz wrote: > > > > > mailto:chrome-multiscreen@google.com > > > > > > > > We would like to have only one team for each component among all OWNERS. > The > > > team will be the primary team to triage this component. Shall I replace > > > mailto:chrome-media-lon@chromium.org with > mailto:chrome-multiscreen@google.com for > > > Blink>PresentationAPI in all OWNERS files? > > > > > > No, chrome-multiscreen@ doesn't own permissions or a bunch of the other > features > > > in this patch. Only Media Router and Presentation API. > > > > Thanks for the explanation. Then could we keep using > mailto:chrome-media-lon@chromium.org for Blink>PresentationAPI in all OWNERS files? Or > is there any other component that maps to mailto:chrome-multiscreen@google.com that we > could use here? > > The implementation of the PresentationAPI is shared between two teams, but if > you need to assign a single owner then use mailto:chrome-multiscreen@google.com and we > can make sure the relevant parties are subscribed. > > What is this information going to be used for? If it is for automated > bots/scripts then we don't want that alias at all. The email address won't be used in any automation as part of current plans. It is only a way to record contact information of the team that owns the directory. Here is the related proposal: https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST.... In case you would like to discuss more detail about the proposal. +Shruthi,
On 2017/01/25 at 18:46:29, ymzhang wrote: > On 2017/01/25 18:27:03, mark a. foltz wrote: > > On 2017/01/25 at 18:13:28, ymzhang wrote: > > > On 2017/01/25 00:04:26, mark a. foltz wrote: > > > > On 2017/01/24 at 21:11:12, ymzhang wrote: > > > > > > > > > > > https://codereview.chromium.org/2651023003/diff/1/chrome/android/java/src/org... > > > > > File > > chrome/android/java/src/org/chromium/chrome/browser/media/router/OWNERS > > > > (right): > > > > > > > > > > > > > > > > https://codereview.chromium.org/2651023003/diff/1/chrome/android/java/src/org... > > > > > chrome/android/java/src/org/chromium/chrome/browser/media/router/OWNERS:5: > > # > > > > COMPONENT: Blink>Media > > > > > On 2017/01/24 20:35:52, mark a. foltz wrote: > > > > > > Blink>PresentationAPI > > > > > > > > > > Done. > > > > > > > > > > > > > > > > https://codereview.chromium.org/2651023003/diff/1/chrome/android/junit/src/or... > > > > > File > > chrome/android/junit/src/org/chromium/chrome/browser/media/router/OWNERS > > > > (right): > > > > > > > > > > > > > > > > https://codereview.chromium.org/2651023003/diff/1/chrome/android/junit/src/or... > > > > > > > chrome/android/junit/src/org/chromium/chrome/browser/media/router/OWNERS:5: # > > > > COMPONENT: Blink>Media > > > > > On 2017/01/24 20:35:52, mark a. foltz wrote: > > > > > > Blink>PresentationAPI > > > > > > > > > > Done. > > > > > > > > > > > > > > > > https://codereview.chromium.org/2651023003/diff/1/chrome/browser/media/androi... > > > > > File chrome/browser/media/android/router/OWNERS (right): > > > > > > > > > > > > > > > > https://codereview.chromium.org/2651023003/diff/1/chrome/browser/media/androi... > > > > > chrome/browser/media/android/router/OWNERS:5: # COMPONENT: Blink>Media > > > > > On 2017/01/24 20:35:52, mark a. foltz wrote: > > > > > > Blink>PresentationAPI > > > > > > > > > > Done. > > > > > > > > > > > > > > > > https://codereview.chromium.org/2651023003/diff/1/content/browser/presentatio... > > > > > File content/browser/presentation/OWNERS (right): > > > > > > > > > > > > > > > > https://codereview.chromium.org/2651023003/diff/1/content/browser/presentatio... > > > > > content/browser/presentation/OWNERS:17: # TEAM: > > mailto:chrome-media-lon@chromium.org > > > > > On 2017/01/24 20:35:52, mark a. foltz wrote: > > > > > > mailto:chrome-multiscreen@google.com > > > > > > > > > > We would like to have only one team for each component among all OWNERS. > > The > > > > team will be the primary team to triage this component. Shall I replace > > > > mailto:chrome-media-lon@chromium.org with > > mailto:chrome-multiscreen@google.com for > > > > Blink>PresentationAPI in all OWNERS files? > > > > > > > > No, chrome-multiscreen@ doesn't own permissions or a bunch of the other > > features > > > > in this patch. Only Media Router and Presentation API. > > > > > > Thanks for the explanation. Then could we keep using > > mailto:chrome-media-lon@chromium.org for Blink>PresentationAPI in all OWNERS files? Or > > is there any other component that maps to mailto:chrome-multiscreen@google.com that we > > could use here? > > > > The implementation of the PresentationAPI is shared between two teams, but if > > you need to assign a single owner then use mailto:chrome-multiscreen@google.com and we > > can make sure the relevant parties are subscribed. > > > > What is this information going to be used for? If it is for automated > > bots/scripts then we don't want that alias at all. > > The email address won't be used in any automation as part of current plans. It is only a way to record contact information of the team that owns the directory. > Here is the related proposal: https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST.... > > In case you would like to discuss more detail about the proposal. > +Shruthi, That seems fine. We have assigned emails to components in Monorail for bug triage, so if it's used to assign components that's fine.
On 2017/01/24 23:53:54, raymes wrote: > Some suggestions for permissions. > > https://codereview.chromium.org/2651023003/diff/1/chrome/browser/permissions/... > File chrome/browser/permissions/OWNERS (right): > > https://codereview.chromium.org/2651023003/diff/1/chrome/browser/permissions/... > chrome/browser/permissions/OWNERS:7: # TEAM: mailto:chrome-media-lon@chromium.org > mailto:chrome-permissions-team@google.com > > https://codereview.chromium.org/2651023003/diff/1/chrome/browser/permissions/... > chrome/browser/permissions/OWNERS:8: # COMPONENT: Blink>PermissionsAPI > Internals>Permissions > > https://codereview.chromium.org/2651023003/diff/1/content/browser/permissions... > File content/browser/permissions/OWNERS (right): > > https://codereview.chromium.org/2651023003/diff/1/content/browser/permissions... > content/browser/permissions/OWNERS:3: # TEAM: mailto:chrome-media-lon@chromium.org > mailto:chrome-permissions-team@google.com > > https://codereview.chromium.org/2651023003/diff/1/content/browser/permissions... > content/browser/permissions/OWNERS:4: # COMPONENT: Blink>PermissionsAPI > Internals>Permissions > > https://codereview.chromium.org/2651023003/diff/1/third_party/WebKit/Source/m... > File third_party/WebKit/Source/modules/permissions/OWNERS (right): > > https://codereview.chromium.org/2651023003/diff/1/third_party/WebKit/Source/m... > third_party/WebKit/Source/modules/permissions/OWNERS:3: # TEAM: > mailto:chrome-media-lon@chromium.org > mailto:chrome-permissions-team@google.com > > https://codereview.chromium.org/2651023003/diff/1/third_party/WebKit/public/p... > File third_party/WebKit/public/platform/modules/permissions/OWNERS (right): > > https://codereview.chromium.org/2651023003/diff/1/third_party/WebKit/public/p... > third_party/WebKit/public/platform/modules/permissions/OWNERS:6: # TEAM: > mailto:chrome-media-lon@chromium.org > mailto:chrome-permissions-team@google.com Thanks for suggestions!
On 2017/01/26 19:12:59, mark a. foltz wrote: > On 2017/01/25 at 18:46:29, ymzhang wrote: > > On 2017/01/25 18:27:03, mark a. foltz wrote: > > > On 2017/01/25 at 18:13:28, ymzhang wrote: > > > > On 2017/01/25 00:04:26, mark a. foltz wrote: > > > > > On 2017/01/24 at 21:11:12, ymzhang wrote: > > > > > > > > > > > > > > > https://codereview.chromium.org/2651023003/diff/1/chrome/android/java/src/org... > > > > > > File > > > chrome/android/java/src/org/chromium/chrome/browser/media/router/OWNERS > > > > > (right): > > > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/2651023003/diff/1/chrome/android/java/src/org... > > > > > > > chrome/android/java/src/org/chromium/chrome/browser/media/router/OWNERS:5: > > > # > > > > > COMPONENT: Blink>Media > > > > > > On 2017/01/24 20:35:52, mark a. foltz wrote: > > > > > > > Blink>PresentationAPI > > > > > > > > > > > > Done. > > > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/2651023003/diff/1/chrome/android/junit/src/or... > > > > > > File > > > chrome/android/junit/src/org/chromium/chrome/browser/media/router/OWNERS > > > > > (right): > > > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/2651023003/diff/1/chrome/android/junit/src/or... > > > > > > > > > chrome/android/junit/src/org/chromium/chrome/browser/media/router/OWNERS:5: > # > > > > > COMPONENT: Blink>Media > > > > > > On 2017/01/24 20:35:52, mark a. foltz wrote: > > > > > > > Blink>PresentationAPI > > > > > > > > > > > > Done. > > > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/2651023003/diff/1/chrome/browser/media/androi... > > > > > > File chrome/browser/media/android/router/OWNERS (right): > > > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/2651023003/diff/1/chrome/browser/media/androi... > > > > > > chrome/browser/media/android/router/OWNERS:5: # COMPONENT: Blink>Media > > > > > > On 2017/01/24 20:35:52, mark a. foltz wrote: > > > > > > > Blink>PresentationAPI > > > > > > > > > > > > Done. > > > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/2651023003/diff/1/content/browser/presentatio... > > > > > > File content/browser/presentation/OWNERS (right): > > > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/2651023003/diff/1/content/browser/presentatio... > > > > > > content/browser/presentation/OWNERS:17: # TEAM: > > > mailto:chrome-media-lon@chromium.org > > > > > > On 2017/01/24 20:35:52, mark a. foltz wrote: > > > > > > > mailto:chrome-multiscreen@google.com > > > > > > > > > > > > We would like to have only one team for each component among all > OWNERS. > > > The > > > > > team will be the primary team to triage this component. Shall I replace > > > > > mailto:chrome-media-lon@chromium.org with > > > mailto:chrome-multiscreen@google.com for > > > > > Blink>PresentationAPI in all OWNERS files? > > > > > > > > > > No, chrome-multiscreen@ doesn't own permissions or a bunch of the other > > > features > > > > > in this patch. Only Media Router and Presentation API. > > > > > > > > Thanks for the explanation. Then could we keep using > > > mailto:chrome-media-lon@chromium.org for Blink>PresentationAPI in all OWNERS > files? Or > > > is there any other component that maps to > mailto:chrome-multiscreen@google.com that we > > > could use here? > > > > > > The implementation of the PresentationAPI is shared between two teams, but > if > > > you need to assign a single owner then use > mailto:chrome-multiscreen@google.com and we > > > can make sure the relevant parties are subscribed. > > > > > > What is this information going to be used for? If it is for automated > > > bots/scripts then we don't want that alias at all. > > > > The email address won't be used in any automation as part of current plans. It > is only a way to record contact information of the team that owns the directory. > > Here is the related proposal: > https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST.... > > > > > In case you would like to discuss more detail about the proposal. > > +Shruthi, > > That seems fine. We have assigned emails to components in Monorail for bug > triage, so if it's used to assign components that's fine. Good to know. I'll update based on previous comments!
Patchset #2 (id:20001) has been deleted
Updated TEAM/COMPONENT. https://codereview.chromium.org/2651023003/diff/1/chrome/browser/permissions/... File chrome/browser/permissions/OWNERS (right): https://codereview.chromium.org/2651023003/diff/1/chrome/browser/permissions/... chrome/browser/permissions/OWNERS:7: # TEAM: chrome-media-lon@chromium.org On 2017/01/24 23:53:53, raymes wrote: > mailto:chrome-permissions-team@google.com Done. https://codereview.chromium.org/2651023003/diff/1/chrome/browser/permissions/... chrome/browser/permissions/OWNERS:8: # COMPONENT: Blink>PermissionsAPI On 2017/01/24 23:53:54, raymes wrote: > Internals>Permissions Done. https://codereview.chromium.org/2651023003/diff/1/content/browser/permissions... File content/browser/permissions/OWNERS (right): https://codereview.chromium.org/2651023003/diff/1/content/browser/permissions... content/browser/permissions/OWNERS:3: # TEAM: chrome-media-lon@chromium.org On 2017/01/24 23:53:54, raymes wrote: > mailto:chrome-permissions-team@google.com Done. https://codereview.chromium.org/2651023003/diff/1/content/browser/permissions... content/browser/permissions/OWNERS:4: # COMPONENT: Blink>PermissionsAPI On 2017/01/24 23:53:54, raymes wrote: > Internals>Permissions Done. https://codereview.chromium.org/2651023003/diff/1/third_party/WebKit/Source/m... File third_party/WebKit/Source/modules/permissions/OWNERS (right): https://codereview.chromium.org/2651023003/diff/1/third_party/WebKit/Source/m... third_party/WebKit/Source/modules/permissions/OWNERS:3: # TEAM: chrome-media-lon@chromium.org On 2017/01/24 23:53:54, raymes wrote: > mailto:chrome-permissions-team@google.com Done. https://codereview.chromium.org/2651023003/diff/1/third_party/WebKit/Source/m... File third_party/WebKit/Source/modules/presentation/OWNERS (right): https://codereview.chromium.org/2651023003/diff/1/third_party/WebKit/Source/m... third_party/WebKit/Source/modules/presentation/OWNERS:6: # TEAM: chrome-media-lon@chromium.org On 2017/01/24 20:35:52, mark a. foltz wrote: > mailto:chrome-multiscreen@google.com Will keep chrome-media-lon@chromium.org for consistency for now. https://codereview.chromium.org/2651023003/diff/1/third_party/WebKit/public/p... File third_party/WebKit/public/platform/modules/permissions/OWNERS (right): https://codereview.chromium.org/2651023003/diff/1/third_party/WebKit/public/p... third_party/WebKit/public/platform/modules/permissions/OWNERS:6: # TEAM: chrome-media-lon@chromium.org On 2017/01/24 23:53:54, raymes wrote: > mailto:chrome-permissions-team@google.com Done. https://codereview.chromium.org/2651023003/diff/1/third_party/WebKit/public/p... File third_party/WebKit/public/platform/modules/presentation/OWNERS (right): https://codereview.chromium.org/2651023003/diff/1/third_party/WebKit/public/p... third_party/WebKit/public/platform/modules/presentation/OWNERS:9: # TEAM: chrome-media-lon@chromium.org On 2017/01/24 20:35:52, mark a. foltz wrote: > mailto:chrome-multiscreen@google.com will keep chrome-media-lon@chromium.org for consistency as discussed.
https://codereview.chromium.org/2651023003/diff/40001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/media/router/OWNERS (right): https://codereview.chromium.org/2651023003/diff/40001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/media/router/OWNERS:4: # TEAM: chrome-media-lon@chromium.org No. Per earlier suggestion chrome-multiscreen@google.com for Blink>PresentationAPI components.
On 2017/01/26 21:14:38, mark a. foltz wrote: > https://codereview.chromium.org/2651023003/diff/40001/chrome/android/java/src... > File chrome/android/java/src/org/chromium/chrome/browser/media/router/OWNERS > (right): > > https://codereview.chromium.org/2651023003/diff/40001/chrome/android/java/src... > chrome/android/java/src/org/chromium/chrome/browser/media/router/OWNERS:4: # > TEAM: mailto:chrome-media-lon@chromium.org > No. Per earlier suggestion mailto:chrome-multiscreen@google.com for > Blink>PresentationAPI components. Oops. Misunderstood. I'll update and upload again.
Update team for Blink>PresentationAPI.
mfoltz@chromium.org changed reviewers: + wez@chromium.org
+wez LGTM for Blink>PresentationAPI. Wez, who should be the TEAM for Blink>Media?
It doesn't seem appropriate for us to have @google.com groups listed in TEAMS; have pinged sshruthi@ on the design doc for clarification.
On 2017/01/27 17:34:27, Wez wrote: > It doesn't seem appropriate for us to have @google.com groups listed in TEAMS; > have pinged sshruthi@ on the design doc for clarification. I agree that is not ideal. But, while we work towards adding an @chromium.org group for that team, and moving discussions there, let's add SOME contact information, which can be the @google.com list for now.
On 2017/01/27 at 17:55:37, sshruthi wrote: > On 2017/01/27 17:34:27, Wez wrote: > > It doesn't seem appropriate for us to have @google.com groups listed in TEAMS; > > have pinged sshruthi@ on the design doc for clarification. > > I agree that is not ideal. But, while we work towards adding an @chromium.org group for that team, and moving discussions there, let's add SOME contact information, which can be the @google.com list for now. I don't think we want to maintain a separate @chromium.org group just for this purpose. I suppose we can have it be a dummy list that forwards to the internal list this is really an issue.
https://codereview.chromium.org/2651023003/diff/60001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/media/ui/OWNERS (right): https://codereview.chromium.org/2651023003/diff/60001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/media/ui/OWNERS:4: # TEAM: chrome-media-lon@chromium.org @google.com for chrome-media-lon@, here and below https://codereview.chromium.org/2651023003/diff/60001/chrome/android/javatest... File chrome/android/javatests/src/org/chromium/chrome/browser/media/OWNERS (right): https://codereview.chromium.org/2651023003/diff/60001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/media/OWNERS:6: # COMPONENT: Blink>Media Internals>Media>UI maybe? https://codereview.chromium.org/2651023003/diff/60001/chrome/android/junit/sr... File chrome/android/junit/src/org/chromium/chrome/browser/media/ui/OWNERS (right): https://codereview.chromium.org/2651023003/diff/60001/chrome/android/junit/sr... chrome/android/junit/src/org/chromium/chrome/browser/media/ui/OWNERS:6: # COMPONENT: Blink>Media Internals>Media>UI https://codereview.chromium.org/2651023003/diff/60001/content/browser/media/s... File content/browser/media/session/OWNERS (right): https://codereview.chromium.org/2651023003/diff/60001/content/browser/media/s... content/browser/media/session/OWNERS:5: # COMPONENT: Blink>Media Internals>Media>Session https://codereview.chromium.org/2651023003/diff/60001/content/browser/screen_... File content/browser/screen_orientation/OWNERS (right): https://codereview.chromium.org/2651023003/diff/60001/content/browser/screen_... content/browser/screen_orientation/OWNERS:4: # COMPONENT: Blink>PresentationAPI I don't think that's correct. There isn't really a team for this nor a component. Ideally, we should create a Blink>ScreenOrientation component though. https://codereview.chromium.org/2651023003/diff/60001/content/public/android/... File content/public/android/java/src/org/chromium/content/browser/OWNERS (right): https://codereview.chromium.org/2651023003/diff/60001/content/public/android/... content/public/android/java/src/org/chromium/content/browser/OWNERS:22: # COMPONENT: Content>WebApps That doesn't look quite right. You might want to leave this out at the moment. https://codereview.chromium.org/2651023003/diff/60001/content/public/android/... File content/public/android/javatests/src/org/chromium/content/browser/OWNERS (right): https://codereview.chromium.org/2651023003/diff/60001/content/public/android/... content/public/android/javatests/src/org/chromium/content/browser/OWNERS:25: # COMPONENT: Content>WebApps ditto https://codereview.chromium.org/2651023003/diff/60001/content/renderer/screen... File content/renderer/screen_orientation/OWNERS (right): https://codereview.chromium.org/2651023003/diff/60001/content/renderer/screen... content/renderer/screen_orientation/OWNERS:4: # COMPONENT: Blink>PresentationAPI same as above, screen_orientation has no team/component. https://codereview.chromium.org/2651023003/diff/60001/device/screen_orientati... File device/screen_orientation/OWNERS (right): https://codereview.chromium.org/2651023003/diff/60001/device/screen_orientati... device/screen_orientation/OWNERS:5: # COMPONENT: Blink>PresentationAPI ditto https://codereview.chromium.org/2651023003/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/modules/app_banner/OWNERS (right): https://codereview.chromium.org/2651023003/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/modules/app_banner/OWNERS:5: # COMPONENT: Blink>PresentationAPI Maybe COMPONENT:Content>WebApps. I don't think the TEAM is correct. https://codereview.chromium.org/2651023003/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/modules/mediasession/OWNERS (right): https://codereview.chromium.org/2651023003/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/modules/mediasession/OWNERS:10: # COMPONENT: Blink>PresentationAPI TEAM: chrome-media-lon@ COMPONENT: Internals>Media>Session https://codereview.chromium.org/2651023003/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/modules/remoteplayback/OWNERS (right): https://codereview.chromium.org/2651023003/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/modules/remoteplayback/OWNERS:4: # TEAM: chrome-multiscreen@google.com chrome-media-lon@ https://codereview.chromium.org/2651023003/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/modules/remoteplayback/OWNERS:5: # COMPONENT: Blink>PresentationAPI Blink>RemotePlayback should be created https://codereview.chromium.org/2651023003/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/modules/screen_orientation/OWNERS (right): https://codereview.chromium.org/2651023003/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/modules/screen_orientation/OWNERS:4: # COMPONENT: Blink>PresentationAPI as above https://codereview.chromium.org/2651023003/diff/60001/third_party/WebKit/publ... File third_party/WebKit/public/platform/modules/app_banner/OWNERS (right): https://codereview.chromium.org/2651023003/diff/60001/third_party/WebKit/publ... third_party/WebKit/public/platform/modules/app_banner/OWNERS:7: # COMPONENT: Blink>PresentationAPI As said in another comment, not the right TEAM/COMPONENT. https://codereview.chromium.org/2651023003/diff/60001/third_party/WebKit/publ... File third_party/WebKit/public/platform/modules/screen_orientation/OWNERS (right): https://codereview.chromium.org/2651023003/diff/60001/third_party/WebKit/publ... third_party/WebKit/public/platform/modules/screen_orientation/OWNERS:7: # COMPONENT: Blink>PresentationAPI same as above
Patchset #4 (id:80001) has been deleted
https://codereview.chromium.org/2651023003/diff/60001/chrome/android/javatest... File chrome/android/javatests/src/org/chromium/chrome/browser/media/OWNERS (right): https://codereview.chromium.org/2651023003/diff/60001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/media/OWNERS:6: # COMPONENT: Blink>Media On 2017/01/28 01:51:37, mlamouri (slow) wrote: > Internals>Media>UI maybe? Done. https://codereview.chromium.org/2651023003/diff/60001/chrome/android/junit/sr... File chrome/android/junit/src/org/chromium/chrome/browser/media/ui/OWNERS (right): https://codereview.chromium.org/2651023003/diff/60001/chrome/android/junit/sr... chrome/android/junit/src/org/chromium/chrome/browser/media/ui/OWNERS:6: # COMPONENT: Blink>Media On 2017/01/28 01:51:37, mlamouri (slow) wrote: > Internals>Media>UI Done. https://codereview.chromium.org/2651023003/diff/60001/content/browser/media/s... File content/browser/media/session/OWNERS (right): https://codereview.chromium.org/2651023003/diff/60001/content/browser/media/s... content/browser/media/session/OWNERS:5: # COMPONENT: Blink>Media On 2017/01/28 01:51:37, mlamouri (slow) wrote: > Internals>Media>Session Done. https://codereview.chromium.org/2651023003/diff/60001/content/browser/screen_... File content/browser/screen_orientation/OWNERS (right): https://codereview.chromium.org/2651023003/diff/60001/content/browser/screen_... content/browser/screen_orientation/OWNERS:4: # COMPONENT: Blink>PresentationAPI On 2017/01/28 01:51:38, mlamouri (slow) wrote: > I don't think that's correct. There isn't really a team for this nor a > component. > > Ideally, we should create a Blink>ScreenOrientation component though. Thanks for the comments! I'll remove the team/component information for now. Could you please make a request here with details, and we can pick it up from there: https://codereview.chromium.org/2651023003/ Feel free to ping Shruthi if the component creation is blocked. +Shruthi https://codereview.chromium.org/2651023003/diff/60001/content/public/android/... File content/public/android/java/src/org/chromium/content/browser/OWNERS (right): https://codereview.chromium.org/2651023003/diff/60001/content/public/android/... content/public/android/java/src/org/chromium/content/browser/OWNERS:22: # COMPONENT: Content>WebApps On 2017/01/28 01:51:38, mlamouri (slow) wrote: > That doesn't look quite right. You might want to leave this out at the moment. Done. https://codereview.chromium.org/2651023003/diff/60001/content/public/android/... File content/public/android/javatests/src/org/chromium/content/browser/OWNERS (right): https://codereview.chromium.org/2651023003/diff/60001/content/public/android/... content/public/android/javatests/src/org/chromium/content/browser/OWNERS:25: # COMPONENT: Content>WebApps On 2017/01/28 01:51:38, mlamouri (slow) wrote: > ditto Done. https://codereview.chromium.org/2651023003/diff/60001/content/renderer/screen... File content/renderer/screen_orientation/OWNERS (right): https://codereview.chromium.org/2651023003/diff/60001/content/renderer/screen... content/renderer/screen_orientation/OWNERS:4: # COMPONENT: Blink>PresentationAPI On 2017/01/28 01:51:38, mlamouri (slow) wrote: > same as above, screen_orientation has no team/component. Done. https://codereview.chromium.org/2651023003/diff/60001/device/screen_orientati... File device/screen_orientation/OWNERS (right): https://codereview.chromium.org/2651023003/diff/60001/device/screen_orientati... device/screen_orientation/OWNERS:5: # COMPONENT: Blink>PresentationAPI On 2017/01/28 01:51:38, mlamouri (slow) wrote: > ditto Done. https://codereview.chromium.org/2651023003/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/modules/app_banner/OWNERS (right): https://codereview.chromium.org/2651023003/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/modules/app_banner/OWNERS:5: # COMPONENT: Blink>PresentationAPI On 2017/01/28 01:51:38, mlamouri (slow) wrote: > Maybe COMPONENT:Content>WebApps. I don't think the TEAM is correct. Done. https://codereview.chromium.org/2651023003/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/modules/mediasession/OWNERS (right): https://codereview.chromium.org/2651023003/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/modules/mediasession/OWNERS:10: # COMPONENT: Blink>PresentationAPI On 2017/01/28 01:51:38, mlamouri (slow) wrote: > TEAM: chrome-media-lon@ > COMPONENT: Internals>Media>Session Done. https://codereview.chromium.org/2651023003/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/modules/remoteplayback/OWNERS (right): https://codereview.chromium.org/2651023003/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/modules/remoteplayback/OWNERS:4: # TEAM: chrome-multiscreen@google.com On 2017/01/28 01:51:38, mlamouri (slow) wrote: > chrome-media-lon@ Done. https://codereview.chromium.org/2651023003/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/modules/remoteplayback/OWNERS:5: # COMPONENT: Blink>PresentationAPI On 2017/01/28 01:51:38, mlamouri (slow) wrote: > Blink>RemotePlayback should be created Blink>RemotePlayback sounds good. I'll remove the team/component information in this file for now. Could you please make a request here with details, and we can pick it up from there: https://codereview.chromium.org/2651023003/ Again, feel free to ping Shruthi if the component creation gets blocked. https://codereview.chromium.org/2651023003/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/modules/screen_orientation/OWNERS (right): https://codereview.chromium.org/2651023003/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/modules/screen_orientation/OWNERS:4: # COMPONENT: Blink>PresentationAPI On 2017/01/28 01:51:38, mlamouri (slow) wrote: > as above Done. https://codereview.chromium.org/2651023003/diff/60001/third_party/WebKit/publ... File third_party/WebKit/public/platform/modules/app_banner/OWNERS (right): https://codereview.chromium.org/2651023003/diff/60001/third_party/WebKit/publ... third_party/WebKit/public/platform/modules/app_banner/OWNERS:7: # COMPONENT: Blink>PresentationAPI On 2017/01/28 01:51:38, mlamouri (slow) wrote: > As said in another comment, not the right TEAM/COMPONENT. Done. https://codereview.chromium.org/2651023003/diff/60001/third_party/WebKit/publ... File third_party/WebKit/public/platform/modules/screen_orientation/OWNERS (right): https://codereview.chromium.org/2651023003/diff/60001/third_party/WebKit/publ... third_party/WebKit/public/platform/modules/screen_orientation/OWNERS:7: # COMPONENT: Blink>PresentationAPI On 2017/01/28 01:51:38, mlamouri (slow) wrote: > same as above Done.
Patchset #4 (id:100001) has been deleted
Just got update and remove @google groups. Only keep @chromium ones.
https://codereview.chromium.org/2651023003/diff/120001/chrome/android/java/sr... File chrome/android/java/src/org/chromium/chrome/browser/media/ui/OWNERS (right): https://codereview.chromium.org/2651023003/diff/120001/chrome/android/java/sr... chrome/android/java/src/org/chromium/chrome/browser/media/ui/OWNERS:4: # COMPONENT: Blink>Media Internals>Media>UI https://codereview.chromium.org/2651023003/diff/120001/chrome/browser/permiss... File chrome/browser/permissions/OWNERS (right): https://codereview.chromium.org/2651023003/diff/120001/chrome/browser/permiss... chrome/browser/permissions/OWNERS:8: nit: remove empty line https://codereview.chromium.org/2651023003/diff/120001/content/public/android... File content/public/android/javatests/src/org/chromium/content/browser/OWNERS (right): https://codereview.chromium.org/2651023003/diff/120001/content/public/android... content/public/android/javatests/src/org/chromium/content/browser/OWNERS:25: # COMPONENT: Content>WebApps Please remove this COMPONENT, this is a generic directory, it's not WebApps specific. https://codereview.chromium.org/2651023003/diff/120001/content/public/test/an... File content/public/test/android/javatests/src/org/chromium/content/browser/test/util/OWNERS (right): https://codereview.chromium.org/2651023003/diff/120001/content/public/test/an... content/public/test/android/javatests/src/org/chromium/content/browser/test/util/OWNERS:5: # COMPONENT: Test I would recommend doing this change in another CL. https://codereview.chromium.org/2651023003/diff/120001/device/screen_orientat... File device/screen_orientation/OWNERS (right): https://codereview.chromium.org/2651023003/diff/120001/device/screen_orientat... device/screen_orientation/OWNERS:4: # TEAM: chrome-multiscreen@google.com You missed this @google.com https://codereview.chromium.org/2651023003/diff/120001/device/screen_orientat... device/screen_orientation/OWNERS:5: # COMPONENT: Blink>PresentationAPI Please remove this component, this is not Presentation API. https://codereview.chromium.org/2651023003/diff/120001/third_party/WebKit/Sou... File third_party/WebKit/Source/core/html/shadow/OWNERS (right): https://codereview.chromium.org/2651023003/diff/120001/third_party/WebKit/Sou... third_party/WebKit/Source/core/html/shadow/OWNERS:4: # COMPONENT: Blink>HTML I'm not the right person to review this even though it sounds fine. https://codereview.chromium.org/2651023003/diff/120001/third_party/WebKit/pub... File third_party/WebKit/public/platform/modules/screen_orientation/OWNERS (right): https://codereview.chromium.org/2651023003/diff/120001/third_party/WebKit/pub... third_party/WebKit/public/platform/modules/screen_orientation/OWNERS:6: # COMPONENT: Blink>PresentationAPI ditto
*/media/router/OWNERS LGTM - thanks for resolving the TEAMS question!
On 2017/01/31 18:44:22, Wez wrote: > */media/router/OWNERS LGTM - thanks for resolving the TEAMS question! Thank you for bringing it up, Wez!
Patchset #5 (id:140001) has been deleted
https://codereview.chromium.org/2651023003/diff/120001/chrome/android/java/sr... File chrome/android/java/src/org/chromium/chrome/browser/media/ui/OWNERS (right): https://codereview.chromium.org/2651023003/diff/120001/chrome/android/java/sr... chrome/android/java/src/org/chromium/chrome/browser/media/ui/OWNERS:4: # COMPONENT: Blink>Media On 2017/01/31 17:29:27, mlamouri (slow - BlinkOn) wrote: > Internals>Media>UI Done. https://codereview.chromium.org/2651023003/diff/120001/chrome/browser/permiss... File chrome/browser/permissions/OWNERS (right): https://codereview.chromium.org/2651023003/diff/120001/chrome/browser/permiss... chrome/browser/permissions/OWNERS:8: On 2017/01/31 17:29:27, mlamouri (slow - BlinkOn) wrote: > nit: remove empty line Done. https://codereview.chromium.org/2651023003/diff/120001/content/public/android... File content/public/android/javatests/src/org/chromium/content/browser/OWNERS (right): https://codereview.chromium.org/2651023003/diff/120001/content/public/android... content/public/android/javatests/src/org/chromium/content/browser/OWNERS:25: # COMPONENT: Content>WebApps On 2017/01/31 17:29:27, mlamouri (slow - BlinkOn) wrote: > Please remove this COMPONENT, this is a generic directory, it's not WebApps > specific. Done. https://codereview.chromium.org/2651023003/diff/120001/content/public/test/an... File content/public/test/android/javatests/src/org/chromium/content/browser/test/util/OWNERS (right): https://codereview.chromium.org/2651023003/diff/120001/content/public/test/an... content/public/test/android/javatests/src/org/chromium/content/browser/test/util/OWNERS:5: # COMPONENT: Test On 2017/01/31 17:29:27, mlamouri (slow - BlinkOn) wrote: > I would recommend doing this change in another CL. Done. https://codereview.chromium.org/2651023003/diff/120001/device/screen_orientat... File device/screen_orientation/OWNERS (right): https://codereview.chromium.org/2651023003/diff/120001/device/screen_orientat... device/screen_orientation/OWNERS:4: # TEAM: chrome-multiscreen@google.com On 2017/01/31 17:29:27, mlamouri (slow - BlinkOn) wrote: > You missed this @google.com Done. https://codereview.chromium.org/2651023003/diff/120001/device/screen_orientat... device/screen_orientation/OWNERS:5: # COMPONENT: Blink>PresentationAPI On 2017/01/31 17:29:27, mlamouri (slow - BlinkOn) wrote: > Please remove this component, this is not Presentation API. Done. https://codereview.chromium.org/2651023003/diff/120001/third_party/WebKit/Sou... File third_party/WebKit/Source/core/html/shadow/OWNERS (right): https://codereview.chromium.org/2651023003/diff/120001/third_party/WebKit/Sou... third_party/WebKit/Source/core/html/shadow/OWNERS:4: # COMPONENT: Blink>HTML On 2017/01/31 17:29:27, mlamouri (slow - BlinkOn) wrote: > I'm not the right person to review this even though it sounds fine. Done. https://codereview.chromium.org/2651023003/diff/120001/third_party/WebKit/pub... File third_party/WebKit/public/platform/modules/screen_orientation/OWNERS (right): https://codereview.chromium.org/2651023003/diff/120001/third_party/WebKit/pub... third_party/WebKit/public/platform/modules/screen_orientation/OWNERS:6: # COMPONENT: Blink>PresentationAPI On 2017/01/31 17:29:27, mlamouri (slow - BlinkOn) wrote: > ditto Done.
https://codereview.chromium.org/2651023003/diff/160001/third_party/WebKit/pub... File third_party/WebKit/public/platform/modules/screen_orientation/OWNERS (right): https://codereview.chromium.org/2651023003/diff/160001/third_party/WebKit/pub... third_party/WebKit/public/platform/modules/screen_orientation/OWNERS:6: # COMPONENT: Blink>PresentationAPI Please do not use this COMPONENT for screen_orientation
https://codereview.chromium.org/2651023003/diff/160001/third_party/WebKit/pub... File third_party/WebKit/public/platform/modules/screen_orientation/OWNERS (right): https://codereview.chromium.org/2651023003/diff/160001/third_party/WebKit/pub... third_party/WebKit/public/platform/modules/screen_orientation/OWNERS:6: # COMPONENT: Blink>PresentationAPI On 2017/02/07 12:29:13, mlamouri wrote: > Please do not use this COMPONENT for screen_orientation Sure. I'll remove this component. Thanks. Any suggestion on TEAM/COMPONENT for screen_orientation OWNERS files?
On 2017/02/07 at 18:19:31, ymzhang wrote: > https://codereview.chromium.org/2651023003/diff/160001/third_party/WebKit/pub... > File third_party/WebKit/public/platform/modules/screen_orientation/OWNERS (right): > > https://codereview.chromium.org/2651023003/diff/160001/third_party/WebKit/pub... > third_party/WebKit/public/platform/modules/screen_orientation/OWNERS:6: # COMPONENT: Blink>PresentationAPI > On 2017/02/07 12:29:13, mlamouri wrote: > > Please do not use this COMPONENT for screen_orientation > > Sure. I'll remove this component. Thanks. Thanks :) > Any suggestion on TEAM/COMPONENT for screen_orientation OWNERS files? There is no TEAM, really. If and when the bug flow become high enough I might move ownership to a different team but so far, I keep maintaining this feature on the side. There is no component too but one could be created (Blink>ScreenOrientation).
lgtm
On 2017/02/08 12:23:39, mlamouri wrote: > On 2017/02/07 at 18:19:31, ymzhang wrote: > > > https://codereview.chromium.org/2651023003/diff/160001/third_party/WebKit/pub... > > File third_party/WebKit/public/platform/modules/screen_orientation/OWNERS > (right): > > > > > https://codereview.chromium.org/2651023003/diff/160001/third_party/WebKit/pub... > > third_party/WebKit/public/platform/modules/screen_orientation/OWNERS:6: # > COMPONENT: Blink>PresentationAPI > > On 2017/02/07 12:29:13, mlamouri wrote: > > > Please do not use this COMPONENT for screen_orientation > > > > Sure. I'll remove this component. Thanks. > > Thanks :) > > > Any suggestion on TEAM/COMPONENT for screen_orientation OWNERS files? > > There is no TEAM, really. If and when the bug flow become high enough I might > move ownership to a different team but so far, I keep maintaining this feature > on the side. There is no component too but one could be created > (Blink>ScreenOrientation). Sure. We could add it if this component is created in the future. Thanks!
The CQ bit was checked by ymzhang@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mfoltz@chromium.org, wez@chromium.org Link to the patchset: https://codereview.chromium.org/2651023003/#ps180001 (title: "update component")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 180001, "attempt_start_ts": 1486685694616900,
"parent_rev": "702088eb963aa60794ee2ab479b8cd1b9ef4fbf2", "commit_rev":
"55fad71126046d6d84bd763c34a45476444fce09"}
Message was sent while issue was closed.
Description was changed from ========== add TEAM/COMPONENT BUG=679905 R=mlamouri ========== to ========== add TEAM/COMPONENT BUG=679905 R=mlamouri Review-Url: https://codereview.chromium.org/2651023003 Cr-Commit-Position: refs/heads/master@{#449507} Committed: https://chromium.googlesource.com/chromium/src/+/55fad71126046d6d84bd763c34a4... ==========
Message was sent while issue was closed.
Committed patchset #6 (id:180001) as https://chromium.googlesource.com/chromium/src/+/55fad71126046d6d84bd763c34a4... |
