Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2650973003: objects.h splitting: include less objects/ files. (Closed)

Created:
3 years, 11 months ago by marja
Modified:
3 years, 11 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

objects.h splitting: include less objects/ files. Using a Handle<Foo> as a member doesn't require including foo.h R=mstarzinger@chromium.org BUG=v8:5402 Review-Url: https://codereview.chromium.org/2650973003 Cr-Commit-Position: refs/heads/master@{#42631} Committed: https://chromium.googlesource.com/v8/v8/+/4aedeb1bd50c12ebcd6cf954c4cbef1205fff5ac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/ast/scopes.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ast/scopes.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/parsing/parse-info.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/parsing/parse-info.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
marja
ptal
3 years, 11 months ago (2017-01-24 12:15:09 UTC) #1
Michael Starzinger
LGTM. Nice.
3 years, 11 months ago (2017-01-24 13:17:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650973003/1
3 years, 11 months ago (2017-01-24 13:23:19 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 13:24:59 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/4aedeb1bd50c12ebcd6cf954c4cbef1205f...

Powered by Google App Engine
This is Rietveld 408576698