Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 2650963003: Add NeedsManualRebaseline to TestExpectations that's not covered by CQ (Closed)

Created:
3 years, 11 months ago by ktyliu
Modified:
3 years, 11 months ago
Reviewers:
sashab
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add NeedsManualRebaseline to TestExpectations that's not covered by CQ BUG=680407 Review-Url: https://codereview.chromium.org/2650963003 Cr-Commit-Position: refs/heads/master@{#445903} Committed: https://chromium.googlesource.com/chromium/src/+/13949c88b4d34c723921fc1ff975fb6593a651ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
ktyliu
Hi Sasha, Can we add NeedsManualRebaseline as it seems one test is not updated properly ...
3 years, 11 months ago (2017-01-25 00:17:03 UTC) #4
sashab
lgtm
3 years, 11 months ago (2017-01-25 00:47:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650963003/1
3 years, 11 months ago (2017-01-25 01:34:21 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 01:41:08 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/13949c88b4d34c723921fc1ff975...

Powered by Google App Engine
This is Rietveld 408576698