[debug] remove StepFrame

[debug] remove StepFrame

This action was used by inspector for blackboxing and isn't needed with new blackboxing implementation inside V8.

BUG=none
R=yangguo@chromium.org,clemensh@chromium.org
TBR=bmeurer@chromium.org

Review-Url: https://codereview.chromium.org/2650943011
Cr-Commit-Position: refs/heads/master@{#42670}
Committed: https://chromium.googlesource.com/v8/v8/+/bc7eb04d925fa3d4b07c163f6708808177c6c843

[kozy, 2017-01-25 20:21:05]

Yang, please take a look.

https://codereview.chromium.org/2650943011/diff/1/src/debug/debug.cc
File src/debug/debug.cc (left):

https://codereview.chromium.org/2650943011/diff/1/src/debug/debug.cc#oldcode1089
src/debug/debug.cc:1089: FloodWithOneShot(function, CALLS_AND_RETURNS);
We could remove CALLS_AND_RETURNS as well. But as I understood your're going to
use it for break_on_function_entry.

[kozy, 2017-01-25 20:21:12]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 20:21:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yang, 2017-01-25 20:25:18]

On 2017/01/25 20:21:05, kozy wrote:
> Yang, please take a look.
> 
> https://codereview.chromium.org/2650943011/diff/1/src/debug/debug.cc
> File src/debug/debug.cc (left):
> 
>
https://codereview.chromium.org/2650943011/diff/1/src/debug/debug.cc#oldcode1089
> src/debug/debug.cc:1089: FloodWithOneShot(function, CALLS_AND_RETURNS);
> We could remove CALLS_AND_RETURNS as well. But as I understood your're going
to
> use it for break_on_function_entry.

ports for other platforms than x64 are missing

[kozy, 2017-01-25 20:43:41]

On 2017/01/25 20:25:18, Yang wrote:
> ports for other platforms than x64 are missing

Hm.. It looks like STATIC_ASERT was presented only on x64 [1] or I just don't
understand something in V8 :)

[1] https://cs.chromium.org/search/?q=StepFrame&sq=package:chromium&type=cs

[Yang, 2017-01-25 20:59:07]

On 2017/01/25 20:43:41, kozy wrote:
> On 2017/01/25 20:25:18, Yang wrote:
> > ports for other platforms than x64 are missing
> 
> Hm.. It looks like STATIC_ASERT was presented only on x64 [1] or I just don't
> understand something in V8 :)
> 
> [1] https://cs.chromium.org/search/?q=StepFrame&sq=package:chromium&type=cs

i see. lgtm.

[kozy, 2017-01-25 21:08:14]

The CQ bit was unchecked by kozyatinskiy@chromium.org

[kozy, 2017-01-25 21:08:20]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2017-01-25 21:08:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 21:12:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 21:12:03]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/33362)

[kozy, 2017-01-25 21:35:23]

Clemens, please take a look on wasm changes.

[kozy, 2017-01-25 21:37:01]

Description was changed from

==========
[debug] remove StepFrame

This action was used by inspector for blackboxing and isn't needed with new
blackboxing implementation inside V8.

BUG=none
R=yangguo@chromium.org
==========

to

==========
[debug] remove StepFrame

This action was used by inspector for blackboxing and isn't needed with new
blackboxing implementation inside V8.

BUG=none
R=yangguo@chromium.org,clemensh@chromium.org
==========

[kozy, 2017-01-25 21:37:01]

kozyatinskiy@chromium.org changed reviewers:
+ clemensh@chromium.org

[kozy, 2017-01-25 21:37:23]

Description was changed from

==========
[debug] remove StepFrame

This action was used by inspector for blackboxing and isn't needed with new
blackboxing implementation inside V8.

BUG=none
R=yangguo@chromium.org,clemensh@chromium.org
==========

to

==========
[debug] remove StepFrame

This action was used by inspector for blackboxing and isn't needed with new
blackboxing implementation inside V8.

BUG=none
R=yangguo@chromium.org,clemensh@chromium.org
TBR=bmeurer@chromium.org
==========

[kozy, 2017-01-25 21:38:07]

Oops. added Clemens as reviewer in addition to comment :)

[clemensh, 2017-01-25 22:41:49]

clemensh@google.com changed reviewers:
+ clemensh@google.com

[clemensh, 2017-01-25 22:41:49]

lgtm

[Clemens Hammacher, 2017-01-25 22:43:02]

clemensh@chromium.org changed reviewers:
- clemensh@google.com

[Clemens Hammacher, 2017-01-25 22:43:02]

Oops, wrong browser window (==wrong account). 
LGTM

[kozy, 2017-01-25 23:07:40]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2017-01-25 23:07:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 23:50:58]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485385660808150, "parent_rev":
"f7a3ede0820ee6c30ac6e5199536a0c60f69d331", "commit_rev":
"bc7eb04d925fa3d4b07c163f6708808177c6c843"}

[commit-bot: I haz the power, 2017-01-25 23:51:03]

Description was changed from

==========
[debug] remove StepFrame

This action was used by inspector for blackboxing and isn't needed with new
blackboxing implementation inside V8.

BUG=none
R=yangguo@chromium.org,clemensh@chromium.org
TBR=bmeurer@chromium.org
==========

to

==========
[debug] remove StepFrame

This action was used by inspector for blackboxing and isn't needed with new
blackboxing implementation inside V8.

BUG=none
R=yangguo@chromium.org,clemensh@chromium.org
TBR=bmeurer@chromium.org

Review-Url: https://codereview.chromium.org/2650943011
Cr-Commit-Position: refs/heads/master@{#42670}
Committed:
https://chromium.googlesource.com/v8/v8/+/bc7eb04d925fa3d4b07c163f6708808177c...
==========

[commit-bot: I haz the power, 2017-01-25 23:51:04]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/bc7eb04d925fa3d4b07c163f6708808177c...