Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 2650943010: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 11 months ago by ymzhang1
Modified:
3 years, 9 months ago
Reviewers:
ncarter (slow), mcasas
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, emircan+watch+mediarecorder_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, mcasas+watch+mediarecorder_chromium.org, abarth-chromium, haraken, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, agrieve+watch_chromium.org, blink-reviews, xjz+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. Adding COMPONENT/TEAM information into OWNERS file. Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: List of components https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 Review-Url: https://codereview.chromium.org/2650943010 Cr-Commit-Position: refs/heads/master@{#446216} Committed: https://chromium.googlesource.com/chromium/src/+/d1fd836e3f69578eb72e52d2da6f2f3106aa2d4b

Patch Set 1 #

Total comments: 21

Patch Set 2 : update team/compo #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -1 line) Patch
M content/browser/media/capture/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/webrtc/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/media/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M device/geolocation/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M media/capture/video/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M media/capture/video/android/java/src/org/chromium/media/OWNERS View 1 1 chunk +3 lines, -0 lines 1 comment Download
M media/muxers/OWNERS View 1 1 chunk +3 lines, -1 line 0 comments Download
M services/video_capture/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/imagecapture/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediacapturefromelement/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediarecorder/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/decklink/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/libwebm/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 11 months ago (2017-01-25 19:39:55 UTC) #2
mcasas
https://codereview.chromium.org/2650943010/diff/1/content/browser/media/capture/OWNERS File content/browser/media/capture/OWNERS (right): https://codereview.chromium.org/2650943010/diff/1/content/browser/media/capture/OWNERS#newcode7 content/browser/media/capture/OWNERS:7: # COMPONENT: Internals>Media>Capture Yeah, this component is confusing and ...
3 years, 11 months ago (2017-01-25 20:48:50 UTC) #3
ymzhang1
Thanks for the suggestions! Update the COMPONENT information, and add media-capture-and-streams@grotations.appspotmail.com as team mailing list ...
3 years, 11 months ago (2017-01-25 23:33:37 UTC) #4
mcasas
lgtm https://codereview.chromium.org/2650943010/diff/20001/media/capture/video/android/java/src/org/chromium/media/OWNERS File media/capture/video/android/java/src/org/chromium/media/OWNERS (right): https://codereview.chromium.org/2650943010/diff/20001/media/capture/video/android/java/src/org/chromium/media/OWNERS#newcode4 media/capture/video/android/java/src/org/chromium/media/OWNERS:4: # media-capture-and-streams@grotations.appspotmail.com nit: prefix with TEAM.
3 years, 11 months ago (2017-01-26 00:02:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650943010/20001
3 years, 11 months ago (2017-01-26 00:05:04 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/350525)
3 years, 11 months ago (2017-01-26 00:18:23 UTC) #9
ncarter (slow)
lgtm
3 years, 11 months ago (2017-01-26 00:35:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650943010/20001
3 years, 11 months ago (2017-01-26 01:34:42 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 03:04:37 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d1fd836e3f69578eb72e52d2da6f...

Powered by Google App Engine
This is Rietveld 408576698