Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2650943009: [DevTools] increase AsyncCallStackDepth to 8 (Closed)

Created:
3 years, 10 months ago by kozy
Modified:
3 years, 10 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] increase AsyncCallStackDepth to 8 Amount of stored stack traces are limits in v8 after [1]. After landing better async stacks for promises [2] we won't omit empty asynchronous stack traces to provide information where promise is chained, so we need bigger limit to be useful. [1] https://codereview.chromium.org/2579403002/ [2] https://codereview.chromium.org/2648873002/ BUG=v8:5738 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2650943009 Cr-Commit-Position: refs/heads/master@{#446224} Committed: https://chromium.googlesource.com/chromium/src/+/00427c5f26e25fd1c188a46ce5e2798e32ca05b4

Patch Set 1 #

Patch Set 2 : fixed test #

Patch Set 3 : changed stack depth in tests #

Patch Set 4 : added missing test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -39 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/async-callstack-fetch.html View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/async-callstack-network-initiator.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/profiler/agents-disabled-check-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-await/async-callstack-async-await1.html View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-await/async-callstack-async-await2.html View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-await/async-callstack-async-await3.html View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack.html View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-events.html View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-expected.txt View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-get-as-string.html View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-in-console.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-indexed-db.html View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-indexed-db-expected.txt View 1 2 3 chunks +15 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-middle-run.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-mutation-observer.html View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-mutation-observer-expected.txt View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-post-message.html View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-post-message-expected.txt View 1 2 3 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-promises.html View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-promises-expected.txt View 1 2 6 chunks +56 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-reload-no-crash.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-scripted-scroll.html View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-set-interval.html View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-web-sql.html View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-xhrs.html View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-with-async-callstack.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-with-async-callstack-expected.txt View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js View 1 2 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
kozy
Dmitry, please take a look. Surprisingly all our tests currently dump less then 5 async ...
3 years, 10 months ago (2017-01-25 02:00:15 UTC) #1
dgozman
On 2017/01/25 02:00:15, kozy wrote: > Dmitry, please take a look. Surprisingly all our tests ...
3 years, 10 months ago (2017-01-25 23:28:41 UTC) #2
kozy
Increased limit for all tests.
3 years, 10 months ago (2017-01-26 01:37:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650943009/40001
3 years, 10 months ago (2017-01-26 01:38:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650943009/60001
3 years, 10 months ago (2017-01-26 01:58:19 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-01-26 04:18:49 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/00427c5f26e25fd1c188a46ce5e2...

Powered by Google App Engine
This is Rietveld 408576698