Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 2650943004: Revert "UMA metrics for fractions of wheel and touch scrolls blocked on the main thread." (Closed)

Created:
3 years, 11 months ago by Dan Beam
Modified:
3 years, 11 months ago
CC:
chromium-reviews, dtapuska+chromiumwatch_chromium.org, asvitkine+watch_chromium.org, tdresser+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "UMA metrics for fractions of wheel and touch scrolls blocked on the main thread." This reverts commit 24b30bfd5ac15c60a29477638c91ab0fb8159055. Broke events_unittests on Linux Tests (dbg)(1)(32): https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20(dbg)(1)(32) With a problem of: AnimateInput/InputHandlerProxyTest.GestureScrollingThreadStatusHistograms/0 (run #1): [ RUN ] AnimateInput/InputHandlerProxyTest.GestureScrollingThreadStatusHistograms/0 [6128:6128:0123/172239.190828:1350397596:FATAL:input_handler_proxy.cc(797)] Check failed: !expect_scroll_update_end_. TBR=sahel@chromium.org,dtapuska@chromium.org,tdresser@chromium.org,holte@chromium.org BUG=626662, 626663 NOTRY=true NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2650943004 Cr-Commit-Position: refs/heads/master@{#445666} Committed: https://chromium.googlesource.com/chromium/src/+/9f4f936297a58457a6726d361bcb013e45ade2a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -245 lines) Patch
M tools/metrics/histograms/histograms.xml View 3 chunks +0 lines, -28 lines 0 comments Download
M ui/events/blink/input_handler_proxy.h View 2 chunks +0 lines, -6 lines 0 comments Download
M ui/events/blink/input_handler_proxy.cc View 6 chunks +4 lines, -76 lines 0 comments Download
M ui/events/blink/input_handler_proxy_unittest.cc View 2 chunks +1 line, -135 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Dan Beam
3 years, 11 months ago (2017-01-24 06:29:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650943004/1
3 years, 11 months ago (2017-01-24 06:29:53 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/9f4f936297a58457a6726d361bcb013e45ade2a2
3 years, 11 months ago (2017-01-24 06:35:14 UTC) #7
sahel
3 years, 11 months ago (2017-01-25 15:59:35 UTC) #8
Message was sent while issue was closed.
On 2017/01/24 06:35:14, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/9f4f936297a58457a6726d361bcb...

lgtm

Powered by Google App Engine
This is Rietveld 408576698