Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2650923003: Rename w3c test importer script update-w3c-deps -> wpt-import. (Closed)

Created:
3 years, 11 months ago by qyearsley
Modified:
3 years, 11 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename w3c test importer script update-w3c-deps -> wpt-import. Reason: This name is meant to be clearer and more consistent with related scripts. Note that I want to call it "wpt-import" instead of "w3c-import" because there are plans to merge csswg-test into wpt, and I want to call it "wpt-import" instead of "wpt-update" because this makes its relationship with "wpt-export" clearer. BUG=681406 Review-Url: https://codereview.chromium.org/2650923003 Cr-Commit-Position: refs/heads/master@{#446044} Committed: https://chromium.googlesource.com/chromium/src/+/6fe839799893f3d82b5ab6ccfe0e759f8044c091

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -23 lines) Patch
M third_party/WebKit/LayoutTests/external/README View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/update-w3c-deps View 1 chunk +0 lines, -20 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Tools/Scripts/wpt-import View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
qyearsley
Note, when this is committed, the invocation in the recipe (https://chromium-review.googlesource.com/c/432038/) and the docs (https://www.chromium.org/blink/importing-the-w3c-tests) ...
3 years, 11 months ago (2017-01-24 23:33:54 UTC) #3
jeffcarp
lgtm
3 years, 11 months ago (2017-01-25 00:42:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650923003/1
3 years, 11 months ago (2017-01-25 17:05:44 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 17:11:29 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6fe839799893f3d82b5ab6ccfe0e...

Powered by Google App Engine
This is Rietveld 408576698