Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2650913008: Renamed CRWWebStateDelegateStub to CRWMockWebStateDelegate. (Closed)

Created:
3 years, 11 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 11 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renamed CRWWebStateDelegateStub to CRWMockWebStateDelegate. BUG=683983 Review-Url: https://codereview.chromium.org/2650913008 Cr-Commit-Position: refs/heads/master@{#446351} Committed: https://chromium.googlesource.com/chromium/src/+/21465d6d72621e99b6c25c161db19d3ab0a54fcd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -123 lines) Patch
M ios/web/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
A + ios/web/public/test/crw_mock_web_state_delegate.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ios/web/public/test/crw_mock_web_state_delegate.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/web/web_state/web_state_delegate_bridge_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
D ios/web/web_state/web_state_delegate_stub.h View 1 chunk +0 lines, -35 lines 0 comments Download
D ios/web/web_state/web_state_delegate_stub.mm View 1 chunk +0 lines, -77 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Eugene But (OOO till 7-30)
3 years, 11 months ago (2017-01-25 19:45:15 UTC) #6
marq (ping after 24h)
lgtm
3 years, 11 months ago (2017-01-26 09:06:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650913008/1
3 years, 11 months ago (2017-01-26 16:34:06 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 16:43:39 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/21465d6d72621e99b6c25c161db1...

Powered by Google App Engine
This is Rietveld 408576698