Send keyboard-derived commands only if the key events are sent

Send keyboard-derived commands only if the key events are sent

There was a regression in https://codereview.chromium.org/2482853002

Previously, when a keydown was handled on the browser side, the keypress
was suppressed but the keyup was not. Now, all three events are
suppressed. However, the fix did not take into consideration the
InputMsg_SetEditCommandsForNextKeyEvent messages sent right before the
call to RenderWidgetHostImpl::ForwardKeyboardEvent at two call sites.
Because the keyup event was also suppressed, those commands would
instead be associated with a following keydown.

See https://bugs.chromium.org/p/chromium/issues/detail?id=677827#c11 for
how that could end up dropping the keypress event of what followed.

The fix is to introduce a ForwardKeyboardEventWithCommands which sends
the commands only if they key itself is sent.

BUG=677827
Review-Url: https://codereview.chromium.org/2644843004
Cr-Commit-Position: refs/heads/master@{#445687}
(cherry picked from commit b7b0799fa40dd39cc93e826e6bacfea41231d989)

Review-Url: https://codereview.chromium.org/2650913006 .
Cr-Commit-Position: refs/branch-heads/2987@{#84}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed: https://chromium.googlesource.com/chromium/src/+/69e39c484ec2f1f3b7320f07f43fd0724b6cb382

[foolip, 2017-01-25 09:54:34]

Description was changed from

==========
Send keyboard-derived commands only if the key events are sent

There was a regression in https://codereview.chromium.org/2482853002

Previously, when a keydown was handled on the browser side, the keypress
was suppressed but the keyup was not. Now, all three events are
suppressed. However, the fix did not take into consideration the
InputMsg_SetEditCommandsForNextKeyEvent messages sent right before the
call to RenderWidgetHostImpl::ForwardKeyboardEvent at two call sites.
Because the keyup event was also suppressed, those commands would
instead be associated with a following keydown.

See https://bugs.chromium.org/p/chromium/issues/detail?id=677827#c11 for
how that could end up dropping the keypress event of what followed.

The fix is to introduce a ForwardKeyboardEventWithCommands which sends
the commands only if they key itself is sent.

BUG=677827

Review-Url: https://codereview.chromium.org/2644843004
Cr-Commit-Position: refs/heads/master@{#445687}
(cherry picked from commit b7b0799fa40dd39cc93e826e6bacfea41231d989)
==========

to

==========
Send keyboard-derived commands only if the key events are sent

There was a regression in https://codereview.chromium.org/2482853002

Previously, when a keydown was handled on the browser side, the keypress
was suppressed but the keyup was not. Now, all three events are
suppressed. However, the fix did not take into consideration the
InputMsg_SetEditCommandsForNextKeyEvent messages sent right before the
call to RenderWidgetHostImpl::ForwardKeyboardEvent at two call sites.
Because the keyup event was also suppressed, those commands would
instead be associated with a following keydown.

See https://bugs.chromium.org/p/chromium/issues/detail?id=677827#c11 for
how that could end up dropping the keypress event of what followed.

The fix is to introduce a ForwardKeyboardEventWithCommands which sends
the commands only if they key itself is sent.

BUG=677827

Review-Url: https://codereview.chromium.org/2644843004
Cr-Commit-Position: refs/heads/master@{#445687}
(cherry picked from commit b7b0799fa40dd39cc93e826e6bacfea41231d989)

Review-Url: https://codereview.chromium.org/2650913006 .
Cr-Commit-Position: refs/branch-heads/2987@{#84}
Cr-Branched-From:
ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed:
https://chromium.googlesource.com/chromium/src/+/69e39c484ec2f1f3b7320f07f43f...
==========

[foolip, 2017-01-25 09:54:43]

Committed patchset #1 (id:1) manually as
69e39c484ec2f1f3b7320f07f43fd0724b6cb382.