|
Revert of [devtools] Support different encodings for Page.CaptureScreenshot. (patchset #8 id:480001 of https://codereview.chromium.org/2592983002/ )
Reason for revert:
Causing failures on "Mac10.11 Tests" builder:
https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.11%20Tests/builds/6881
[ RUN ] GrabWindowSnapshotTest.TestGrabWindowSnapshot
../../ui/snapshot/snapshot_mac_unittest.mm:45: Failure
Value of: CGImageGetWidth([rep CGImage])
Actual: 1
Expected: 400 * scaleFactor
Which is: 400
../../ui/snapshot/snapshot_mac_unittest.mm:49: Failure
Expected: (red + green + blue) >= (3.0), actual: 0 vs 3
[ FAILED ] GrabWindowSnapshotTest.TestGrabWindowSnapshot (31 ms)
Original issue's description:
> [devtools] Support different encodings for Page.CaptureScreenshot.
>
> This adds support for jpeg encoding of screenshots, similar to that for
> screencasts. For this purpose, the patch modifies ui::Grab*Snapshot*
> methods to return a gfx::Image instead of a png. Utility methods can
> then encode the gfx::Image to jpeg/png depending on its
> platform-specific backing representation.
>
> BUG= 676282
>
> Review-Url: https://codereview.chromium.org/2592983002
> Cr-Commit-Position: refs/heads/master@{#445730}
> Committed: https://chromium.googlesource.com/chromium/src/+/b6438b1ca6462f3cc014cd1bf18410957101a119
TBR=enne@chromium.org,avi@chromium.org,dtrainor@chromium.org,oshima@chromium.org,pfeldman@chromium.org,sadrul@chromium.org,dpranke@chromium.org,eseckler@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 676282
Review-Url: https://codereview.chromium.org/2650903003
Cr-Commit-Position: refs/heads/master@{#445741}
Committed: https://chromium.googlesource.com/chromium/src/+/1ae4ca9c8372d75a7cd617911c4e0bd4c65de33a
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+333 lines, -458 lines) |
Patch |
 |
M |
chrome/browser/android/feedback/screenshot_task.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.h
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.cc
|
View
|
|
6 chunks |
+23 lines, -18 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/chromeos/policy/remote_commands/screenshot_delegate.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/chromeos/policy/remote_commands/screenshot_delegate.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
content/browser/devtools/protocol/devtools_protocol_browsertest.cc
|
View
|
|
7 chunks |
+14 lines, -85 lines |
0 comments
|
Download
|
 |
M |
content/browser/devtools/protocol/page_handler.h
|
View
|
|
4 chunks |
+4 lines, -12 lines |
0 comments
|
Download
|
 |
M |
content/browser/devtools/protocol/page_handler.cc
|
View
|
|
6 chunks |
+37 lines, -34 lines |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/render_widget_host_impl.h
|
View
|
|
4 chunks |
+13 lines, -7 lines |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/render_widget_host_impl.cc
|
View
|
|
2 chunks |
+30 lines, -18 lines |
0 comments
|
Download
|
 |
M |
testing/buildbot/chromium.linux.json
|
View
|
|
3 chunks |
+0 lines, -18 lines |
0 comments
|
Download
|
 |
M |
testing/buildbot/chromium.mac.json
|
View
|
|
5 chunks |
+0 lines, -25 lines |
0 comments
|
Download
|
 |
M |
testing/buildbot/gn_isolate_map.pyl
|
View
|
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/core/inspector/browser_protocol.json
|
View
|
|
1 chunk |
+2 lines, -6 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
ui/gfx/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
ui/gfx/image/image_util.h
|
View
|
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
 |
M |
ui/gfx/image/image_util.cc
|
View
|
|
1 chunk |
+1 line, -11 lines |
0 comments
|
Download
|
 |
D |
ui/gfx/image/image_util_mac.mm
|
View
|
|
1 chunk |
+0 lines, -40 lines |
0 comments
|
Download
|
 |
M |
ui/snapshot/BUILD.gn
|
View
|
|
2 chunks |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
ui/snapshot/screenshot_grabber.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
ui/snapshot/screenshot_grabber.cc
|
View
|
|
4 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
ui/snapshot/snapshot.h
|
View
|
|
2 chunks |
+13 lines, -15 lines |
0 comments
|
Download
|
 |
D |
ui/snapshot/snapshot.cc
|
View
|
|
1 chunk |
+0 lines, -41 lines |
0 comments
|
Download
|
 |
M |
ui/snapshot/snapshot_android.cc
|
View
|
|
2 chunks |
+26 lines, -17 lines |
0 comments
|
Download
|
 |
M |
ui/snapshot/snapshot_async.h
|
View
|
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
ui/snapshot/snapshot_async.cc
|
View
|
|
3 chunks |
+38 lines, -4 lines |
0 comments
|
Download
|
 |
M |
ui/snapshot/snapshot_aura.cc
|
View
|
|
2 chunks |
+19 lines, -15 lines |
0 comments
|
Download
|
 |
M |
ui/snapshot/snapshot_aura_unittest.cc
|
View
|
|
8 chunks |
+28 lines, -18 lines |
0 comments
|
Download
|
 |
M |
ui/snapshot/snapshot_ios.mm
|
View
|
|
2 chunks |
+16 lines, -12 lines |
0 comments
|
Download
|
 |
M |
ui/snapshot/snapshot_mac.mm
|
View
|
|
5 chunks |
+32 lines, -17 lines |
0 comments
|
Download
|
 |
M |
ui/snapshot/snapshot_mac_unittest.mm
|
View
|
|
1 chunk |
+15 lines, -13 lines |
0 comments
|
Download
|
Total messages: 6 (3 generated)
|