Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp

Issue 2650863003: [tracing] Switch to new heap dump format. (Closed)
Patch Set: Rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp
diff --git a/third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp b/third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp
index d4077870cb4a24b2248731ff0b491e088bc20cd0..5856bb25c990a54762d5e300cee2ec8f5dcb9496 100644
--- a/third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp
+++ b/third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp
@@ -66,16 +66,7 @@ bool BlinkGCMemoryDumpProvider::OnMemoryDump(
DumpMemoryTotals(memory_dump);
if (allocation_register_.is_enabled()) {
- // Overhead should always be reported, regardless of light vs. heavy.
- base::trace_event::TraceEventMemoryOverhead overhead;
- std::unordered_map<base::trace_event::AllocationContext,
- base::trace_event::AllocationMetrics>
- metrics_by_context;
- if (level_of_detail == MemoryDumpLevelOfDetail::DETAILED) {
- allocation_register_.UpdateAndReturnsMetrics(metrics_by_context);
- }
- allocation_register_.EstimateTraceMemoryOverhead(&overhead);
- memory_dump->DumpHeapUsage(metrics_by_context, overhead, "blink_gc");
+ memory_dump->DumpHeapUsage(allocation_register_, "blink_gc");
}
// Merge all dumps collected by ThreadHeap::collectGarbage.

Powered by Google App Engine
This is Rietveld 408576698