third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp - Issue 2650863003: [tracing] Switch to new heap dump format.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp

Issue 2650863003: [tracing] Switch to new heap dump format. (Closed)

Patch Set: Rebase Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/trace_event/trace_event_memory_overhead.cc ('k') | third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp

diff --git a/third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp b/third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp

index 59269a23ddb36111e0d587e768524599fbfdc7fb..ff2bb460a7bbc42cf6ced8f3f9a68e61b78f1e35 100644

--- a/third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp

+++ b/third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp

@@ -135,17 +135,7 @@ bool PartitionAllocMemoryDumpProvider::OnMemoryDump(

MemoryDumpLevelOfDetail level_of_detail = args.level_of_detail;

if (allocation_register_.is_enabled()) {

- // Overhead should always be reported, regardless of light vs. heavy.

- base::trace_event::TraceEventMemoryOverhead overhead;

- std::unordered_map<base::trace_event::AllocationContext,

- base::trace_event::AllocationMetrics>

- metrics_by_context;

- // Dump only the overhead estimation in non-detailed dumps.

- if (level_of_detail == MemoryDumpLevelOfDetail::DETAILED) {

- allocation_register_.UpdateAndReturnsMetrics(metrics_by_context);

- }

- allocation_register_.EstimateTraceMemoryOverhead(&overhead);

- memory_dump->DumpHeapUsage(metrics_by_context, overhead, "partition_alloc");

+ memory_dump->DumpHeapUsage(allocation_register_, kPartitionAllocDumpName);

}

PartitionStatsDumperImpl partition_stats_dumper(memory_dump, level_of_detail);