Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2650853010: Add enable-service-worker-navigation-preload flag in chrome://flags (Closed)

Created:
3 years, 11 months ago by horo
Modified:
3 years, 10 months ago
Reviewers:
falken, rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add enable-service-worker-navigation-preload flag in chrome://flags This is useful especially for Android. BUG=649558 Review-Url: https://codereview.chromium.org/2650853010 Cr-Commit-Position: refs/heads/master@{#446830} Committed: https://chromium.googlesource.com/chromium/src/+/ebf15845426ed332bd1e2570c5a8488ad7e075ff

Patch Set 1 #

Total comments: 2

Patch Set 2 : incorporated falken's comment #

Patch Set 3 : update histograms.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 1 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
horo
falken@ Could you please review this?
3 years, 11 months ago (2017-01-27 04:16:34 UTC) #3
falken
lgtm https://codereview.chromium.org/2650853010/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2650853010/diff/1/chrome/app/generated_resources.grd#newcode6409 chrome/app/generated_resources.grd:6409: + Enable the experimental APIs of service worker ...
3 years, 11 months ago (2017-01-27 04:28:15 UTC) #4
horo
Thank you. https://codereview.chromium.org/2650853010/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2650853010/diff/1/chrome/app/generated_resources.grd#newcode6409 chrome/app/generated_resources.grd:6409: + Enable the experimental APIs of service ...
3 years, 11 months ago (2017-01-27 04:32:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650853010/20001
3 years, 11 months ago (2017-01-27 04:33:03 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/379385)
3 years, 11 months ago (2017-01-27 05:04:56 UTC) #10
horo
rkaplow@ Could you please review histograms.xml?
3 years, 11 months ago (2017-01-27 05:19:22 UTC) #14
rkaplow
lgtm
3 years, 10 months ago (2017-01-27 17:29:44 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650853010/40001
3 years, 10 months ago (2017-01-27 23:33:59 UTC) #20
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 23:40:19 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ebf15845426ed332bd1e2570c5a8...

Powered by Google App Engine
This is Rietveld 408576698