Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2650853008: [TypeFeedbackVector] Remove unnecessary Parameters metadata (Closed)

Created:
3 years, 11 months ago by mvstanton
Modified:
3 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[TypeFeedbackVector] Remove unnecessary Parameters metadata This is a remnant of a previous design to a solution yet to be checked in. BUG=v8:5456 R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2650853008 Cr-Commit-Position: refs/heads/master@{#42692} Committed: https://chromium.googlesource.com/v8/v8/+/73980ae4a19d9434e3c3eb927b7b005087157e32

Patch Set 1 #

Patch Set 2 : compilation failure. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -137 lines) Patch
M src/ast/ast.h View 2 chunks +2 lines, -8 lines 0 comments Download
M src/objects-printer.cc View 2 chunks +1 line, -10 lines 0 comments Download
M src/type-feedback-vector.h View 10 chunks +4 lines, -39 lines 0 comments Download
M src/type-feedback-vector.cc View 1 9 chunks +2 lines, -54 lines 0 comments Download
M src/type-feedback-vector-inl.h View 1 chunk +0 lines, -25 lines 0 comments Download
M test/cctest/test-feedback-vector.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
mvstanton
Hi Benedikt, Here is the CL I mentioned yesterday, thanks for the look! --Michael
3 years, 11 months ago (2017-01-26 10:56:32 UTC) #3
Benedikt Meurer
lgtm
3 years, 11 months ago (2017-01-26 11:26:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650853008/20001
3 years, 11 months ago (2017-01-26 11:31:56 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/73980ae4a19d9434e3c3eb927b7b005087157e32
3 years, 11 months ago (2017-01-26 12:08:41 UTC) #12
Michael Achenbach
3 years, 11 months ago (2017-01-26 12:45:09 UTC) #13
Message was sent while issue was closed.
PLease fix the vtune bot:
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20vtunejit/bui...

Powered by Google App Engine
This is Rietveld 408576698