[Mac] Security Chip Animation Edge Cases

[Mac] Security Chip Animation Edge Cases

Security chip will no longer animate out if the user edits  the
omnibox or switch tabs

BUG=643945
Review-Url: https://codereview.chromium.org/2650843002
Cr-Commit-Position: refs/heads/master@{#445749}
Committed: https://chromium.googlesource.com/chromium/src/+/6771b80c488c2c1b685ab2f674928ee09654ab15

[spqchan, 2017-01-23 20:57:01]

The CQ bit was checked by spqchan@chromium.org to run a CQ dry run

[spqchan, 2017-01-23 20:57:26]

Description was changed from

==========
[Mac] Security Chip Animation Edge Cases

Security chip will no longer animate out if the user starts editing the
omnibox or switch tabs

BUG=643945
==========

to

==========
[Mac] Security Chip Animation Edge Cases

Security chip will no longer animate out if the user edits  the
omnibox or switch tabs

BUG=643945
==========

[commit-bot: I haz the power, 2017-01-23 20:57:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[spqchan, 2017-01-23 21:42:44]

spqchan@chromium.org changed reviewers:
+ rsesek@chromium.org

[spqchan, 2017-01-23 21:42:45]

PTAL

[commit-bot: I haz the power, 2017-01-23 21:49:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 21:49:50]

Dry run: This issue passed the CQ dry run.

[Robert Sesek, 2017-01-24 16:52:54]

lgtm

https://codereview.chromium.org/2650843002/diff/1/chrome/browser/ui/cocoa/loc...
File chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm (right):

https://codereview.chromium.org/2650843002/diff/1/chrome/browser/ui/cocoa/loc...
chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm:877: //
TODO(spqchan): Add tests for the security state decoration.
Yes please :)

[spqchan, 2017-01-24 17:18:45]

On 2017/01/24 16:52:54, Robert Sesek wrote:
> lgtm
> 
>
https://codereview.chromium.org/2650843002/diff/1/chrome/browser/ui/cocoa/loc...
> File chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm (right):
> 
>
https://codereview.chromium.org/2650843002/diff/1/chrome/browser/ui/cocoa/loc...
> chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm:877: //
> TODO(spqchan): Add tests for the security state decoration.
> Yes please :)

thanks!

[spqchan, 2017-01-24 17:18:48]

The CQ bit was checked by spqchan@chromium.org

[commit-bot: I haz the power, 2017-01-24 17:19:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 17:22:57]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485278328916760, "parent_rev":
"7f2f9fa01e93d95339d0773ce5dd527cbc717532", "commit_rev":
"6771b80c488c2c1b685ab2f674928ee09654ab15"}

[commit-bot: I haz the power, 2017-01-24 17:23:35]

Description was changed from

==========
[Mac] Security Chip Animation Edge Cases

Security chip will no longer animate out if the user edits  the
omnibox or switch tabs

BUG=643945
==========

to

==========
[Mac] Security Chip Animation Edge Cases

Security chip will no longer animate out if the user edits  the
omnibox or switch tabs

BUG=643945

Review-Url: https://codereview.chromium.org/2650843002
Cr-Commit-Position: refs/heads/master@{#445749}
Committed:
https://chromium.googlesource.com/chromium/src/+/6771b80c488c2c1b685ab2f67492...
==========

[commit-bot: I haz the power, 2017-01-24 17:23:35]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6771b80c488c2c1b685ab2f67492...