Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 2650843002: [Mac] Security Chip Animation Edge Cases (Closed)

Created:
3 years, 11 months ago by spqchan
Modified:
3 years, 11 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Security Chip Animation Edge Cases Security chip will no longer animate out if the user edits the omnibox or switch tabs BUG=643945 Review-Url: https://codereview.chromium.org/2650843002 Cr-Commit-Position: refs/heads/master@{#445749} Committed: https://chromium.googlesource.com/chromium/src/+/6771b80c488c2c1b685ab2f674928ee09654ab15

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 2 chunks +7 lines, -2 lines 1 comment Download

Messages

Total messages: 14 (9 generated)
spqchan
PTAL
3 years, 11 months ago (2017-01-23 21:42:45 UTC) #5
Robert Sesek
lgtm https://codereview.chromium.org/2650843002/diff/1/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm File chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm (right): https://codereview.chromium.org/2650843002/diff/1/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm#newcode877 chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm:877: // TODO(spqchan): Add tests for the security state ...
3 years, 11 months ago (2017-01-24 16:52:54 UTC) #8
spqchan
On 2017/01/24 16:52:54, Robert Sesek wrote: > lgtm > > https://codereview.chromium.org/2650843002/diff/1/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm > File chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm (right): ...
3 years, 11 months ago (2017-01-24 17:18:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650843002/1
3 years, 11 months ago (2017-01-24 17:19:03 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 17:23:35 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6771b80c488c2c1b685ab2f67492...

Powered by Google App Engine
This is Rietveld 408576698