Restructure parser error handling and recovery.

Restructure parser error handling and recovery.

R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/7b5a1e2ba7e2c1ba966b9f3160e9f33eb4c55e0a

[ahe, 2017-01-23 18:52:16]

ahe@google.com changed reviewers:
+ johnniwinther@google.com, sigmund@google.com

[Johnni Winther, 2017-01-24 09:14:15]

lgtm

https://codereview.chromium.org/2650813002/diff/1/pkg/dart_parser/lib/src/lis...
File pkg/dart_parser/lib/src/listener.dart (right):

https://codereview.chromium.org/2650813002/diff/1/pkg/dart_parser/lib/src/lis...
pkg/dart_parser/lib/src/listener.dart:735: Token handleUnrecoverableError(Token
token, ErrorKind kind, Map arguments) {
If the implementation of handleUnrecoverableError normalize the state and
returns a valid token for further parsing, doesn't that effectively make the
error recoverable?

https://codereview.chromium.org/2650813002/diff/1/pkg/dart_parser/lib/src/lis...
pkg/dart_parser/lib/src/listener.dart:741: throw new
ParserError.fromTokens(token, token, kind, arguments));
Why add when you throw?

[ahe, 2017-01-24 09:36:48]

Thank you, Johnni.

PTAL

https://codereview.chromium.org/2650813002/diff/1/pkg/dart_parser/lib/src/lis...
File pkg/dart_parser/lib/src/listener.dart (right):

https://codereview.chromium.org/2650813002/diff/1/pkg/dart_parser/lib/src/lis...
pkg/dart_parser/lib/src/listener.dart:735: Token handleUnrecoverableError(Token
token, ErrorKind kind, Map arguments) {
On 2017/01/24 09:14:15, Johnni Winther wrote:
> If the implementation of handleUnrecoverableError normalize the state and
> returns a valid token for further parsing, doesn't that effectively make the
> error recoverable?

I've added document to address your question.

https://codereview.chromium.org/2650813002/diff/1/pkg/dart_parser/lib/src/lis...
pkg/dart_parser/lib/src/listener.dart:741: throw new
ParserError.fromTokens(token, token, kind, arguments));
On 2017/01/24 09:14:15, Johnni Winther wrote:
> Why add when you throw?

Copy and paste error.

[Johnni Winther, 2017-01-24 09:38:05]

lgtm

[ahe, 2017-01-24 09:48:26]

Description was changed from

==========
Restructure parser error handling and recovery.
==========

to

==========
Restructure parser error handling and recovery.

R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7b5a1e2ba7e2c1ba966b9f3160e9f33eb4c55e0a
==========

[ahe, 2017-01-24 09:48:27]

Committed patchset #3 (id:40001) manually as
7b5a1e2ba7e2c1ba966b9f3160e9f33eb4c55e0a (presubmit successful).