Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Side by Side Diff: pkg/compiler/lib/src/native/scanner.dart

Issue 2650813002: Restructure parser error handling and recovery. (Closed)
Patch Set: Address comments. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/parser/element_listener.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import '../common.dart'; 5 import '../common.dart';
6 import '../parser/element_listener.dart' show ElementListener; 6 import '../parser/element_listener.dart' show ElementListener;
7 import 'package:dart_scanner/dart_scanner.dart' show BeginGroupToken, Token; 7 import 'package:dart_scanner/dart_scanner.dart' show BeginGroupToken, Token;
8 import 'package:dart_scanner/src/token_constants.dart' as Tokens show 8 import 'package:dart_scanner/src/token_constants.dart' as Tokens show
9 STRING_TOKEN; 9 STRING_TOKEN;
10 10
11 void checkAllowedLibrary(ElementListener listener, Token token) { 11 void checkAllowedLibrary(ElementListener listener, Token token) {
12 if (listener.scannerOptions.canUseNative) return; 12 if (listener.scannerOptions.canUseNative) return;
13 listener.reportErrorMessageToken(token, MessageKind.NATIVE_NOT_SUPPORTED); 13 listener.reportErrorFromToken(token, MessageKind.NATIVE_NOT_SUPPORTED);
14 } 14 }
15 15
16 Token handleNativeBlockToSkip(ElementListener listener, Token token) { 16 Token handleNativeBlockToSkip(ElementListener listener, Token token) {
17 checkAllowedLibrary(listener, token); 17 checkAllowedLibrary(listener, token);
18 token = token.next; 18 token = token.next;
19 if (identical(token.kind, Tokens.STRING_TOKEN)) { 19 if (identical(token.kind, Tokens.STRING_TOKEN)) {
20 token = token.next; 20 token = token.next;
21 } 21 }
22 if (identical(token.stringValue, '{')) { 22 if (identical(token.stringValue, '{')) {
23 BeginGroupToken beginGroupToken = token; 23 BeginGroupToken beginGroupToken = token;
(...skipping 12 matching lines...) Expand all
36 hasExpression = true; 36 hasExpression = true;
37 listener.beginLiteralString(token); 37 listener.beginLiteralString(token);
38 listener.endLiteralString(0); 38 listener.endLiteralString(0);
39 token = token.next; 39 token = token.next;
40 } 40 }
41 listener.endReturnStatement(hasExpression, begin, token); 41 listener.endReturnStatement(hasExpression, begin, token);
42 // TODO(ngeoffray): expect a ';'. 42 // TODO(ngeoffray): expect a ';'.
43 // Currently there are method with both native marker and Dart body. 43 // Currently there are method with both native marker and Dart body.
44 return token.next; 44 return token.next;
45 } 45 }
OLDNEW
« no previous file with comments | « no previous file | pkg/compiler/lib/src/parser/element_listener.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698