Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 2650803005: Make Analysis Server tests use MockSdk again. (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -50 lines) Patch
M pkg/analysis_server/test/abstract_context.dart View 2 chunks +2 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/mock_sdk.dart View 3 chunks +21 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/optype_test.dart View 3 chunks +5 lines, -8 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/static_member_contributor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 3 chunks +4 lines, -8 lines 0 comments Download
M pkg/analysis_server/test/services/dependencies/reachable_source_collector_test.dart View 1 chunk +27 lines, -18 lines 0 comments Download
M pkg/analyzer/test/src/context/mock_sdk.dart View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 11 months ago (2017-01-24 21:39:38 UTC) #1
Brian Wilkerson
lgtm
3 years, 11 months ago (2017-01-24 21:47:56 UTC) #2
scheglov
3 years, 11 months ago (2017-01-24 21:49:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5f6ea67c1e6b7914e6a6186041ff3df517b9e94d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698