Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1762)

Unified Diff: pkg/analysis_server/test/services/dependencies/reachable_source_collector_test.dart

Issue 2650803005: Make Analysis Server tests use MockSdk again. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/dependencies/reachable_source_collector_test.dart
diff --git a/pkg/analysis_server/test/services/dependencies/reachable_source_collector_test.dart b/pkg/analysis_server/test/services/dependencies/reachable_source_collector_test.dart
index 0b2be14a5fd8be1da0512898e50214daa136b6df..a8542807ad63911f94dfc72e26bac0931b240391 100644
--- a/pkg/analysis_server/test/services/dependencies/reachable_source_collector_test.dart
+++ b/pkg/analysis_server/test/services/dependencies/reachable_source_collector_test.dart
@@ -44,28 +44,37 @@ import "dart:html";''');
Source lib3 = addSource('/lib3.dart', 'import "lib4.dart";');
addSource('/lib4.dart', 'import "lib3.dart";');
- {
- Map<String, List<String>> imports = importsFor(lib1);
- expect(imports.keys, contains('file:///lib1.dart'));
- expect(imports.keys, contains('file:///lib2.dart'));
- expect(imports.keys, contains('dart:core'));
- expect(imports.keys, contains('dart:html'));
- expect(imports.keys, contains('dart:math'));
- expect(imports.keys, isNot(contains('file:///lib3.dart')));
- expect(imports['file:///lib1.dart'],
- unorderedEquals(['dart:core', 'dart:html', 'file:///lib2.dart']));
- }
+ Map<String, List<String>> imports = importsFor(lib1);
+
+ // Verify keys.
+ expect(
+ imports.keys,
+ unorderedEquals([
+ 'dart:_internal',
+ 'dart:async',
+ 'dart:core',
+ 'dart:html',
+ 'dart:math',
+ 'file:///lib1.dart',
+ 'file:///lib2.dart',
+ ]));
+ // Values.
+ expect(imports['file:///lib1.dart'],
+ unorderedEquals(['dart:core', 'dart:html', 'file:///lib2.dart']));
// Check transitivity.
expect(importsFor(lib2).keys, contains('dart:html'));
// Cycles should be OK.
- {
- Map<String, List<String>> imports = importsFor(lib3);
- expect(imports.keys, contains('file:///lib3.dart'));
- expect(imports.keys, contains('file:///lib4.dart'));
- expect(imports.keys, contains('dart:core'));
- expect(imports.keys, contains('dart:math'));
- }
+ expect(
+ importsFor(lib3).keys,
+ unorderedEquals([
+ 'dart:_internal',
+ 'dart:async',
+ 'dart:core',
+ 'dart:math',
+ 'file:///lib3.dart',
+ 'file:///lib4.dart'
+ ]));
}
}
« no previous file with comments | « pkg/analysis_server/test/services/correction/fix_test.dart ('k') | pkg/analyzer/test/src/context/mock_sdk.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698