[inspector] change target promise for kDebugWillHandle & kDebugDidHandle

[inspector] change target promise for kDebugWillHandle & kDebugDidHandle

- kDebugPromiseCreated(task, parent_task)
This event occurs when promise is created (PromiseHookType::Init). V8Debugger uses this event to maintain task -> parent task map.

- kDebugEnqueueAsyncFunction(task)
This event occurs when first internal promise for async function is created. V8Debugger collects stack trace at this point.

- kDebugEnqueuePromiseResolve(task),
This event occurs when Promise fulfills with resolved status. V8Debugger collects stack trace at this point.

- kDebugEnqueuePromiseReject(task),
This event occurs when Promise fulfills with rejected status. V8Debugger collects stack trace at this point.

- kDebugPromiseCollected,
This event occurs when Promise is collected and no other chained callbacks can be added. V8Debugger removes information about async task for this promise.

- kDebugWillHandle,
This event occurs when chained promise function (either resolve or reject handler) is called. V8Debugger installs parent promise's stack (based on task -> parent_task map) as current if available or current promise's scheduled stack otherwise.

- kDebugDidHandle,
This event occurs after chained promise function has finished. V8Debugger restores asynchronous call chain to previous one.

With this change all instrumentation calls are related to current promise (before WillHandle and DidHandle were related to next async task).

Before V8Debugger supported only the following:
- asyncTaskScheduled(task1)
- asyncTaskStarted(task1)
- asyncTaskFinished(task1)

Now V8Debugger supports the following:
- asyncTaskScheduled(parent_task)
..
- asyncTaskCreated(task, parent_task),
- asyncTaskStarted(task), uses parent_task scheduled stack
- asyncTaskScheduled(task)
- asyncTaskFinished(task)

Additionally: WillHandle and DidHandle were migrated to PromiseHook API.

More details: https://docs.google.com/document/d/1u19N45f1gSF7M39mGsycJEK3IPyJgIXCBnWyiPeuJFE

BUG=v8:5738
R=dgozman@chromium.org,gsathya@chromium.org,yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2650803003
Cr-Commit-Position: refs/heads/master@{#42644}
Committed: https://chromium.googlesource.com/v8/v8/+/cb545a8c0ca79440d40515df86335a3c28c10965

[kozy, 2017-01-24 17:03:58]

Description was changed from

==========
[inspector] used RunPromiseHook API for promise events

WIP.

BUG=v8:5738
R=dgozman@chromium.org,gsathya@chromium.org
==========

to

==========
[inspector] change target promise for kDebugWillHandle & kDebugDidHandle

- kDebugPromiseCreated(task, parent_task)
This event is occurred when promise is created (PromiseHookType::Init).
V8Debugger uses this event to maintain task -> parent task map.

- kDebugEnqueueAsyncFunction(task)
This event is occurred when first internal promise for async function is
created. V8Debugger collects stack trace at this point.

- kDebugEnqueuePromiseResolve(task),
This event is occurred when Promise fulfilled with resolve status. V8Debugger
collects stack trace at this point.

- kDebugEnqueuePromiseReject(task),
This event is occurred when Promise fulfilled with resolve status. V8Debugger
collects stack trace at this point.

- kDebugPromiseCollected,
This event is occurred when Promise collected and no other chained callbacks can
be added. V8Debugger removes information about async task for this promise.

- kDebugWillHandle,
This event is occurred when chained callback will be called called with promise
which was returned by corresponding then call if available. V8Debugger installs
parent promise (base on task -> parent_task map) as current if available,
current promise scheduled stack otherwise.

- kDebugDidHandle,
This event is occurred after chained callback. V8Debugger restores previous
current asynchronous call chain.

With this change all instrumentations are related to current promise (before
WillHandle and DidHandle were related to next async task).

Before V8Debugger supports only following case:
- asyncTaskScheduled(task1)
- asyncTaskStarted(task1)
- asyncTaskFinished(task1)
With this CL it supports following case for promises only:
- asyncTaskScheduled(parent_task)
..
- asyncTaskCreated(task, parent_task),
- asyncTaskStarted(task), uses parent_task scheduled stack
- asyncTaskScheduled(task)
- asyncTaskFinished(task)

Additionally: WillHandle and DidHandle were migrated to PromiseHook API.

More details:
https://docs.google.com/document/d/1u19N45f1gSF7M39mGsycJEK3IPyJgIXCBnWyiPeuJFE

BUG=v8:5738
R=dgozman@chromium.org,gsathya@chromium.org,yangguo@chromium.org
==========

[kozy, 2017-01-24 17:03:58]

kozyatinskiy@chromium.org changed reviewers:
+ yangguo@google.com

[kozy, 2017-01-24 17:04:28]

kozyatinskiy@chromium.org changed reviewers:
+ yangguo@chromium.org
- yangguo@google.com

[kozy, 2017-01-24 17:04:37]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 17:04:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2017-01-24 17:06:25]

Dmitry, please take a look on inspector changes.
Sathya, please take a look one one more simplification of our promise
instrumentation :)
Yang, please take a look.

[commit-bot: I haz the power, 2017-01-24 17:08:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 17:08:52]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)

[dgozman, 2017-01-24 17:42:48]

Description was changed from

==========
[inspector] change target promise for kDebugWillHandle & kDebugDidHandle

- kDebugPromiseCreated(task, parent_task)
This event is occurred when promise is created (PromiseHookType::Init).
V8Debugger uses this event to maintain task -> parent task map.

- kDebugEnqueueAsyncFunction(task)
This event is occurred when first internal promise for async function is
created. V8Debugger collects stack trace at this point.

- kDebugEnqueuePromiseResolve(task),
This event is occurred when Promise fulfilled with resolve status. V8Debugger
collects stack trace at this point.

- kDebugEnqueuePromiseReject(task),
This event is occurred when Promise fulfilled with resolve status. V8Debugger
collects stack trace at this point.

- kDebugPromiseCollected,
This event is occurred when Promise collected and no other chained callbacks can
be added. V8Debugger removes information about async task for this promise.

- kDebugWillHandle,
This event is occurred when chained callback will be called called with promise
which was returned by corresponding then call if available. V8Debugger installs
parent promise (base on task -> parent_task map) as current if available,
current promise scheduled stack otherwise.

- kDebugDidHandle,
This event is occurred after chained callback. V8Debugger restores previous
current asynchronous call chain.

With this change all instrumentations are related to current promise (before
WillHandle and DidHandle were related to next async task).

Before V8Debugger supports only following case:
- asyncTaskScheduled(task1)
- asyncTaskStarted(task1)
- asyncTaskFinished(task1)
With this CL it supports following case for promises only:
- asyncTaskScheduled(parent_task)
..
- asyncTaskCreated(task, parent_task),
- asyncTaskStarted(task), uses parent_task scheduled stack
- asyncTaskScheduled(task)
- asyncTaskFinished(task)

Additionally: WillHandle and DidHandle were migrated to PromiseHook API.

More details:
https://docs.google.com/document/d/1u19N45f1gSF7M39mGsycJEK3IPyJgIXCBnWyiPeuJFE

BUG=v8:5738
R=dgozman@chromium.org,gsathya@chromium.org,yangguo@chromium.org
==========

to

==========
[inspector] change target promise for kDebugWillHandle & kDebugDidHandle

- kDebugPromiseCreated(task, parent_task)
This event is occurred when promise is created (PromiseHookType::Init).
V8Debugger uses this event to maintain task -> parent task map.

- kDebugEnqueueAsyncFunction(task)
This event is occurred when first internal promise for async function is
created. V8Debugger collects stack trace at this point.

- kDebugEnqueuePromiseResolve(task),
This event is occurred when Promise fulfilled with resolved status. V8Debugger
collects stack trace at this point.

- kDebugEnqueuePromiseReject(task),
This event is occurred when Promise fulfilled with rejected status. V8Debugger
collects stack trace at this point.

- kDebugPromiseCollected,
This event is occurred when Promise collected and no other chained callbacks can
be added. V8Debugger removes information about async task for this promise.

- kDebugWillHandle,
This event is occurred when chained callback will be called called with promise
which was returned by corresponding then call if available. V8Debugger installs
parent promise (base on task -> parent_task map) as current if available,
current promise scheduled stack otherwise.

- kDebugDidHandle,
This event is occurred after chained callback. V8Debugger restores previous
current asynchronous call chain.

With this change all instrumentations are related to current promise (before
WillHandle and DidHandle were related to next async task).

Before V8Debugger supports only following case:
- asyncTaskScheduled(task1)
- asyncTaskStarted(task1)
- asyncTaskFinished(task1)
With this CL it supports following case for promises only:
- asyncTaskScheduled(parent_task)
..
- asyncTaskCreated(task, parent_task),
- asyncTaskStarted(task), uses parent_task scheduled stack
- asyncTaskScheduled(task)
- asyncTaskFinished(task)

Additionally: WillHandle and DidHandle were migrated to PromiseHook API.

More details:
https://docs.google.com/document/d/1u19N45f1gSF7M39mGsycJEK3IPyJgIXCBnWyiPeuJFE

BUG=v8:5738
R=dgozman@chromium.org,gsathya@chromium.org,yangguo@chromium.org
==========

[dgozman, 2017-01-24 17:44:37]

Description was changed from

==========
[inspector] change target promise for kDebugWillHandle & kDebugDidHandle

- kDebugPromiseCreated(task, parent_task)
This event is occurred when promise is created (PromiseHookType::Init).
V8Debugger uses this event to maintain task -> parent task map.

- kDebugEnqueueAsyncFunction(task)
This event is occurred when first internal promise for async function is
created. V8Debugger collects stack trace at this point.

- kDebugEnqueuePromiseResolve(task),
This event is occurred when Promise fulfilled with resolved status. V8Debugger
collects stack trace at this point.

- kDebugEnqueuePromiseReject(task),
This event is occurred when Promise fulfilled with rejected status. V8Debugger
collects stack trace at this point.

- kDebugPromiseCollected,
This event is occurred when Promise collected and no other chained callbacks can
be added. V8Debugger removes information about async task for this promise.

- kDebugWillHandle,
This event is occurred when chained callback will be called called with promise
which was returned by corresponding then call if available. V8Debugger installs
parent promise (base on task -> parent_task map) as current if available,
current promise scheduled stack otherwise.

- kDebugDidHandle,
This event is occurred after chained callback. V8Debugger restores previous
current asynchronous call chain.

With this change all instrumentations are related to current promise (before
WillHandle and DidHandle were related to next async task).

Before V8Debugger supports only following case:
- asyncTaskScheduled(task1)
- asyncTaskStarted(task1)
- asyncTaskFinished(task1)
With this CL it supports following case for promises only:
- asyncTaskScheduled(parent_task)
..
- asyncTaskCreated(task, parent_task),
- asyncTaskStarted(task), uses parent_task scheduled stack
- asyncTaskScheduled(task)
- asyncTaskFinished(task)

Additionally: WillHandle and DidHandle were migrated to PromiseHook API.

More details:
https://docs.google.com/document/d/1u19N45f1gSF7M39mGsycJEK3IPyJgIXCBnWyiPeuJFE

BUG=v8:5738
R=dgozman@chromium.org,gsathya@chromium.org,yangguo@chromium.org
==========

to

==========
[inspector] change target promise for kDebugWillHandle & kDebugDidHandle

- kDebugPromiseCreated(task, parent_task)
This event occurs when promise is created (PromiseHookType::Init). V8Debugger
uses this event to maintain task -> parent task map.

- kDebugEnqueueAsyncFunction(task)
This event occurs when first internal promise for async function is created.
V8Debugger collects stack trace at this point.

- kDebugEnqueuePromiseResolve(task),
This event occurs when Promise fulfilled with resolved status. V8Debugger
collects stack trace at this point.

- kDebugEnqueuePromiseReject(task),
This event occurs when Promise fulfilled with rejected status. V8Debugger
collects stack trace at this point.

- kDebugPromiseCollected,
This event occurs when Promise collected and no other chained callbacks can be
added. V8Debugger removes information about async task for this promise.

- kDebugWillHandle,
This event occurs when chained callback will be called called with promise which
was returned by corresponding then call if available. V8Debugger installs parent
promise (base on task -> parent_task map) as current if available, current
promise scheduled stack otherwise.

- kDebugDidHandle,
This event occurs after chained callback. V8Debugger restores previous current
asynchronous call chain.

With this change all instrumentations are related to current promise (before
WillHandle and DidHandle were related to next async task).

Before V8Debugger supports only following case:
- asyncTaskScheduled(task1)
- asyncTaskStarted(task1)
- asyncTaskFinished(task1)
With this CL it supports following case for promises only:
- asyncTaskScheduled(parent_task)
..
- asyncTaskCreated(task, parent_task),
- asyncTaskStarted(task), uses parent_task scheduled stack
- asyncTaskScheduled(task)
- asyncTaskFinished(task)

Additionally: WillHandle and DidHandle were migrated to PromiseHook API.

More details:
https://docs.google.com/document/d/1u19N45f1gSF7M39mGsycJEK3IPyJgIXCBnWyiPeuJFE

BUG=v8:5738
R=dgozman@chromium.org,gsathya@chromium.org,yangguo@chromium.org
==========

[dgozman, 2017-01-24 17:51:09]

Description was changed from

==========
[inspector] change target promise for kDebugWillHandle & kDebugDidHandle

- kDebugPromiseCreated(task, parent_task)
This event occurs when promise is created (PromiseHookType::Init). V8Debugger
uses this event to maintain task -> parent task map.

- kDebugEnqueueAsyncFunction(task)
This event occurs when first internal promise for async function is created.
V8Debugger collects stack trace at this point.

- kDebugEnqueuePromiseResolve(task),
This event occurs when Promise fulfilled with resolved status. V8Debugger
collects stack trace at this point.

- kDebugEnqueuePromiseReject(task),
This event occurs when Promise fulfilled with rejected status. V8Debugger
collects stack trace at this point.

- kDebugPromiseCollected,
This event occurs when Promise collected and no other chained callbacks can be
added. V8Debugger removes information about async task for this promise.

- kDebugWillHandle,
This event occurs when chained callback will be called called with promise which
was returned by corresponding then call if available. V8Debugger installs parent
promise (base on task -> parent_task map) as current if available, current
promise scheduled stack otherwise.

- kDebugDidHandle,
This event occurs after chained callback. V8Debugger restores previous current
asynchronous call chain.

With this change all instrumentations are related to current promise (before
WillHandle and DidHandle were related to next async task).

Before V8Debugger supports only following case:
- asyncTaskScheduled(task1)
- asyncTaskStarted(task1)
- asyncTaskFinished(task1)
With this CL it supports following case for promises only:
- asyncTaskScheduled(parent_task)
..
- asyncTaskCreated(task, parent_task),
- asyncTaskStarted(task), uses parent_task scheduled stack
- asyncTaskScheduled(task)
- asyncTaskFinished(task)

Additionally: WillHandle and DidHandle were migrated to PromiseHook API.

More details:
https://docs.google.com/document/d/1u19N45f1gSF7M39mGsycJEK3IPyJgIXCBnWyiPeuJFE

BUG=v8:5738
R=dgozman@chromium.org,gsathya@chromium.org,yangguo@chromium.org
==========

to

==========
[inspector] change target promise for kDebugWillHandle & kDebugDidHandle

- kDebugPromiseCreated(task, parent_task)
This event occurs when promise is created (PromiseHookType::Init). V8Debugger
uses this event to maintain task -> parent task map.

- kDebugEnqueueAsyncFunction(task)
This event occurs when first internal promise for async function is created.
V8Debugger collects stack trace at this point.

- kDebugEnqueuePromiseResolve(task),
This event occurs when Promise fulfills with resolved status. V8Debugger
collects stack trace at this point.

- kDebugEnqueuePromiseReject(task),
This event occurs when Promise fulfills with rejected status. V8Debugger
collects stack trace at this point.

- kDebugPromiseCollected,
This event occurs when Promise is collected and no other chained callbacks can
be added. V8Debugger removes information about async task for this promise.

- kDebugWillHandle,
This event occurs when chained promise function (either resolve or reject
handler) is called. V8Debugger installs parent promise's stack (based on task ->
parent_task map) as current if available or current promise's scheduled stack
otherwise.

- kDebugDidHandle,
This event occurs after chained promise function has finished. V8Debugger
restores asynchronous call chain to previous one.

With this change all instrumentation calls are related to current promise
(before WillHandle and DidHandle were related to next async task).

Before V8Debugger supported only the following:
- asyncTaskScheduled(task1)
- asyncTaskStarted(task1)
- asyncTaskFinished(task1)

Now V8Debugger supports the following:
- asyncTaskScheduled(parent_task)
..
- asyncTaskCreated(task, parent_task),
- asyncTaskStarted(task), uses parent_task scheduled stack
- asyncTaskScheduled(task)
- asyncTaskFinished(task)

Additionally: WillHandle and DidHandle were migrated to PromiseHook API.

More details:
https://docs.google.com/document/d/1u19N45f1gSF7M39mGsycJEK3IPyJgIXCBnWyiPeuJFE

BUG=v8:5738
R=dgozman@chromium.org,gsathya@chromium.org,yangguo@chromium.org
==========

[dgozman, 2017-01-24 18:13:51]

Looks good, but let's figure out the tests.

https://codereview.chromium.org/2650803003/diff/60001/src/debug/debug.cc
File src/debug/debug.cc (right):

https://codereview.chromium.org/2650803003/diff/60001/src/debug/debug.cc#newc...
src/debug/debug.cc:1929: bool is_async = false;
Remove.

https://codereview.chromium.org/2650803003/diff/60001/src/debug/debug.cc#newc...
src/debug/debug.cc:1931: int parent_id = 0;
Let's move this under kInit case.

https://codereview.chromium.org/2650803003/diff/60001/src/inspector/v8-debugg...
File src/inspector/v8-debugger.cc (right):

https://codereview.chromium.org/2650803003/diff/60001/src/inspector/v8-debugg...
src/inspector/v8-debugger.cc:935: m_asyncTaskStacks.erase(task);
Call asyncTaskCanceled here.

https://codereview.chromium.org/2650803003/diff/60001/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/2650803003/diff/60001/src/isolate.cc#newcode3261
src/isolate.cc:3261: debug()->RunPromiseHook(type, promise, parent);
nit: one-line it.

https://codereview.chromium.org/2650803003/diff/60001/test/inspector/debugger...
File test/inspector/debugger/async-instrumentation-expected.txt (left):

https://codereview.chromium.org/2650803003/diff/60001/test/inspector/debugger...
test/inspector/debugger/async-instrumentation-expected.txt:11: --
Promise.resolve --
Please double check - looks suspicious.

[kozy, 2017-01-24 18:41:41]

all done, please take another look!

https://codereview.chromium.org/2650803003/diff/60001/src/debug/debug.cc
File src/debug/debug.cc (right):

https://codereview.chromium.org/2650803003/diff/60001/src/debug/debug.cc#newc...
src/debug/debug.cc:1929: bool is_async = false;
On 2017/01/24 18:13:51, dgozman wrote:
> Remove.

Done.

https://codereview.chromium.org/2650803003/diff/60001/src/debug/debug.cc#newc...
src/debug/debug.cc:1931: int parent_id = 0;
On 2017/01/24 18:13:51, dgozman wrote:
> Let's move this under kInit case.

Done.

https://codereview.chromium.org/2650803003/diff/60001/src/inspector/v8-debugg...
File src/inspector/v8-debugger.cc (right):

https://codereview.chromium.org/2650803003/diff/60001/src/inspector/v8-debugg...
src/inspector/v8-debugger.cc:935: m_asyncTaskStacks.erase(task);
On 2017/01/24 18:13:51, dgozman wrote:
> Call asyncTaskCanceled here.

Done.

https://codereview.chromium.org/2650803003/diff/60001/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/2650803003/diff/60001/src/isolate.cc#newcode3261
src/isolate.cc:3261: debug()->RunPromiseHook(type, promise, parent);
On 2017/01/24 18:13:51, dgozman wrote:
> nit: one-line it.

Done.

https://codereview.chromium.org/2650803003/diff/60001/test/inspector/debugger...
File test/inspector/debugger/async-instrumentation-expected.txt (left):

https://codereview.chromium.org/2650803003/diff/60001/test/inspector/debugger...
test/inspector/debugger/async-instrumentation-expected.txt:11: --
Promise.resolve --
On 2017/01/24 18:13:51, dgozman wrote:
> Please double check - looks suspicious.

debugger statement for break was located after asyncTaskCreated.

https://codereview.chromium.org/2650803003/diff/80001/src/runtime/runtime-pro...
File src/runtime/runtime-promise.cc (right):

https://codereview.chromium.org/2650803003/diff/80001/src/runtime/runtime-pro...
src/runtime/runtime-promise.cc:151: if (promise->IsJSPromise()) {
This check probably should be done inside of builtin-promise.cc toa void
redundant RUntime call for non native promises. Sathya, WDYT?

[kozy, 2017-01-24 18:41:53]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 18:41:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2017-01-24 18:53:01]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 18:53:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 19:24:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 19:24:17]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-01-24 20:06:54]

lgtm

[gsathya, 2017-01-24 20:18:07]

nice cleanup!

https://codereview.chromium.org/2650803003/diff/100001/src/runtime/runtime-pr...
File src/runtime/runtime-promise.cc (right):

https://codereview.chromium.org/2650803003/diff/100001/src/runtime/runtime-pr...
src/runtime/runtime-promise.cc:150: CONVERT_ARG_HANDLE_CHECKED(JSObject,
promise, 0);
Why do we have this change?

[kozy, 2017-01-24 20:40:23]

https://codereview.chromium.org/2650803003/diff/100001/src/runtime/runtime-pr...
File src/runtime/runtime-promise.cc (right):

https://codereview.chromium.org/2650803003/diff/100001/src/runtime/runtime-pr...
src/runtime/runtime-promise.cc:150: CONVERT_ARG_HANDLE_CHECKED(JSObject,
promise, 0);
On 2017/01/24 20:18:07, gsathya wrote:
> Why do we have this change?

In this CL we started to call promise hooks when debug_is_active, it gives us
huge code coverage for these methods and one of the our test
(test/debugger/debug/es6/debug-promises/throw-with-throw-in-reject.js) uses
custom promises. We probably would like to call this runtime call only for
native promises in the same way as we use for another hooks. I could try to
implement these checks inside of builtins-promise.

[kozy, 2017-01-24 20:42:36]

On 2017/01/24 20:18:07, gsathya wrote:
> nice cleanup!
> 
>
https://codereview.chromium.org/2650803003/diff/100001/src/runtime/runtime-pr...
> File src/runtime/runtime-promise.cc (right):
> 
>
https://codereview.chromium.org/2650803003/diff/100001/src/runtime/runtime-pr...
> src/runtime/runtime-promise.cc:150: CONVERT_ARG_HANDLE_CHECKED(JSObject,
> promise, 0);
> Why do we have this change?

Link to failed test:
https://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng_triggered/....

[gsathya, 2017-01-24 21:00:54]

On 2017/01/24 20:40:23, kozy wrote:
>
https://codereview.chromium.org/2650803003/diff/100001/src/runtime/runtime-pr...
> File src/runtime/runtime-promise.cc (right):
> 
>
https://codereview.chromium.org/2650803003/diff/100001/src/runtime/runtime-pr...
> src/runtime/runtime-promise.cc:150: CONVERT_ARG_HANDLE_CHECKED(JSObject,
> promise, 0);
> On 2017/01/24 20:18:07, gsathya wrote:
> > Why do we have this change?
> 
> In this CL we started to call promise hooks when debug_is_active, it gives us
> huge code coverage for these methods and one of the our test
> (test/debugger/debug/es6/debug-promises/throw-with-throw-in-reject.js) uses
> custom promises. We probably would like to call this runtime call only for
> native promises in the same way as we use for another hooks. I could try to
> implement these checks inside of builtins-promise.

yeah, this is fine. lgtm for promises

[kozy, 2017-01-25 00:20:34]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2017-01-25 00:20:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 00:24:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 00:24:17]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/33255)

[kozy, 2017-01-25 01:52:12]

Yang, please take a look on src/debug*

[Yang, 2017-01-25 06:56:02]

On 2017/01/25 01:52:12, kozy wrote:
> Yang, please take a look on src/debug*

lgtm.

[kozy, 2017-01-25 07:03:34]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2017-01-25 07:03:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 07:05:45]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1485327814036210,
"parent_rev": "9a8e269a23a534bd58304ed9cbdfa6930d7b36e8", "commit_rev":
"cb545a8c0ca79440d40515df86335a3c28c10965"}

[commit-bot: I haz the power, 2017-01-25 07:05:50]

Description was changed from

==========
[inspector] change target promise for kDebugWillHandle & kDebugDidHandle

- kDebugPromiseCreated(task, parent_task)
This event occurs when promise is created (PromiseHookType::Init). V8Debugger
uses this event to maintain task -> parent task map.

- kDebugEnqueueAsyncFunction(task)
This event occurs when first internal promise for async function is created.
V8Debugger collects stack trace at this point.

- kDebugEnqueuePromiseResolve(task),
This event occurs when Promise fulfills with resolved status. V8Debugger
collects stack trace at this point.

- kDebugEnqueuePromiseReject(task),
This event occurs when Promise fulfills with rejected status. V8Debugger
collects stack trace at this point.

- kDebugPromiseCollected,
This event occurs when Promise is collected and no other chained callbacks can
be added. V8Debugger removes information about async task for this promise.

- kDebugWillHandle,
This event occurs when chained promise function (either resolve or reject
handler) is called. V8Debugger installs parent promise's stack (based on task ->
parent_task map) as current if available or current promise's scheduled stack
otherwise.

- kDebugDidHandle,
This event occurs after chained promise function has finished. V8Debugger
restores asynchronous call chain to previous one.

With this change all instrumentation calls are related to current promise
(before WillHandle and DidHandle were related to next async task).

Before V8Debugger supported only the following:
- asyncTaskScheduled(task1)
- asyncTaskStarted(task1)
- asyncTaskFinished(task1)

Now V8Debugger supports the following:
- asyncTaskScheduled(parent_task)
..
- asyncTaskCreated(task, parent_task),
- asyncTaskStarted(task), uses parent_task scheduled stack
- asyncTaskScheduled(task)
- asyncTaskFinished(task)

Additionally: WillHandle and DidHandle were migrated to PromiseHook API.

More details:
https://docs.google.com/document/d/1u19N45f1gSF7M39mGsycJEK3IPyJgIXCBnWyiPeuJFE

BUG=v8:5738
R=dgozman@chromium.org,gsathya@chromium.org,yangguo@chromium.org
==========

to

==========
[inspector] change target promise for kDebugWillHandle & kDebugDidHandle

- kDebugPromiseCreated(task, parent_task)
This event occurs when promise is created (PromiseHookType::Init). V8Debugger
uses this event to maintain task -> parent task map.

- kDebugEnqueueAsyncFunction(task)
This event occurs when first internal promise for async function is created.
V8Debugger collects stack trace at this point.

- kDebugEnqueuePromiseResolve(task),
This event occurs when Promise fulfills with resolved status. V8Debugger
collects stack trace at this point.

- kDebugEnqueuePromiseReject(task),
This event occurs when Promise fulfills with rejected status. V8Debugger
collects stack trace at this point.

- kDebugPromiseCollected,
This event occurs when Promise is collected and no other chained callbacks can
be added. V8Debugger removes information about async task for this promise.

- kDebugWillHandle,
This event occurs when chained promise function (either resolve or reject
handler) is called. V8Debugger installs parent promise's stack (based on task ->
parent_task map) as current if available or current promise's scheduled stack
otherwise.

- kDebugDidHandle,
This event occurs after chained promise function has finished. V8Debugger
restores asynchronous call chain to previous one.

With this change all instrumentation calls are related to current promise
(before WillHandle and DidHandle were related to next async task).

Before V8Debugger supported only the following:
- asyncTaskScheduled(task1)
- asyncTaskStarted(task1)
- asyncTaskFinished(task1)

Now V8Debugger supports the following:
- asyncTaskScheduled(parent_task)
..
- asyncTaskCreated(task, parent_task),
- asyncTaskStarted(task), uses parent_task scheduled stack
- asyncTaskScheduled(task)
- asyncTaskFinished(task)

Additionally: WillHandle and DidHandle were migrated to PromiseHook API.

More details:
https://docs.google.com/document/d/1u19N45f1gSF7M39mGsycJEK3IPyJgIXCBnWyiPeuJFE

BUG=v8:5738
R=dgozman@chromium.org,gsathya@chromium.org,yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2650803003
Cr-Commit-Position: refs/heads/master@{#42644}
Committed:
https://chromium.googlesource.com/v8/v8/+/cb545a8c0ca79440d40515df86335a3c28c...
==========

[commit-bot: I haz the power, 2017-01-25 07:05:51]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/v8/v8/+/cb545a8c0ca79440d40515df86335a3c28c...