Remove Physical Web notifications

Remove Physical Web notifications

This change is a first pass in removing Physical Web notifications.
It's already the case that Physical Web notifications do not fire, but
this change removes the code path that would fire notifications.  There
is still more vestigial code that will be removed in later changes.

BUG=680747
Review-Url: https://codereview.chromium.org/2650793005
Cr-Commit-Position: refs/heads/master@{#445784}
Committed: https://chromium.googlesource.com/chromium/src/+/53466abaf91e1fe99c116cb275b4643be65ebcf5

[cco3, 2017-01-23 20:19:26]

cco3@chromium.org changed reviewers:
+ mattreynolds@chromium.org

[cco3, 2017-01-23 20:19:51]

Hi Matt, this is the first notification removal change.

[mattreynolds, 2017-01-23 21:33:15]

https://codereview.chromium.org/2650793005/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java
(left):

https://codereview.chromium.org/2650793005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java:200:
handleTime(STANDARD_NOTIFICATION_PRESS_DELAYS,
Can we mark these metrics as deprecated?

https://codereview.chromium.org/2650793005/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java
(right):

https://codereview.chromium.org/2650793005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java:51:
"PhysicalWeb.ReferralDelay.StandardNotification";
Remove?

https://codereview.chromium.org/2650793005/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java
(right):

https://codereview.chromium.org/2650793005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java:131:
* This method additionally updates the Physical Web notification.
Update comment (also removeUrl below)

https://codereview.chromium.org/2650793005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java:470:
return;
This block is useless now, please remove

[cco3, 2017-01-23 22:18:11]

https://codereview.chromium.org/2650793005/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java
(left):

https://codereview.chromium.org/2650793005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java:200:
handleTime(STANDARD_NOTIFICATION_PRESS_DELAYS,
On 2017/01/23 21:33:15, mattreynolds wrote:
> Can we mark these metrics as deprecated?

Hm, OK

https://codereview.chromium.org/2650793005/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java
(right):

https://codereview.chromium.org/2650793005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java:51:
"PhysicalWeb.ReferralDelay.StandardNotification";
On 2017/01/23 21:33:15, mattreynolds wrote:
> Remove?

Done.

https://codereview.chromium.org/2650793005/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java
(right):

https://codereview.chromium.org/2650793005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java:131:
* This method additionally updates the Physical Web notification.
On 2017/01/23 21:33:15, mattreynolds wrote:
> Update comment (also removeUrl below)

Done.

https://codereview.chromium.org/2650793005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java:470:
return;
On 2017/01/23 21:33:15, mattreynolds wrote:
> This block is useless now, please remove

Done.

[mattreynolds, 2017-01-23 22:24:36]

lgtm

[cco3, 2017-01-23 22:33:54]

cco3@chromium.org changed reviewers:
+ dtrainor@chromium.org

[cco3, 2017-01-23 22:33:54]

Hi David, would you be able to take a look at this change that removes unused
code paths?

[David Trainor- moved to gerrit, 2017-01-24 17:01:21]

lgtm

[cco3, 2017-01-24 17:27:01]

cco3@chromium.org changed reviewers:
+ rkaplow@chromium.org

[cco3, 2017-01-24 17:27:01]

Hi Robert, are you able to review these metrics changes? (We are marking a few
things as obsolete)

[rkaplow, 2017-01-24 17:29:21]

lgtm

[cco3, 2017-01-24 17:32:10]

The CQ bit was checked by cco3@chromium.org

[commit-bot: I haz the power, 2017-01-24 17:32:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cco3, 2017-01-24 17:33:20]

Thanks!  Even though you are an owner, it's not showing up green for me.  We'll
see how this commit works...

[commit-bot: I haz the power, 2017-01-24 17:56:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 17:56:25]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[cco3, 2017-01-24 18:26:13]

The CQ bit was checked by cco3@chromium.org

[cco3, 2017-01-24 18:26:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org, rkaplow@chromium.org, mattreynolds@chromium.org
Link to the patchset: https://codereview.chromium.org/2650793005/#ps40001
(title: "Remove notification UMA from optin activity")

[commit-bot: I haz the power, 2017-01-24 18:26:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 19:53:36]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485282373335040,
"parent_rev": "38fe35ec2f13cd49b5b024668897fff650482fee", "commit_rev":
"53466abaf91e1fe99c116cb275b4643be65ebcf5"}

[commit-bot: I haz the power, 2017-01-24 19:55:18]

Description was changed from

==========
Remove Physical Web notifications

This change is a first pass in removing Physical Web notifications.
It's already the case that Physical Web notifications do not fire, but
this change removes the code path that would fire notifications.  There
is still more vestigial code that will be removed in later changes.

BUG=680747
==========

to

==========
Remove Physical Web notifications

This change is a first pass in removing Physical Web notifications.
It's already the case that Physical Web notifications do not fire, but
this change removes the code path that would fire notifications.  There
is still more vestigial code that will be removed in later changes.

BUG=680747

Review-Url: https://codereview.chromium.org/2650793005
Cr-Commit-Position: refs/heads/master@{#445784}
Committed:
https://chromium.googlesource.com/chromium/src/+/53466abaf91e1fe99c116cb275b4...
==========

[commit-bot: I haz the power, 2017-01-24 19:55:19]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/53466abaf91e1fe99c116cb275b4...

[findit-for-me, 2017-01-24 20:38:18]

FYI: Findit identified this CL at revision 445784 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...