Fix Pepper socket API to open incoming ports in the firewall.

Fix Pepper socket API to open incoming ports in the firewall.

Previously the API would request ports to be opened passing IP address
as an interface name. Updated it to pass an empty string, so the port
gets open on all interfaces.

BUG=682339
Review-Url: https://codereview.chromium.org/2650793003
Cr-Commit-Position: refs/heads/master@{#445556}
Committed: https://chromium.googlesource.com/chromium/src/+/58b74d7b4bbc0f48f47e2fc4f408e79571a650c5

[Sergey Ulanov, 2017-01-23 19:20:57]

Patchset #1 (id:1) has been deleted

[Sergey Ulanov, 2017-01-23 19:21:19]

sergeyu@chromium.org changed reviewers:
+ avallee@chromium.org

[Sergey Ulanov, 2017-01-23 19:22:30]

Description was changed from

==========
Fix Pepper socket API to open incoming ports in the firewall.

Previously the API would request ports to be opened passing IP address
as an interface name. Updated it to pass an empty string, so the port
gets open on all interfaces.

BUG=682339
==========

to

==========
Fix Pepper socket API to open incoming ports in the firewall.

Previously the API would request ports to be opened passing IP address
as an interface name. Updated it to pass an empty string, so the port
gets open on all interfaces.

BUG=682339
==========

[Sergey Ulanov, 2017-01-23 19:22:30]

sergeyu@chromium.org changed reviewers:
+ raymes@chromium.org

[Sergey Ulanov, 2017-01-23 19:22:41]

+raymes@chromium.org for OWNERS approval

[avallee, 2017-01-23 19:28:23]

lgtm

https://codereview.chromium.org/2650793003/diff/20001/content/browser/rendere...
File content/browser/renderer_host/pepper/pepper_socket_utils.cc (right):

https://codereview.chromium.org/2650793003/diff/20001/content/browser/rendere...
content/browser/renderer_host/pepper/pepper_socket_utils.cc:174:
chromeos::FirewallHole::Open(type, address.port(), std::string(), callback);
Might be a bit of plumbing to have both interface or address strings all the way
to firewalld but that would be ideal. The other thing I had considered was
looking up which interface had that address, but that might not be available
here or even a 1-1 mapping.

[raymes, 2017-01-23 22:58:41]

rs lgtm

[Sergey Ulanov, 2017-01-23 23:02:20]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2017-01-23 23:04:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 00:22:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485212540144570,
"parent_rev": "3ce3ab4abf8f44e6c8849ffea5ff2c0baf00ff48", "commit_rev":
"58b74d7b4bbc0f48f47e2fc4f408e79571a650c5"}

[commit-bot: I haz the power, 2017-01-24 00:22:44]

Description was changed from

==========
Fix Pepper socket API to open incoming ports in the firewall.

Previously the API would request ports to be opened passing IP address
as an interface name. Updated it to pass an empty string, so the port
gets open on all interfaces.

BUG=682339
==========

to

==========
Fix Pepper socket API to open incoming ports in the firewall.

Previously the API would request ports to be opened passing IP address
as an interface name. Updated it to pass an empty string, so the port
gets open on all interfaces.

BUG=682339

Review-Url: https://codereview.chromium.org/2650793003
Cr-Commit-Position: refs/heads/master@{#445556}
Committed:
https://chromium.googlesource.com/chromium/src/+/58b74d7b4bbc0f48f47e2fc4f408...
==========

[commit-bot: I haz the power, 2017-01-24 00:22:45]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/58b74d7b4bbc0f48f47e2fc4f408...