Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2650773004: Add resolved proxy for the http stream job to net log (Closed)

Created:
3 years, 11 months ago by tbansal1
Modified:
3 years, 11 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, mmenke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add resolved proxy for the http stream job to net log This makes it easier to understand the net log when two racing jobs are created with different proxies (say https://, and quic://). CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester BUG=671291 Review-Url: https://codereview.chromium.org/2650773004 Cr-Commit-Position: refs/heads/master@{#445574} Committed: https://chromium.googlesource.com/chromium/src/+/f811aeb9e9174c1b3c097a20fbd201c99694547e

Patch Set 1 #

Total comments: 4

Patch Set 2 : rch comments, rebased #

Patch Set 3 : rch comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M net/http/http_stream_factory_impl_job.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M net/log/net_log_event_type_list.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
tbansal1
rch: ptal. thanks.
3 years, 11 months ago (2017-01-23 22:49:18 UTC) #4
Ryan Hamilton
lgtm, modulo the comment https://codereview.chromium.org/2650773004/diff/1/net/log/net_log_event_type_list.h File net/log/net_log_event_type_list.h (right): https://codereview.chromium.org/2650773004/diff/1/net/log/net_log_event_type_list.h#newcode1054 net/log/net_log_event_type_list.h:1054: // The event parameters are: ...
3 years, 11 months ago (2017-01-23 23:03:45 UTC) #5
tbansal1
https://codereview.chromium.org/2650773004/diff/1/net/log/net_log_event_type_list.h File net/log/net_log_event_type_list.h (right): https://codereview.chromium.org/2650773004/diff/1/net/log/net_log_event_type_list.h#newcode1054 net/log/net_log_event_type_list.h:1054: // The event parameters are: On 2017/01/23 23:03:45, Ryan ...
3 years, 11 months ago (2017-01-23 23:09:31 UTC) #6
Ryan Hamilton
https://codereview.chromium.org/2650773004/diff/1/net/log/net_log_event_type_list.h File net/log/net_log_event_type_list.h (right): https://codereview.chromium.org/2650773004/diff/1/net/log/net_log_event_type_list.h#newcode1054 net/log/net_log_event_type_list.h:1054: // The event parameters are: On 2017/01/23 23:09:31, tbansal1 ...
3 years, 11 months ago (2017-01-23 23:15:27 UTC) #9
tbansal1
https://codereview.chromium.org/2650773004/diff/1/net/log/net_log_event_type_list.h File net/log/net_log_event_type_list.h (right): https://codereview.chromium.org/2650773004/diff/1/net/log/net_log_event_type_list.h#newcode1054 net/log/net_log_event_type_list.h:1054: // The event parameters are: On 2017/01/23 23:15:27, Ryan ...
3 years, 11 months ago (2017-01-23 23:19:56 UTC) #10
Ryan Hamilton
lgtm
3 years, 11 months ago (2017-01-23 23:20:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650773004/40001
3 years, 11 months ago (2017-01-24 00:52:54 UTC) #17
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 01:12:37 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f811aeb9e9174c1b3c097a20fbd2...

Powered by Google App Engine
This is Rietveld 408576698