Add resolved proxy for the http stream job to net log

Add resolved proxy for the http stream job to net log

This makes it easier to understand the net log when two racing jobs are 
created with different proxies (say https://, and quic://).

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=671291
Review-Url: https://codereview.chromium.org/2650773004
Cr-Commit-Position: refs/heads/master@{#445574}
Committed: https://chromium.googlesource.com/chromium/src/+/f811aeb9e9174c1b3c097a20fbd201c99694547e

[tbansal1, 2017-01-23 22:47:46]

Description was changed from

==========
Add resolved proxy for the http stream job to net log

BUG=
==========

to

==========
Add resolved proxy for the http stream job to net log

This makes it easier to debug when two racing jobs are created with
different proxies (say https://, and quic://).

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=671291
==========

[tbansal1, 2017-01-23 22:48:03]

Description was changed from

==========
Add resolved proxy for the http stream job to net log

This makes it easier to debug when two racing jobs are created with
different proxies (say https://, and quic://).

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=671291
==========

to

==========
Add resolved proxy for the http stream job to net log

This makes it easier to understand the net log when two racing jobs are 
created with different proxies (say https://, and quic://).

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=671291
==========

[tbansal1, 2017-01-23 22:49:17]

tbansal@chromium.org changed reviewers:
+ rch@chromium.org

[tbansal1, 2017-01-23 22:49:18]

rch: ptal. thanks.

[Ryan Hamilton, 2017-01-23 23:03:45]

lgtm, modulo the comment

https://codereview.chromium.org/2650773004/diff/1/net/log/net_log_event_type_...
File net/log/net_log_event_type_list.h (right):

https://codereview.chromium.org/2650773004/diff/1/net/log/net_log_event_type_...
net/log/net_log_event_type_list.h:1054: // The event parameters are:
Is this comment accurate for the new event type?

[tbansal1, 2017-01-23 23:09:31]

https://codereview.chromium.org/2650773004/diff/1/net/log/net_log_event_type_...
File net/log/net_log_event_type_list.h (right):

https://codereview.chromium.org/2650773004/diff/1/net/log/net_log_event_type_...
net/log/net_log_event_type_list.h:1054: // The event parameters are:
On 2017/01/23 23:03:45, Ryan Hamilton wrote:
> Is this comment accurate for the new event type?
Good catch. Fixed.

[tbansal1, 2017-01-23 23:09:35]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 23:10:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Hamilton, 2017-01-23 23:15:27]

https://codereview.chromium.org/2650773004/diff/1/net/log/net_log_event_type_...
File net/log/net_log_event_type_list.h (right):

https://codereview.chromium.org/2650773004/diff/1/net/log/net_log_event_type_...
net/log/net_log_event_type_list.h:1054: // The event parameters are:
On 2017/01/23 23:09:31, tbansal1 wrote:
> On 2017/01/23 23:03:45, Ryan Hamilton wrote:
> > Is this comment accurate for the new event type?
> Good catch. Fixed.

I'm confused. Shouldn't the comment say something about proxy servers, not about
NetLogSource() ?

[tbansal1, 2017-01-23 23:19:56]

https://codereview.chromium.org/2650773004/diff/1/net/log/net_log_event_type_...
File net/log/net_log_event_type_list.h (right):

https://codereview.chromium.org/2650773004/diff/1/net/log/net_log_event_type_...
net/log/net_log_event_type_list.h:1054: // The event parameters are:
On 2017/01/23 23:15:27, Ryan Hamilton wrote:
> On 2017/01/23 23:09:31, tbansal1 wrote:
> > On 2017/01/23 23:03:45, Ryan Hamilton wrote:
> > > Is this comment accurate for the new event type?
> > Good catch. Fixed.
> 
> I'm confused. Shouldn't the comment say something about proxy servers, not
about
> NetLogSource() ?

Right. Done.

[tbansal1, 2017-01-23 23:20:01]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[Ryan Hamilton, 2017-01-23 23:20:20]

lgtm

[commit-bot: I haz the power, 2017-01-23 23:20:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 00:51:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 00:51:37]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2017-01-24 00:51:58]

The CQ bit was checked by tbansal@chromium.org

[commit-bot: I haz the power, 2017-01-24 00:52:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 01:10:53]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485219118393490,
"parent_rev": "f20419b3d9d27ba5b4f0cbbe15e41c6245ce8f95", "commit_rev":
"f811aeb9e9174c1b3c097a20fbd201c99694547e"}

[commit-bot: I haz the power, 2017-01-24 01:12:35]

Description was changed from

==========
Add resolved proxy for the http stream job to net log

This makes it easier to understand the net log when two racing jobs are 
created with different proxies (say https://, and quic://).

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=671291
==========

to

==========
Add resolved proxy for the http stream job to net log

This makes it easier to understand the net log when two racing jobs are 
created with different proxies (say https://, and quic://).

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=671291

Review-Url: https://codereview.chromium.org/2650773004
Cr-Commit-Position: refs/heads/master@{#445574}
Committed:
https://chromium.googlesource.com/chromium/src/+/f811aeb9e9174c1b3c097a20fbd2...
==========

[commit-bot: I haz the power, 2017-01-24 01:12:37]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f811aeb9e9174c1b3c097a20fbd2...