Use std::vector for fx_ucd.h arrays.

Use std::vector for fx_ucd.h arrays.

Review-Url: https://codereview.chromium.org/2650773003
Committed: https://pdfium.googlesource.com/pdfium/+/33316fccc6a523077d15dc7944a492099a99f6e1

[Tom Sepez, 2017-01-23 22:27:45]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 22:27:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2017-01-24 17:15:52]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2017-01-24 17:15:53]

Dan, for review.

[dsinclair, 2017-01-24 18:43:59]

https://codereview.chromium.org/2650773003/diff/40001/core/fxcrt/fx_arabic.cpp
File core/fxcrt/fx_arabic.cpp (right):

https://codereview.chromium.org/2650773003/diff/40001/core/fxcrt/fx_arabic.cp...
core/fxcrt/fx_arabic.cpp:476: chars[i].m_iBidiLevel = (int16_t)iBaseLevel;
nit: static_cast?

https://codereview.chromium.org/2650773003/diff/40001/xfa/fgas/layout/fgas_rt...
File xfa/fgas/layout/fgas_rtfbreak.cpp (right):

https://codereview.chromium.org/2650773003/diff/40001/xfa/fgas/layout/fgas_rt...
xfa/fgas/layout/fgas_rtfbreak.cpp:1088: FXSYS_memcpy(nextChars.data(),
curChars.data() + iCharPos,
std::copy?

https://codereview.chromium.org/2650773003/diff/40001/xfa/fgas/layout/fgas_rt...
File xfa/fgas/layout/fgas_rtfbreak.h (right):

https://codereview.chromium.org/2650773003/diff/40001/xfa/fgas/layout/fgas_rt...
xfa/fgas/layout/fgas_rtfbreak.h:122: *pText++ =
(FX_WCHAR)(*m_pChars)[i].m_wCharCode;
nit: static_cast?

https://codereview.chromium.org/2650773003/diff/40001/xfa/fgas/layout/fgas_rt...
xfa/fgas/layout/fgas_rtfbreak.h:165: std::vector<CFX_RTFChar>* m_pChars;
I gather this is set by .... something else and unowned?

https://codereview.chromium.org/2650773003/diff/40001/xfa/fgas/layout/fgas_te...
File xfa/fgas/layout/fgas_textbreak.cpp (right):

https://codereview.chromium.org/2650773003/diff/40001/xfa/fgas/layout/fgas_te...
xfa/fgas/layout/fgas_textbreak.cpp:1130: FXSYS_memcpy(nextChars.data(),
curChars.data() + iCharPos,
std::copy

https://codereview.chromium.org/2650773003/diff/40001/xfa/fgas/layout/fgas_te...
File xfa/fgas/layout/fgas_textbreak.h (right):

https://codereview.chromium.org/2650773003/diff/40001/xfa/fgas/layout/fgas_te...
xfa/fgas/layout/fgas_textbreak.h:128: *pText++ = (FX_WCHAR)pChar->m_wCharCode;
This seems overly complicated why not something like:

*pText++ = static_cast<FX_WCHAR>((*m_pChars)[i].m_wCharCode);

(and on 140, 183 as well)

[Tom Sepez, 2017-01-24 19:16:12]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[Tom Sepez, 2017-01-24 19:16:12]

https://codereview.chromium.org/2650773003/diff/40001/core/fxcrt/fx_arabic.cpp
File core/fxcrt/fx_arabic.cpp (right):

https://codereview.chromium.org/2650773003/diff/40001/core/fxcrt/fx_arabic.cp...
core/fxcrt/fx_arabic.cpp:476: chars[i].m_iBidiLevel = (int16_t)iBaseLevel;
On 2017/01/24 18:43:58, dsinclair wrote:
> nit: static_cast?

Done.

https://codereview.chromium.org/2650773003/diff/40001/xfa/fgas/layout/fgas_rt...
File xfa/fgas/layout/fgas_rtfbreak.h (right):

https://codereview.chromium.org/2650773003/diff/40001/xfa/fgas/layout/fgas_rt...
xfa/fgas/layout/fgas_rtfbreak.h:122: *pText++ =
(FX_WCHAR)(*m_pChars)[i].m_wCharCode;
On 2017/01/24 18:43:58, dsinclair wrote:
> nit: static_cast?

Done.

https://codereview.chromium.org/2650773003/diff/40001/xfa/fgas/layout/fgas_rt...
xfa/fgas/layout/fgas_rtfbreak.h:165: std::vector<CFX_RTFChar>* m_pChars;
On 2017/01/24 18:43:58, dsinclair wrote:
> I gather this is set by .... something else and unowned?

Yup, its a pointer to someone else's vector.  Added comment.

https://codereview.chromium.org/2650773003/diff/40001/xfa/fgas/layout/fgas_te...
File xfa/fgas/layout/fgas_textbreak.cpp (right):

https://codereview.chromium.org/2650773003/diff/40001/xfa/fgas/layout/fgas_te...
xfa/fgas/layout/fgas_textbreak.cpp:1130: FXSYS_memcpy(nextChars.data(),
curChars.data() + iCharPos,
On 2017/01/24 18:43:59, dsinclair wrote:
> std::copy

Even better is new vector ctor from iterators and move assign, then clean up the
indexing so its obvious ...

https://codereview.chromium.org/2650773003/diff/40001/xfa/fgas/layout/fgas_te...
File xfa/fgas/layout/fgas_textbreak.h (right):

https://codereview.chromium.org/2650773003/diff/40001/xfa/fgas/layout/fgas_te...
xfa/fgas/layout/fgas_textbreak.h:128: *pText++ = (FX_WCHAR)pChar->m_wCharCode;
On 2017/01/24 18:43:59, dsinclair wrote:
> This seems overly complicated why not something like:
> 
> *pText++ = static_cast<FX_WCHAR>((*m_pChars)[i].m_wCharCode);
> 
> (and on 140, 183 as well)

Done.

[Tom Sepez, 2017-01-24 19:22:27]

https://codereview.chromium.org/2650773003/diff/40001/xfa/fgas/layout/fgas_rt...
File xfa/fgas/layout/fgas_rtfbreak.cpp (right):

https://codereview.chromium.org/2650773003/diff/40001/xfa/fgas/layout/fgas_rt...
xfa/fgas/layout/fgas_rtfbreak.cpp:1088: FXSYS_memcpy(nextChars.data(),
curChars.data() + iCharPos,
On 2017/01/24 18:43:58, dsinclair wrote:
> std::copy?

Missed this first time around, now done.

[dsinclair, 2017-01-24 19:58:48]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2017-01-24 19:58:49]

lgtm

[commit-bot: I haz the power, 2017-01-24 19:58:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 20:17:41]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1485287928669880,
"parent_rev": "6e162b54f708d7957c04d8dffce367fbeaa1a366", "commit_rev":
"33316fccc6a523077d15dc7944a492099a99f6e1"}

[commit-bot: I haz the power, 2017-01-24 20:17:44]

Description was changed from

==========
Use std::vector for fx_ucd.h arrays.
==========

to

==========
Use std::vector for fx_ucd.h arrays.

Review-Url: https://codereview.chromium.org/2650773003
Committed:
https://pdfium.googlesource.com/pdfium/+/33316fccc6a523077d15dc7944a492099a99...
==========

[commit-bot: I haz the power, 2017-01-24 20:17:46]

Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/33316fccc6a523077d15dc7944a492099a99...