Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2650763004: Reduce the "immediate" timeout to 4 min 50 sec to match prerenderer. (Closed)

Created:
3 years, 11 months ago by Pete Williamson
Modified:
3 years, 11 months ago
Reviewers:
dougarnett, romax
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce the "immediate" timeout to 4 min 50 sec to match prerenderer. The prerenderer has a built in 5 minute timeout, and will not go past 5 minutes anyway, so set our timeout for an immediate fetch to 4 min 50 sec so that we don't exceed the prerenderer timeout. BUG=682761 Review-Url: https://codereview.chromium.org/2650763004 Cr-Commit-Position: refs/heads/master@{#445862} Committed: https://chromium.googlesource.com/chromium/src/+/7b45a25edbef4bb26bf1d82c71aa1bca36b89a47

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M components/offline_pages/core/background/offliner_policy.h View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Pete Williamson
3 years, 11 months ago (2017-01-24 17:51:28 UTC) #2
dougarnett
lgtm
3 years, 11 months ago (2017-01-24 18:16:05 UTC) #3
romax
lgtm
3 years, 11 months ago (2017-01-24 19:32:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650763004/1
3 years, 11 months ago (2017-01-24 22:30:23 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 23:44:34 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7b45a25edbef4bb26bf1d82c71aa...

Powered by Google App Engine
This is Rietveld 408576698