Implement renderer importance API for WebView

Implement renderer importance API for WebView

The renderer importance API allows a WebView to declare which priority
from the set {HIGH, LOW, WAIVED} its associated renderer process
should be bound with. HIGH corresponds to binding with
Context.BIND_IMPORTANT, LOW corresponds to keeping a normal binding
to the service. WAIVED corresponds to binding with BIND_WAIVE_PRIORITY.

Additionally, the priority can be automatically lowered to WAIVE when
the WebView instance is not visible.

When multiple WebViews are assocated with the same renderer, the
renderer will receive a priority equal to the maximum over the set
of associated WebViews.

The default is HIGH, without visibility management, for backwards
compatibility with single-process.

BUG=667531
Review-Url: https://codereview.chromium.org/2650753002
Cr-Commit-Position: refs/heads/master@{#446636}
Committed: https://chromium.googlesource.com/chromium/src/+/401a3c143672daee741c309a213aa690673cf1bd

[Tobias Sargeant, 2017-01-23 15:47:30]

tobiasjs@chromium.org changed reviewers:
+ jochen@chromium.org, sgurun@chromium.org, torne@chromium.org

[jochen (gone - plz use gerrit), 2017-01-23 15:55:46]

please add tests

[Torne, 2017-01-24 12:46:35]

This generally LGTM, but it would be good if we can come up with a good way to
test this..

[Tobias Sargeant, 2017-01-24 15:04:37]

On 2017/01/24 12:46:35, Torne wrote:
> This generally LGTM, but it would be good if we can come up with a good way to
> test this..

I added three tests (and found one bug in the process).

I didn't cover as many cases as I'd like to, but it's difficult to test the case
where two webviews interact for two reasons:

1) It's hard to assert that no BindingManager call occurs (without something
ugly like a timeout).
2) We can't be assured that the two WebViews we create will forever refer to the
same renderer.

[jochen (gone - plz use gerrit), 2017-01-24 17:25:15]

lgtm

[Tobias Sargeant, 2017-01-24 17:28:11]

Description was changed from

==========
Implement renderer importance API for WebView

The renderer importance API allows a WebView to declare which priority
from the set {IMPORTANT, BOUND, WAIVED} its associated renderer process
should be bound with. IMPORTANT corresponds to binding with
Context.BIND_IMPORTANT, BOUND corresponds to keeping a normal binding
to the service. WAIVED corresponds to binding with BIND_WAIVE_PRIORITY.

Additionally, the priority can be automatically lowered to WAIVE when
the WebView instance is not visible.

When multiple WebViews are assocated with the same renderer, the
renderer will receive a priority equal to the maximum over the set
of associated WebViews.

The default is IMPORTANT, without visibility management, for backwards
compatibility with single-process.

BUG=667531
==========

to

==========
Implement renderer importance API for WebView

The renderer importance API allows a WebView to declare which priority
from the set {HIGH, LOW, WAIVED} its associated renderer process
should be bound with. HIGH corresponds to binding with
Context.BIND_IMPORTANT, LOW corresponds to keeping a normal binding
to the service. WAIVED corresponds to binding with BIND_WAIVE_PRIORITY.

Additionally, the priority can be automatically lowered to WAIVE when
the WebView instance is not visible.

When multiple WebViews are assocated with the same renderer, the
renderer will receive a priority equal to the maximum over the set
of associated WebViews.

The default is HIGH, without visibility management, for backwards
compatibility with single-process.

BUG=667531
==========

[Tobias Sargeant, 2017-01-24 17:47:18]

The CQ bit was checked by tobiasjs@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 17:47:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 19:19:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 19:19:21]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Tobias Sargeant, 2017-01-26 10:55:19]

The CQ bit was checked by tobiasjs@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 10:55:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Torne, 2017-01-26 12:15:30]

still LGTM :)

[commit-bot: I haz the power, 2017-01-26 12:20:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 12:20:10]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Tobias Sargeant, 2017-01-26 21:28:06]

The CQ bit was checked by tobiasjs@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 21:28:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 21:58:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 21:58:31]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Tobias Sargeant, 2017-01-26 22:07:39]

Patchset #4 (id:60001) has been deleted

[Tobias Sargeant, 2017-01-26 22:07:46]

The CQ bit was checked by tobiasjs@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 22:08:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 23:53:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 23:54:00]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Tobias Sargeant, 2017-01-27 09:04:07]

The CQ bit was checked by tobiasjs@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 09:04:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 10:24:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 10:24:37]

Dry run: This issue passed the CQ dry run.

[Tobias Sargeant, 2017-01-27 10:31:22]

The CQ bit was checked by tobiasjs@chromium.org

[Tobias Sargeant, 2017-01-27 10:31:22]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
torne@chromium.org
Link to the patchset: https://codereview.chromium.org/2650753002/#ps100001
(title: "clean up unused local")

[commit-bot: I haz the power, 2017-01-27 10:31:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 10:35:36]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1485513082527920,
"parent_rev": "9ead0def6f12d7152260f2eb21e78c7e09cd47ee", "commit_rev":
"401a3c143672daee741c309a213aa690673cf1bd"}

[commit-bot: I haz the power, 2017-01-27 10:36:08]

Description was changed from

==========
Implement renderer importance API for WebView

The renderer importance API allows a WebView to declare which priority
from the set {HIGH, LOW, WAIVED} its associated renderer process
should be bound with. HIGH corresponds to binding with
Context.BIND_IMPORTANT, LOW corresponds to keeping a normal binding
to the service. WAIVED corresponds to binding with BIND_WAIVE_PRIORITY.

Additionally, the priority can be automatically lowered to WAIVE when
the WebView instance is not visible.

When multiple WebViews are assocated with the same renderer, the
renderer will receive a priority equal to the maximum over the set
of associated WebViews.

The default is HIGH, without visibility management, for backwards
compatibility with single-process.

BUG=667531
==========

to

==========
Implement renderer importance API for WebView

The renderer importance API allows a WebView to declare which priority
from the set {HIGH, LOW, WAIVED} its associated renderer process
should be bound with. HIGH corresponds to binding with
Context.BIND_IMPORTANT, LOW corresponds to keeping a normal binding
to the service. WAIVED corresponds to binding with BIND_WAIVE_PRIORITY.

Additionally, the priority can be automatically lowered to WAIVE when
the WebView instance is not visible.

When multiple WebViews are assocated with the same renderer, the
renderer will receive a priority equal to the maximum over the set
of associated WebViews.

The default is HIGH, without visibility management, for backwards
compatibility with single-process.

BUG=667531

Review-Url: https://codereview.chromium.org/2650753002
Cr-Commit-Position: refs/heads/master@{#446636}
Committed:
https://chromium.googlesource.com/chromium/src/+/401a3c143672daee741c309a213a...
==========

[commit-bot: I haz the power, 2017-01-27 10:36:11]

Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/401a3c143672daee741c309a213a...