[Win, Mac] UI fixes for the delete account button in the new avatar bubble.

[Win, Mac] UI fixes for the delete account button in the new avatar bubble.

BUG=351959
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268314

[noms (inactive), 2014-05-02 20:36:30]

Hi,

This CL adds a "delete" icon to the account buttons in the new avatar bubble.
The good news is that pending another UI redesign, I only see a max of 3 CLs on
this topic coming your way. :) 

The linked crbug has screenshots, if needed. Please take a look!

[sky, 2014-05-02 21:57:48]

LGTM

[groby-ooo-7-16, 2014-05-02 22:21:57]

LGTM % comments

https://codereview.chromium.org/265073003/diff/40001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm (right):

https://codereview.chromium.org/265073003/diff/40001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm:1536: const
CGFloat kDeleteButtonWidth = 18;
Why 18? Any chance we can get that number from the deleteButton directly?

https://codereview.chromium.org/265073003/diff/40001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm:1560: [button
addSubview:deleteButton];
A HoverButton in a HoverButton? We must go deeper!

(Also, how does hover deal with that? It _should_ keep the main button hovered,
and I think it does - I suppose you tested that?)

[noms (inactive), 2014-05-05 17:21:24]

https://codereview.chromium.org/265073003/diff/40001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm (right):

https://codereview.chromium.org/265073003/diff/40001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm:1536: const
CGFloat kDeleteButtonWidth = 18;
On 2014/05/02 22:21:57, groby wrote:
> Why 18? Any chance we can get that number from the deleteButton directly?

Done.

https://codereview.chromium.org/265073003/diff/40001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm:1560: [button
addSubview:deleteButton];
Blerg.  :(
Yup, the hovering is fine by magic. The big button stays hovered when the little
button is hovered, and everyone is a winner!

On 2014/05/02 22:21:57, groby wrote:
> A HoverButton in a HoverButton? We must go deeper!
> 
> (Also, how does hover deal with that? It _should_ keep the main button
hovered,
> and I think it does - I suppose you tested that?)

[noms (inactive), 2014-05-05 17:22:53]

The CQ bit was checked by noms@chromium.org

[commit-bot: I haz the power, 2014-05-05 17:23:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/noms@chromium.org/265073003/80001

[commit-bot: I haz the power, 2014-05-05 18:42:53]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  mac_chromium_rel on tryserver.chromium
  win_chromium_rel on tryserver.chromium
  win_chromium_x64_rel on tryserver.chromium

[commit-bot: I haz the power, 2014-05-05 23:32:43]

Change committed as 268314