chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm - Issue 265073003: [Win, Mac] UI fixes for the delete account button in the new avatar bubble.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm

Issue 265073003: [Win, Mac] UI fixes for the delete account button in the new avatar bubble. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix image width on win Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm ('k') | chrome/browser/ui/views/profiles/profile_chooser_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm

index bafb0d2aa04bda2d53d5ef11a99749761667aa08..e116a50dc6c5c3a65adb057a731ebecf485701f7 100644

--- a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm

@@ -400,16 +400,20 @@ TEST_F(ProfileChooserControllerTest, AccountManagementLayout) {

NSButton* genericAccount =

static_cast<NSButton*>([accountsListSubviews objectAtIndex:0]);

- EXPECT_EQ(@selector(showAccountRemovalView:), [genericAccount action]);

- EXPECT_EQ(controller(), [genericAccount target]);

- EXPECT_NE(-1, [genericAccount tag]);

+ NSButton* genericAccountDelete =

+ static_cast<NSButton*>([[genericAccount subviews] objectAtIndex:0]);

+ EXPECT_EQ(@selector(showAccountRemovalView:), [genericAccountDelete action]);

+ EXPECT_EQ(controller(), [genericAccountDelete target]);

+ EXPECT_NE(-1, [genericAccountDelete tag]);

// Primary accounts are always last.

NSButton* primaryAccount =

static_cast<NSButton*>([accountsListSubviews objectAtIndex:1]);

- EXPECT_EQ(@selector(showAccountRemovalView:), [primaryAccount action]);

- EXPECT_EQ(controller(), [primaryAccount target]);

- EXPECT_EQ(-1, [primaryAccount tag]);

+ NSButton* primaryAccountDelete =

+ static_cast<NSButton*>([[primaryAccount subviews] objectAtIndex:0]);

+ EXPECT_EQ(@selector(showAccountRemovalView:), [primaryAccountDelete action]);

+ EXPECT_EQ(controller(), [primaryAccountDelete target]);

+ EXPECT_EQ(-1, [primaryAccountDelete tag]);

// There should be another separator.

EXPECT_TRUE([[subviews objectAtIndex:3] isKindOfClass:[NSBox class]]);