Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 265073002: remove self-tests for no-longer-supported rebaseline.py (Closed)

Created:
6 years, 7 months ago by epoger
Modified:
6 years, 7 months ago
Reviewers:
borenet
CC:
skia-review_googlegroups.com, djsollen
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

remove self-tests for no-longer-supported rebaseline.py see https://codereview.chromium.org/262703003 ('mark rebaseline.py as deprecated') NOTREECHECKS=True NOTRY=True TBR=borenet Committed: http://code.google.com/p/skia/source/detail?r=14538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-3 lines, -836 lines) Patch
D tools/tests/rebaseline/input/json1/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/actual-results.json View 1 chunk +0 lines, -70 lines 0 comments Download
D tools/tests/rebaseline/input/json1/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json View 1 chunk +0 lines, -54 lines 0 comments Download
D tools/tests/rebaseline/input/json1/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release/actual-results.json View 1 chunk +0 lines, -31 lines 0 comments Download
D tools/tests/rebaseline/input/json1/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 1 chunk +0 lines, -1 line 0 comments Download
D tools/tests/rebaseline/input/json1/Test-Win7-ShuttleA-HD2000-x86-Release/actual-results.json View 1 chunk +0 lines, -69 lines 0 comments Download
D tools/tests/rebaseline/input/json1/Test-Win7-ShuttleA-HD2000-x86-Release/expected-results.json View 1 chunk +0 lines, -52 lines 0 comments Download
D tools/tests/rebaseline/output/.gitignore View 1 chunk +0 lines, -1 line 0 comments Download
D tools/tests/rebaseline/output/add-new/output-expected/command_line View 1 chunk +0 lines, -1 line 0 comments Download
D tools/tests/rebaseline/output/add-new/output-expected/gm-expectations/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json View 1 chunk +0 lines, -87 lines 0 comments Download
D tools/tests/rebaseline/output/add-new/output-expected/gm-expectations/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 1 chunk +0 lines, -36 lines 0 comments Download
D tools/tests/rebaseline/output/add-new/output-expected/gm-expectations/Test-Win7-ShuttleA-HD2000-x86-Release/expected-results.json View 1 chunk +0 lines, -85 lines 0 comments Download
D tools/tests/rebaseline/output/add-new/output-expected/return_value View 1 chunk +0 lines, -1 line 0 comments Download
D tools/tests/rebaseline/output/add-new/output-expected/stdout View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/tests/rebaseline/output/marked-unreviewed/output-expected/command_line View 1 chunk +0 lines, -1 line 0 comments Download
D tools/tests/rebaseline/output/marked-unreviewed/output-expected/gm-expectations/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json View 1 chunk +0 lines, -90 lines 0 comments Download
D tools/tests/rebaseline/output/marked-unreviewed/output-expected/gm-expectations/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 1 chunk +0 lines, -1 line 0 comments Download
D tools/tests/rebaseline/output/marked-unreviewed/output-expected/gm-expectations/Test-Win7-ShuttleA-HD2000-x86-Release/expected-results.json View 1 chunk +0 lines, -70 lines 0 comments Download
D tools/tests/rebaseline/output/marked-unreviewed/output-expected/return_value View 1 chunk +0 lines, -1 line 0 comments Download
D tools/tests/rebaseline/output/marked-unreviewed/output-expected/stdout View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/tests/rebaseline/output/using-json1-expectations/output-expected/command_line View 1 chunk +0 lines, -1 line 0 comments Download
D tools/tests/rebaseline/output/using-json1-expectations/output-expected/gm-expectations/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json View 1 chunk +0 lines, -72 lines 0 comments Download
D tools/tests/rebaseline/output/using-json1-expectations/output-expected/gm-expectations/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 1 chunk +0 lines, -1 line 0 comments Download
D tools/tests/rebaseline/output/using-json1-expectations/output-expected/gm-expectations/Test-Win7-ShuttleA-HD2000-x86-Release/expected-results.json View 1 chunk +0 lines, -70 lines 0 comments Download
D tools/tests/rebaseline/output/using-json1-expectations/output-expected/return_value View 1 chunk +0 lines, -1 line 0 comments Download
D tools/tests/rebaseline/output/using-json1-expectations/output-expected/stdout View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/tests/run.sh View 2 chunks +0 lines, -43 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
epoger
Committing TBR to unbreak runtoolselftests on http://108.170.220.102:10117/builders/Housekeeper-PerCommit
6 years, 7 months ago (2014-05-02 16:47:56 UTC) #1
epoger
The CQ bit was checked by epoger@google.com
6 years, 7 months ago (2014-05-02 16:48:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/265073002/1
6 years, 7 months ago (2014-05-02 16:48:11 UTC) #3
commit-bot: I haz the power
Change committed as 14538
6 years, 7 months ago (2014-05-02 16:48:53 UTC) #4
borenet
6 years, 7 months ago (2014-05-02 16:49:49 UTC) #5
Message was sent while issue was closed. 
On 2014/05/02 16:48:53, I haz the power (commit-bot) wrote:
> Change committed as 14538

LGTM

Powered by Google App Engine
This is Rietveld 408576698