Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2650693005: MD Settings: Make Enter key submit changes in the Internet section (Closed)

Created:
3 years, 11 months ago by tommycli
Modified:
3 years, 11 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Make Enter key submit changes in the Internet section 1. In the input field to add a new proxy exception, the Enter key now adds the entered proxy exception. 2. In the PIN dialog boxes for the Cellular networks, the Enter key now submits the PIN. BUG=622816 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2650693005 Cr-Commit-Position: refs/heads/master@{#445577} Committed: https://chromium.googlesource.com/chromium/src/+/8e4c91b58fd813b88518f6826ae79adde7a4c240

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M chrome/browser/resources/settings/internet_page/network_proxy.html View 3 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/network_siminfo.html View 1 5 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
tommycli
stevenjb: PTAL, thanks!
3 years, 11 months ago (2017-01-23 23:26:25 UTC) #5
stevenjb
nice, thanks! lgtm
3 years, 11 months ago (2017-01-24 00:06:36 UTC) #7
tommycli
On 2017/01/24 00:06:36, stevenjb wrote: > nice, thanks! lgtm no problem, thanks!
3 years, 11 months ago (2017-01-24 00:07:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650693005/20001
3 years, 11 months ago (2017-01-24 00:07:50 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 01:21:57 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8e4c91b58fd813b88518f6826ae7...

Powered by Google App Engine
This is Rietveld 408576698