Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2650673002: WebURLLoaderImplTest should not depend on LoadingIPCType (Closed)

Created:
3 years, 11 months ago by yhirano
Modified:
3 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebURLLoaderImplTest should not depend on LoadingIPCType It simply passes the value to ResourceDispatcher which is mocked on this test. BUG=603396 Review-Url: https://codereview.chromium.org/2650673002 Cr-Commit-Position: refs/heads/master@{#445349} Committed: https://chromium.googlesource.com/chromium/src/+/3c522c90b1d17cdbacc845d4bd5c931c926143ce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M content/child/web_url_loader_impl_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (10 generated)
yhirano
3 years, 11 months ago (2017-01-23 09:09:31 UTC) #5
tzik
lgtm
3 years, 11 months ago (2017-01-23 10:30:01 UTC) #8
yhirano
+jochen@ for OWNER review.
3 years, 11 months ago (2017-01-23 10:32:49 UTC) #10
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-23 10:34:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650673002/1
3 years, 11 months ago (2017-01-23 10:35:26 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 10:39:12 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3c522c90b1d17cdbacc845d4bd5c...

Powered by Google App Engine
This is Rietveld 408576698