Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2650653009:
Reset extension downloader when updating external extension cache (Closed)
DescriptionReset extension downloader when updating external extension cache.
Downloader is reset to force restarting any existing attempts for
extension download.
If downloader had previously started an extension
download, but hasn't yet finished, adding a new request for the
extension would just update existing request and wait for it to finish.
This can be problematic in case the previous extension download kept
failing - e.g. due to network problem. Downloader would retry
downloading the extension, but with an exponential back-off.
This means that request for an extension download when extension list
is updated might be delayed for a long time due to previous failures
(up to 17 minutes; download request allows up to 10 retries before
reporting download failure - final delay seems to be 17 minutes).
Resetting downloader when extension list update is requested will reset
the failure count, and thus reset the back-off value.
BUG=685878
Review-Url: https://codereview.chromium.org/2650653009
Cr-Commit-Position: refs/heads/master@{#446704}
Committed: https://chromium.googlesource.com/chromium/src/+/c85710cea0a6cd68a730dc537d05c970015ef521
Patch Set 1 #
Messages
Total messages: 17 (12 generated)
The CQ bit was checked by tbarzic@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Reset extension downloader when checking external extension cache state BUG=685878 ========== to ========== Reset extension downloader when checking external extension cache state Downloader is reset to force restarting any existing attempts for extension download. If downloader had previously started an extension download, but hasn't yet finished, adding a new request for the extension would just update existing request and wait for it to finish. This can be problematic in case the previous extension download kept failing - e.g. due to network problem. Downloader would retry downloading the extension, but with an exponential back-off. This means that request for an extension download when extension list is updated might be delayed for a long time due to previous failures (as seen in the referenced bug). Resetting downloader when extension list update is requested will reset the failure count, and thus reset the back-off value. BUG=685878 ==========
Description was changed from ========== Reset extension downloader when checking external extension cache state Downloader is reset to force restarting any existing attempts for extension download. If downloader had previously started an extension download, but hasn't yet finished, adding a new request for the extension would just update existing request and wait for it to finish. This can be problematic in case the previous extension download kept failing - e.g. due to network problem. Downloader would retry downloading the extension, but with an exponential back-off. This means that request for an extension download when extension list is updated might be delayed for a long time due to previous failures (as seen in the referenced bug). Resetting downloader when extension list update is requested will reset the failure count, and thus reset the back-off value. BUG=685878 ========== to ========== Reset extension downloader when updating external extension cache. Downloader is reset to force restarting any existing attempts for extension download. If downloader had previously started an extension download, but hasn't yet finished, adding a new request for the extension would just update existing request and wait for it to finish. This can be problematic in case the previous extension download kept failing - e.g. due to network problem. Downloader would retry downloading the extension, but with an exponential back-off. This means that request for an extension download when extension list is updated might be delayed for a long time due to previous failures (as seen in the referenced bug). Resetting downloader when extension list update is requested will reset the failure count, and thus reset the back-off value. BUG=685878 ==========
Description was changed from ========== Reset extension downloader when updating external extension cache. Downloader is reset to force restarting any existing attempts for extension download. If downloader had previously started an extension download, but hasn't yet finished, adding a new request for the extension would just update existing request and wait for it to finish. This can be problematic in case the previous extension download kept failing - e.g. due to network problem. Downloader would retry downloading the extension, but with an exponential back-off. This means that request for an extension download when extension list is updated might be delayed for a long time due to previous failures (as seen in the referenced bug). Resetting downloader when extension list update is requested will reset the failure count, and thus reset the back-off value. BUG=685878 ========== to ========== Reset extension downloader when updating external extension cache. Downloader is reset to force restarting any existing attempts for extension download. If downloader had previously started an extension download, but hasn't yet finished, adding a new request for the extension would just update existing request and wait for it to finish. This can be problematic in case the previous extension download kept failing - e.g. due to network problem. Downloader would retry downloading the extension, but with an exponential back-off. This means that request for an extension download when extension list is updated might be delayed for a long time due to previous failures (up to 17 minutes; download request allows up to 10 retries before reporting download failure - final delay seems to be 17 minutes). Resetting downloader when extension list update is requested will reset the failure count, and thus reset the back-off value. BUG=685878 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
tbarzic@chromium.org changed reviewers: + xiyuan@chromium.org
ptal
lgtm
tbarzic@chromium.org changed reviewers: + steel@chromium.org
+steel, as fyi
The CQ bit was checked by tbarzic@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1485538417713110, "parent_rev":
"2a45c1ddaa0ec0c9410d8ee61bd3aa6862c64c74", "commit_rev":
"c85710cea0a6cd68a730dc537d05c970015ef521"}
Message was sent while issue was closed.
Description was changed from ========== Reset extension downloader when updating external extension cache. Downloader is reset to force restarting any existing attempts for extension download. If downloader had previously started an extension download, but hasn't yet finished, adding a new request for the extension would just update existing request and wait for it to finish. This can be problematic in case the previous extension download kept failing - e.g. due to network problem. Downloader would retry downloading the extension, but with an exponential back-off. This means that request for an extension download when extension list is updated might be delayed for a long time due to previous failures (up to 17 minutes; download request allows up to 10 retries before reporting download failure - final delay seems to be 17 minutes). Resetting downloader when extension list update is requested will reset the failure count, and thus reset the back-off value. BUG=685878 ========== to ========== Reset extension downloader when updating external extension cache. Downloader is reset to force restarting any existing attempts for extension download. If downloader had previously started an extension download, but hasn't yet finished, adding a new request for the extension would just update existing request and wait for it to finish. This can be problematic in case the previous extension download kept failing - e.g. due to network problem. Downloader would retry downloading the extension, but with an exponential back-off. This means that request for an extension download when extension list is updated might be delayed for a long time due to previous failures (up to 17 minutes; download request allows up to 10 retries before reporting download failure - final delay seems to be 17 minutes). Resetting downloader when extension list update is requested will reset the failure count, and thus reset the back-off value. BUG=685878 Review-Url: https://codereview.chromium.org/2650653009 Cr-Commit-Position: refs/heads/master@{#446704} Committed: https://chromium.googlesource.com/chromium/src/+/c85710cea0a6cd68a730dc537d05... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c85710cea0a6cd68a730dc537d05... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
