Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 2650653006: PlzNavigate; fix UAF in RenderFrameImpl::OnCommitNavigation (Closed)

Created:
3 years, 11 months ago by clamy
Modified:
3 years, 11 months ago
Reviewers:
alexmos
CC:
chromium-reviews, nasko+codewatch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate; fix UAF in RenderFrameImpl::OnCommitNavigation This CL fixes a UAF bug in RenderFrameImpl::OnCommitNavigation. This was uncovered by re-enabling SitePerProcessBrowserTest.NavigateAboutBlankAndDetach. BUG=684699 Review-Url: https://codereview.chromium.org/2650653006 Cr-Commit-Position: refs/heads/master@{#446040} Committed: https://chromium.googlesource.com/chromium/src/+/d7d3ad002ee9f002bf7f7f763a6a815052602ac1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/renderer/render_frame_impl.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
clamy
@alexmos: PTAL
3 years, 11 months ago (2017-01-25 14:52:28 UTC) #5
alexmos
LGTM. Thanks for the quick fix!
3 years, 11 months ago (2017-01-25 16:52:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650653006/1
3 years, 11 months ago (2017-01-25 16:53:20 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 16:58:32 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d7d3ad002ee9f002bf7f7f763a6a...

Powered by Google App Engine
This is Rietveld 408576698