Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(440)

Issue 2650633003: Fix threading issues in the audio pipeline for WebRTC remoting protocol. (Closed)

Created:
3 years, 9 months ago by Sergey Ulanov
Modified:
3 years, 9 months ago
Reviewers:
nicholss, Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix threading issues in the audio pipeline for WebRTC remoting protocol. 1. Updated unittests to use a separate thread for audio encoding and decoding. 2. WebrtcAudioSinkAdapter was calling AudioStub on a wrong thread. 3. WebrtcAudioModule was destroying base::Timer on a thread different from the one on which it is created. Review-Url: https://codereview.chromium.org/2650633003 Cr-Original-Commit-Position: refs/heads/master@{#445566} Committed: https://chromium.googlesource.com/chromium/src/+/25680c62320767f590d037d301edfe15e9c55650 Review-Url: https://codereview.chromium.org/2650633003 Cr-Commit-Position: refs/heads/master@{#445672} Committed: https://chromium.googlesource.com/chromium/src/+/53c571c9fc446c851e59da61ac36277b666b1705

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -19 lines) Patch
M remoting/protocol/connection_unittest.cc View 1 6 chunks +17 lines, -2 lines 0 comments Download
M remoting/protocol/webrtc_audio_module.h View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/protocol/webrtc_audio_module.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M remoting/protocol/webrtc_audio_sink_adapter.h View 2 chunks +7 lines, -2 lines 0 comments Download
M remoting/protocol/webrtc_audio_sink_adapter.cc View 4 chunks +9 lines, -11 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
Sergey Ulanov
3 years, 9 months ago (2017-01-23 23:31:30 UTC) #2
Sergey Ulanov
3 years, 9 months ago (2017-01-23 23:31:58 UTC) #4
nicholss
lgtm
3 years, 9 months ago (2017-01-23 23:42:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650633003/1
3 years, 9 months ago (2017-01-23 23:43:17 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/25680c62320767f590d037d301edfe15e9c55650
3 years, 9 months ago (2017-01-24 00:38:30 UTC) #10
findit-for-me
FYI: Findit identified this CL at revision 445566 as the culprit for failures in the ...
3 years, 9 months ago (2017-01-24 00:58:52 UTC) #11
waffles
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2653773005/ by waffles@chromium.org. ...
3 years, 9 months ago (2017-01-24 01:06:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650633003/20001
3 years, 9 months ago (2017-01-24 06:43:03 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-01-24 07:11:40 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/53c571c9fc446c851e59da61ac36...

Powered by Google App Engine
This is Rietveld 408576698