Fix threading issues in the audio pipeline for WebRTC remoting protocol.

Fix threading issues in the audio pipeline for WebRTC remoting protocol.

1. Updated unittests to use a separate thread for audio encoding and
   decoding.
2. WebrtcAudioSinkAdapter was calling AudioStub on a wrong thread.
3. WebrtcAudioModule was destroying base::Timer on a thread different
   from the one on which it is created.

Review-Url: https://codereview.chromium.org/2650633003
Cr-Original-Commit-Position: refs/heads/master@{#445566}
Committed: https://chromium.googlesource.com/chromium/src/+/25680c62320767f590d037d301edfe15e9c55650
Review-Url: https://codereview.chromium.org/2650633003
Cr-Commit-Position: refs/heads/master@{#445672}
Committed: https://chromium.googlesource.com/chromium/src/+/53c571c9fc446c851e59da61ac36277b666b1705

[Sergey Ulanov, 2017-01-23 23:31:29]

sergeyu@chromium.org changed reviewers:
+ nicholss@chromium.org

[Sergey Ulanov, 2017-01-23 23:31:58]

sergeyu@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[nicholss, 2017-01-23 23:42:33]

The CQ bit was checked by nicholss@chromium.org

[nicholss, 2017-01-23 23:42:34]

lgtm

[commit-bot: I haz the power, 2017-01-23 23:43:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 00:37:56]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485214953886760, "parent_rev":
"4fd3ff4ead77380b23fe7e91999c319d2408dedd", "commit_rev":
"25680c62320767f590d037d301edfe15e9c55650"}

[commit-bot: I haz the power, 2017-01-24 00:38:29]

Description was changed from

==========
Fix threading issues in the audio pipeline for WebRTC remoting protocol.

1. Updated unittests to use a separate thread for audio encoding and
   decoding.
2. WebrtcAudioSinkAdapter was calling AudioStub on a wrong thread.
3. WebrtcAudioModule was destroying base::Timer on a thread different
   from the one on which it is created.
==========

to

==========
Fix threading issues in the audio pipeline for WebRTC remoting protocol.

1. Updated unittests to use a separate thread for audio encoding and
   decoding.
2. WebrtcAudioSinkAdapter was calling AudioStub on a wrong thread.
3. WebrtcAudioModule was destroying base::Timer on a thread different
   from the one on which it is created.

Review-Url: https://codereview.chromium.org/2650633003
Cr-Commit-Position: refs/heads/master@{#445566}
Committed:
https://chromium.googlesource.com/chromium/src/+/25680c62320767f590d037d301ed...
==========

[commit-bot: I haz the power, 2017-01-24 00:38:30]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/25680c62320767f590d037d301ed...

[findit-for-me, 2017-01-24 00:58:52]

FYI: Findit identified this CL at revision 445566 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[waffles, 2017-01-24 01:06:06]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2653773005/ by waffles@chromium.org.

The reason for reverting is: Breaks compile

../../remoting/protocol/connection_unittest.cc:246:23: error: private field
'thread_checker_' is not used [-Werror,-Wunused-private-field]
  base::ThreadChecker thread_checker_;.

[Sergey Ulanov, 2017-01-24 06:42:45]

Description was changed from

==========
Fix threading issues in the audio pipeline for WebRTC remoting protocol.

1. Updated unittests to use a separate thread for audio encoding and
   decoding.
2. WebrtcAudioSinkAdapter was calling AudioStub on a wrong thread.
3. WebrtcAudioModule was destroying base::Timer on a thread different
   from the one on which it is created.

Review-Url: https://codereview.chromium.org/2650633003
Cr-Commit-Position: refs/heads/master@{#445566}
Committed:
https://chromium.googlesource.com/chromium/src/+/25680c62320767f590d037d301ed...
==========

to

==========
Fix threading issues in the audio pipeline for WebRTC remoting protocol.

1. Updated unittests to use a separate thread for audio encoding and
   decoding.
2. WebrtcAudioSinkAdapter was calling AudioStub on a wrong thread.
3. WebrtcAudioModule was destroying base::Timer on a thread different
   from the one on which it is created.

Review-Url: https://codereview.chromium.org/2650633003
Cr-Commit-Position: refs/heads/master@{#445566}
Committed:
https://chromium.googlesource.com/chromium/src/+/25680c62320767f590d037d301ed...
==========

[Sergey Ulanov, 2017-01-24 06:42:49]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2017-01-24 06:42:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
nicholss@chromium.org
Link to the patchset: https://codereview.chromium.org/2650633003/#ps20001
(title: ".")

[commit-bot: I haz the power, 2017-01-24 06:43:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 07:11:08]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485240169537320,
"parent_rev": "0a70d0b1274c093e26a7159ee83dab2a87112bdd", "commit_rev":
"53c571c9fc446c851e59da61ac36277b666b1705"}

[commit-bot: I haz the power, 2017-01-24 07:11:40]

Description was changed from

==========
Fix threading issues in the audio pipeline for WebRTC remoting protocol.

1. Updated unittests to use a separate thread for audio encoding and
   decoding.
2. WebrtcAudioSinkAdapter was calling AudioStub on a wrong thread.
3. WebrtcAudioModule was destroying base::Timer on a thread different
   from the one on which it is created.

Review-Url: https://codereview.chromium.org/2650633003
Cr-Commit-Position: refs/heads/master@{#445566}
Committed:
https://chromium.googlesource.com/chromium/src/+/25680c62320767f590d037d301ed...
==========

to

==========
Fix threading issues in the audio pipeline for WebRTC remoting protocol.

1. Updated unittests to use a separate thread for audio encoding and
   decoding.
2. WebrtcAudioSinkAdapter was calling AudioStub on a wrong thread.
3. WebrtcAudioModule was destroying base::Timer on a thread different
   from the one on which it is created.

Review-Url: https://codereview.chromium.org/2650633003
Cr-Original-Commit-Position: refs/heads/master@{#445566}
Committed:
https://chromium.googlesource.com/chromium/src/+/25680c62320767f590d037d301ed...
Review-Url: https://codereview.chromium.org/2650633003
Cr-Commit-Position: refs/heads/master@{#445672}
Committed:
https://chromium.googlesource.com/chromium/src/+/53c571c9fc446c851e59da61ac36...
==========

[commit-bot: I haz the power, 2017-01-24 07:11:40]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/53c571c9fc446c851e59da61ac36...