Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 2650593003: Store distilled URL during distillation in Reading List on iOS (Closed)

Created:
3 years, 11 months ago by Olivier
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Store distilled URL during distillation in Reading List on iOS The URL of the distilled page is not necessarily the URL of the Reading List entry (incase of redirection). If the distillation is done on a redirected page, store it along the distilled_path. I also filed crbug.com/682705 to have the "redirected_url" directly in the proto file and avoid having to take it via callback. BUG=682666 Review-Url: https://codereview.chromium.org/2646993002 Cr-Commit-Position: refs/heads/master@{#445071} (cherry picked from commit 69e7e3b844f1cedf53701f07bf0d3219fc2d3176) Review-Url: https://codereview.chromium.org/2650593003 . Cr-Commit-Position: refs/branch-heads/2987@{#22} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/f0b185bb6ab2b21c8f23e66b86d02ac73dbbca0b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -18 lines) Patch
M components/dom_distiller/ios/distiller_page_ios.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/dom_distiller/distiller_viewer.h View 1 chunk +3 lines, -4 lines 0 comments Download
M ios/chrome/browser/dom_distiller/distiller_viewer.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_distiller_page.h View 3 chunks +10 lines, -1 line 0 comments Download
M ios/chrome/browser/reading_list/reading_list_distiller_page.mm View 4 chunks +14 lines, -1 line 0 comments Download
M ios/chrome/browser/reading_list/reading_list_distiller_page_factory.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_distiller_page_factory.mm View 1 chunk +6 lines, -0 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_download_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_download_service.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ios/chrome/browser/reading_list/url_downloader.h View 3 chunks +11 lines, -4 lines 0 comments Download
M ios/chrome/browser/reading_list/url_downloader.cc View 3 chunks +19 lines, -3 lines 0 comments Download
M ios/chrome/browser/reading_list/url_downloader_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Olivier
3 years, 11 months ago (2017-01-23 15:24:14 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f0b185bb6ab2b21c8f23e66b86d02ac73dbbca0b.

Powered by Google App Engine
This is Rietveld 408576698