Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2650593002: [test] Check object literal backing store size. (Closed)

Created:
3 years, 11 months ago by Franzi
Modified:
3 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Check object literal backing store size. Property backing store size for object literals is the number of constant and named properties (possibly over-allocating for the same names). We do not reserve space in the backing store for __proto__. We do not reserve space in the backing store for index keys. Currently, we account for index keys in the runtime when iterating over the boilerplate properties. Since the boilerplate properties only include the properties up to the first computed property name, the property backing store size includes space for index keys if seen after the first computed property. R=verwaest@chromium.org BUG=v8:5625 Review-Url: https://codereview.chromium.org/2650593002 Cr-Commit-Position: refs/heads/master@{#42584} Committed: https://chromium.googlesource.com/v8/v8/+/15623183e23e5d863d40d29427ea1eaca0774e72

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -0 lines) Patch
M test/cctest/test-inobject-slack-tracking.cc View 1 chunk +106 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
Franzi
Hi Toon, Adding a few test case before I move the code that adopts the ...
3 years, 11 months ago (2017-01-22 21:26:17 UTC) #5
Toon Verwaest
lgtm
3 years, 11 months ago (2017-01-22 21:38:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650593002/1
3 years, 11 months ago (2017-01-22 21:43:04 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-22 21:44:48 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/15623183e23e5d863d40d29427ea1eaca07...

Powered by Google App Engine
This is Rietveld 408576698