cc: Remove internal Inputs struct from LayerTree

cc: Remove internal Inputs struct from LayerTree

This internal division of data was done to allow blimp to easily
identify the data that needed to be serialized. Since that is no longer
necessary, the patch reverts that before merging the LayerTree back
into the host.

BUG=682436
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2650583013
Cr-Commit-Position: refs/heads/master@{#446376}
Committed: https://chromium.googlesource.com/chromium/src/+/8476b653814ed190107d9c60e5fb0142be79deb9

[Khushal, 2017-01-25 22:23:04]

Description was changed from

==========
cc: Remove internal Inputs struct from LayerTree

This internal division of data was done to allow blimp to easily
identify the data that needed to be serialized. Since that is no longer
necessary, the patch reverts that before merging the LayerTree back
into the host.

BUG=682436
==========

to

==========
cc: Remove internal Inputs struct from LayerTree

This internal division of data was done to allow blimp to easily
identify the data that needed to be serialized. Since that is no longer
necessary, the patch reverts that before merging the LayerTree back
into the host.

BUG=682436
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Khushal, 2017-01-25 22:23:51]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[Khushal, 2017-01-25 22:24:01]

khushalsagar@chromium.org changed reviewers:
+ danakj@chromium.org

[commit-bot: I haz the power, 2017-01-25 22:24:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2017-01-25 22:26:30]

LGTM

https://codereview.chromium.org/2650583013/diff/1/cc/trees/layer_tree.cc
File cc/trees/layer_tree.cc (right):

https://codereview.chromium.org/2650583013/diff/1/cc/trees/layer_tree.cc#newc...
cc/trees/layer_tree.cc:22: : top_controls_height_(0.f),
if you don't mind.. while you're here.. it'd be nice to move all the constant
initializers over to the header.

[Khushal, 2017-01-25 22:36:25]

https://codereview.chromium.org/2650583013/diff/1/cc/trees/layer_tree.cc
File cc/trees/layer_tree.cc (right):

https://codereview.chromium.org/2650583013/diff/1/cc/trees/layer_tree.cc#newc...
cc/trees/layer_tree.cc:22: : top_controls_height_(0.f),
On 2017/01/25 22:26:30, danakj (slow) wrote:
> if you don't mind.. while you're here.. it'd be nice to move all the constant
> initializers over to the header.

Done. :)

[Khushal, 2017-01-25 22:37:15]

The CQ bit was checked by khushalsagar@chromium.org

[Khushal, 2017-01-25 22:37:16]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2650583013/#ps20001
(title: "header")

[commit-bot: I haz the power, 2017-01-25 22:38:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2017-01-25 22:40:45]

Cool thanks!

[commit-bot: I haz the power, 2017-01-25 23:24:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 23:24:41]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Khushal, 2017-01-26 00:18:15]

Looks like I had missed the needs_full_tree_sync initialization to true. I
thought it should have happened anyway when we set the root layer on the tree
but the tests were overriding that method to make it a no-op.

Do you want to take another look?

[Khushal, 2017-01-26 00:18:27]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 00:20:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 02:35:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 02:35:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Khushal, 2017-01-26 04:51:33]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 04:51:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 06:00:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 06:00:34]

Dry run: This issue passed the CQ dry run.

[danakj, 2017-01-26 16:53:28]

LGTM

[Khushal, 2017-01-26 18:04:42]

The CQ bit was checked by khushalsagar@chromium.org

[commit-bot: I haz the power, 2017-01-26 18:05:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 18:09:33]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485453882400570,
"parent_rev": "e99cb231b7f6ae64a55e31f9589476e341c00734", "commit_rev":
"8476b653814ed190107d9c60e5fb0142be79deb9"}

[commit-bot: I haz the power, 2017-01-26 18:10:13]

Description was changed from

==========
cc: Remove internal Inputs struct from LayerTree

This internal division of data was done to allow blimp to easily
identify the data that needed to be serialized. Since that is no longer
necessary, the patch reverts that before merging the LayerTree back
into the host.

BUG=682436
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Remove internal Inputs struct from LayerTree

This internal division of data was done to allow blimp to easily
identify the data that needed to be serialized. Since that is no longer
necessary, the patch reverts that before merging the LayerTree back
into the host.

BUG=682436
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2650583013
Cr-Commit-Position: refs/heads/master@{#446376}
Committed:
https://chromium.googlesource.com/chromium/src/+/8476b653814ed190107d9c60e5fb...
==========

[commit-bot: I haz the power, 2017-01-26 18:10:14]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8476b653814ed190107d9c60e5fb...