Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 2650583004: ShapeDetection: Move factory method to static nested class (Closed)

Created:
3 years, 11 months ago by xianglu
Modified:
3 years, 11 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ShapeDetection: Move factory method to static nested class This CL moves shape detection factory classes into their respective *Impl.java. No new code added. BUG=646083 Review-Url: https://codereview.chromium.org/2650583004 Cr-Commit-Position: refs/heads/master@{#445547} Committed: https://chromium.googlesource.com/chromium/src/+/8c2328be639d9564f7654224734d651e5cee0d11

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -83 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/mojo/ChromeInterfaceRegistrar.java View 2 chunks +5 lines, -4 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/shapedetection/BarcodeDetectionFactory.java View 1 chunk +0 lines, -26 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/shapedetection/BarcodeDetectionImpl.java View 2 chunks +16 lines, -0 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionFactory.java View 1 chunk +0 lines, -26 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionImpl.java View 2 chunks +17 lines, -0 lines 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/InterfaceRegistrarImpl.java View 2 chunks +2 lines, -2 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/shapedetection/FaceDetectionProviderFactory.java View 1 chunk +0 lines, -22 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/shapedetection/FaceDetectionProviderImpl.java View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 33 (26 generated)
xianglu
PTAL. A CL for code refactoring. nick@, Please review changes in //content mariakhomenko@, Please review ...
3 years, 11 months ago (2017-01-23 22:06:48 UTC) #18
Maria
lgtm
3 years, 11 months ago (2017-01-23 22:30:58 UTC) #21
mcasas
lgtm
3 years, 11 months ago (2017-01-23 22:31:35 UTC) #22
ncarter (slow)
lgtm
3 years, 11 months ago (2017-01-23 22:34:38 UTC) #23
Reilly Grant (use Gerrit)
lgtm
3 years, 11 months ago (2017-01-23 22:40:30 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650583004/60001
3 years, 11 months ago (2017-01-23 23:39:47 UTC) #30
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 23:47:09 UTC) #33
Message was sent while issue was closed.
Committed patchset #1 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8c2328be639d9564f7654224734d...

Powered by Google App Engine
This is Rietveld 408576698