Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2650473003: Fix viewport unit sizes when printing. (Closed)

Created:
3 years, 11 months ago by bokan
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Fix viewport unit sizes when printing. FrameView::viewportSizeForViewportUnits had a special path for inert top controls that used FrameView::layoutSize directly. The old path used LayoutView::viewWidth and LayoutView::viewHeight which normally resolve to FrameView::layoutSize but has a special case for when we're in printing mode. This patch uses the LayoutView version and only special cases the adjustment made for the URL bar. BUG=678414 Review-Url: https://codereview.chromium.org/2643903002 Cr-Commit-Position: refs/heads/master@{#444803} (cherry picked from commit b9d998089be2a4ee8a304730a814386168f84641) Review-Url: https://codereview.chromium.org/2650473003 . Cr-Commit-Position: refs/branch-heads/2924@{#820} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/5246d47f2bb96bea8d40a2838c1a018e1ce53325

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -28 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +23 lines, -28 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
bokan
3 years, 11 months ago (2017-01-20 19:42:30 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5246d47f2bb96bea8d40a2838c1a018e1ce53325.

Powered by Google App Engine
This is Rietveld 408576698