Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2650433002: Remove sync_wpt and add wpt-export to replace it. (Closed)

Created:
3 years, 11 months ago by qyearsley
Modified:
3 years, 11 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove sync_wpt and add wpt-export to replace it. This CL basically renames "sync-wpt" to "wpt-export" and makes a couple of additional minor clean-up changes: - Remove use of configure_logging from test_importer which is now removed. - Remove --no-fetch option from the script. - Expand docstring and use docstring as --help description. BUG=681406 Review-Url: https://codereview.chromium.org/2650433002 Cr-Commit-Position: refs/heads/master@{#445581} Committed: https://chromium.googlesource.com/chromium/src/+/4c7dc89449103d77aad52cdd11a737fad0f01ab9

Patch Set 1 #

Total comments: 6

Patch Set 2 : Feedback #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -44 lines) Patch
D third_party/WebKit/Tools/Scripts/sync-wpt View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/w3c/sync_wpt.py View 1 chunk +0 lines, -34 lines 0 comments Download
A third_party/WebKit/Tools/Scripts/wpt-export View 1 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
qyearsley
3 years, 11 months ago (2017-01-20 18:52:05 UTC) #2
jeffcarp
Left notes below. Thanks for doing this! 👍👍 Much cleaner now. https://codereview.chromium.org/2650433002/diff/1/third_party/WebKit/Tools/Scripts/wpt-export File third_party/WebKit/Tools/Scripts/wpt-export (right): ...
3 years, 11 months ago (2017-01-20 22:19:13 UTC) #3
qyearsley
https://codereview.chromium.org/2650433002/diff/1/third_party/WebKit/Tools/Scripts/wpt-export File third_party/WebKit/Tools/Scripts/wpt-export (right): https://codereview.chromium.org/2650433002/diff/1/third_party/WebKit/Tools/Scripts/wpt-export#newcode2 third_party/WebKit/Tools/Scripts/wpt-export:2: # Copyright 2016 The Chromium Authors. All rights reserved. ...
3 years, 11 months ago (2017-01-20 23:22:43 UTC) #4
jeffcarp
lgtm
3 years, 11 months ago (2017-01-20 23:31:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650433002/20001
3 years, 11 months ago (2017-01-23 17:11:26 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/373975)
3 years, 11 months ago (2017-01-23 18:48:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650433002/20001
3 years, 11 months ago (2017-01-23 23:28:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650433002/40001
3 years, 11 months ago (2017-01-23 23:51:27 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 01:39:41 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4c7dc89449103d77aad52cdd11a7...

Powered by Google App Engine
This is Rietveld 408576698