Issue 265043004: Revert 267948 "Merge GeolocationDispatcherHostImpl with Geolocat..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 265043004: Revert 267948 "Merge GeolocationDispatcherHostImpl with Geolocat..." (Closed)

Created:
6 years, 7 months ago by Albert Bodenhamer

Modified:
6 years, 7 months ago

Reviewers:
jam

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 267948 "Merge GeolocationDispatcherHostImpl with Geolocat..." > Merge GeolocationDispatcherHostImpl with GeolocationDispatcherHost. None of the other message filters hide the internal in the cc file, and it just makes reading/modifying this code harder. > > BUG=304341 > R=avi@chromium.org, mvanouwerkerk@chromium.org > > Review URL: https://codereview.chromium.org/262753006 TBR=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267949

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+108 lines, -77 lines)			Patch
M	trunk/src/content/browser/geolocation/geolocation_dispatcher_host.h	View	2 chunks	+5 lines, -60 lines	0 comments	Download
M	trunk/src/content/browser/geolocation/geolocation_dispatcher_host.cc	View	10 chunks	+102 lines, -16 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/render_process_host_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Albert Bodenhamer

6 years, 7 months ago (2014-05-02 22:56:06 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r267949 (tree was closed).