Issue 262753006: Merge GeolocationDispatcherHostImpl with GeolocationDispatcher. None of the other message filters h…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 262753006: Merge GeolocationDispatcherHostImpl with GeolocationDispatcher. None of the other message filters h… (Closed)

Created:
6 years, 7 months ago by jam

Modified:
6 years, 7 months ago

Reviewers:
Avi (use Gerrit), Michael van Ouwerkerk

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org, Michael van Ouwerkerk, site-isolation-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Merge GeolocationDispatcherHostImpl with GeolocationDispatcherHost. None of the other message filters hide the internal in the cc file, and it just makes reading/modifying this code harder. BUG=304341 R=avi@chromium.org, mvanouwerkerk@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267948 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268088

Patch Set 1 #

Patch Set 2 : reupload after revert with fix #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -107 lines)			Patch
M	content/browser/geolocation/geolocation_dispatcher_host.h	View	1	3 chunks	+60 lines, -4 lines	0 comments	Download
M	content/browser/geolocation/geolocation_dispatcher_host.cc	View	1	10 chunks	+16 lines, -102 lines	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael van Ouwerkerk

Thanks John! lgtm Please update the description to "GeolocationDispatcherHostImpl with GeolocationDispatcherHost". Merging it into GeolocationDispatcher ...

6 years, 7 months ago (2014-05-01 18:23:50 UTC) #3

jam

6 years, 7 months ago (2014-05-01 19:22:02 UTC) #4

On 2014/05/01 18:23:50, Michael van Ouwerkerk wrote:
> Thanks John! lgtm

Thanks for the review

> 
> Please update the description to "GeolocationDispatcherHostImpl with
> GeolocationDispatcherHost".
> 
> Merging it into GeolocationDispatcher would be unusual.

Fixed

Expand Messages | Collapse Messages