Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: third_party/WebKit/Source/web/PopupMenuImpl.cpp

Issue 2650403006: Remove PlatformMouseEvent and use WebMouseEvent instead (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/PopupMenuImpl.cpp
diff --git a/third_party/WebKit/Source/web/PopupMenuImpl.cpp b/third_party/WebKit/Source/web/PopupMenuImpl.cpp
index 7b2b88f4b059ea43c4ecfec2b2b5485d281c1ffc..97bf482a6c9ff11ee298c762097a9b012dd0367e 100644
--- a/third_party/WebKit/Source/web/PopupMenuImpl.cpp
+++ b/third_party/WebKit/Source/web/PopupMenuImpl.cpp
@@ -446,7 +446,9 @@ void PopupMenuImpl::setValueAndClosePopup(int numValue,
// We dispatch events on the owner element to match the legacy behavior.
// Other browsers dispatch click events before and after showing the popup.
if (m_ownerElement) {
- PlatformMouseEvent event;
+ // TODO(dtapuska): Why is this event positionless?
bokan 2017/01/27 16:57:17 It looks like this is called from popup HTML conte
dtapuska 2017/01/27 21:00:00 This should probably be generated from the element
bokan 2017/01/27 21:08:47 Hmm, yeah, that makes sense.
+ WebMouseEvent event;
+ event.setFrameScale(1);
Element* owner = &ownerElement();
owner->dispatchMouseEvent(event, EventTypeNames::mouseup);
owner->dispatchMouseEvent(event, EventTypeNames::click);

Powered by Google App Engine
This is Rietveld 408576698