Remove PlatformMouseEvent and use WebMouseEvent instead

third_party/WebKit/Source/web/PopupMenuImpl.cpp

 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "web/PopupMenuImpl.h"
 
 #include "core/HTMLNames.h"
 #include "core/css/CSSFontSelector.h"
 #include "core/dom/ElementTraversal.h"
 #include "core/dom/ExecutionContextTask.h"
@@ skipping 428 matching lines @@
     // 'change' event is dispatched here.  For compatbility with
     // Angular 1.2, we need to dispatch a change event before
     // mouseup/click events.
   } else {
     if (m_popup)
       m_chromeClient->closePagePopup(m_popup);
   }
   // We dispatch events on the owner element to match the legacy behavior.
   // Other browsers dispatch click events before and after showing the popup.
   if (m_ownerElement) {
-    PlatformMouseEvent event;
+    // TODO(dtapuska): Why is this event positionless?

[bokan, 2017/01/27 16:57:17]

It looks like this is called from popup HTML content, e.g. when a DateTime
picker selects an item using the enter key. It seems like we dispatch these
mouse events for compatibility but they don't actually come from a mouse click
so there's no position to set. I suppose we could pass the "last known mouse
position" but that doesn't seem easily accessible from here.

[dtapuska, 2017/01/27 21:00:00]

This should probably be generated from the element's position no? kind of like
how the context menu is generated...

[bokan, 2017/01/27 21:08:47]

Hmm, yeah, that makes sense.

+    WebMouseEvent event;
+    event.setFrameScale(1);
     Element* owner = &ownerElement();
     owner->dispatchMouseEvent(event, EventTypeNames::mouseup);
     owner->dispatchMouseEvent(event, EventTypeNames::click);
   }
 }
 
 void PopupMenuImpl::setValue(const String& value) {
   DCHECK(m_ownerElement);
   bool success;
   int listIndex = value.toInt(&success);
@@ skipping 94 matching lines @@
 }
 
 void PopupMenuImpl::disconnectClient() {
   m_ownerElement = nullptr;
   // Cannot be done during finalization, so instead done when the
   // layout object is destroyed and disconnected.
   dispose();
 }
 
 }  // namespace blink