chrome/android/java/src/org/chromium/chrome/browser/ChromeActionModeCallback.java - Issue 2650403004: (Android) Removing ErrorProne warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActionModeCallback.java

Issue 2650403004: (Android) Removing ErrorProne warnings (Closed)

Patch Set: 2nd patch version with more warnings removed Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwActionModeCallback.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActionModeCallback.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActionModeCallback.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActionModeCallback.java

index a5255a61cdd37eb789fe599514b2bb4e0a8b3990..291faa36c799f685170a523ab45ded9f8d8d1010 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActionModeCallback.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActionModeCallback.java

@@ -87,7 +87,7 @@ public class ChromeActionModeCallback implements ActionMode.Callback {

RecordUserAction.record("MobileActionMode.WebSearch");

if (mTab.getTabModelSelector() == null) return;

- String query = mHelper.sanitizeQuery(mHelper.getSelectedText(),

+ String query = ActionModeCallbackHelper.sanitizeQuery(mHelper.getSelectedText(),

ActionModeCallbackHelper.MAX_SEARCH_QUERY_LENGTH);

if (TextUtils.isEmpty(query)) return;