Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActionModeCallback.java

Issue 2650403004: (Android) Removing ErrorProne warnings (Closed)
Patch Set: 2nd patch version with more warnings removed Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser; 5 package org.chromium.chrome.browser;
6 6
7 import android.content.Context; 7 import android.content.Context;
8 import android.text.TextUtils; 8 import android.text.TextUtils;
9 import android.view.ActionMode; 9 import android.view.ActionMode;
10 import android.view.Menu; 10 import android.view.Menu;
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 private void notifyContextualActionBarVisibilityChanged(boolean show) { 80 private void notifyContextualActionBarVisibilityChanged(boolean show) {
81 if (!mHelper.supportsFloatingActionMode()) { 81 if (!mHelper.supportsFloatingActionMode()) {
82 mTab.notifyContextualActionBarVisibilityChanged(show); 82 mTab.notifyContextualActionBarVisibilityChanged(show);
83 } 83 }
84 } 84 }
85 85
86 private void search() { 86 private void search() {
87 RecordUserAction.record("MobileActionMode.WebSearch"); 87 RecordUserAction.record("MobileActionMode.WebSearch");
88 if (mTab.getTabModelSelector() == null) return; 88 if (mTab.getTabModelSelector() == null) return;
89 89
90 String query = mHelper.sanitizeQuery(mHelper.getSelectedText(), 90 String query = ActionModeCallbackHelper.sanitizeQuery(mHelper.getSelecte dText(),
91 ActionModeCallbackHelper.MAX_SEARCH_QUERY_LENGTH); 91 ActionModeCallbackHelper.MAX_SEARCH_QUERY_LENGTH);
92 if (TextUtils.isEmpty(query)) return; 92 if (TextUtils.isEmpty(query)) return;
93 93
94 String url = TemplateUrlService.getInstance().getUrlForSearchQuery(query ); 94 String url = TemplateUrlService.getInstance().getUrlForSearchQuery(query );
95 String headers = GeolocationHeader.getGeoHeader(url, mTab); 95 String headers = GeolocationHeader.getGeoHeader(url, mTab);
96 96
97 LoadUrlParams loadUrlParams = new LoadUrlParams(url); 97 LoadUrlParams loadUrlParams = new LoadUrlParams(url);
98 loadUrlParams.setVerbatimHeaders(headers); 98 loadUrlParams.setVerbatimHeaders(headers);
99 loadUrlParams.setTransitionType(PageTransition.GENERATED); 99 loadUrlParams.setTransitionType(PageTransition.GENERATED);
100 mTab.getTabModelSelector().openNewTab(loadUrlParams, 100 mTab.getTabModelSelector().openNewTab(loadUrlParams,
101 TabLaunchType.FROM_LONGPRESS_FOREGROUND, mTab, mTab.isIncognito( )); 101 TabLaunchType.FROM_LONGPRESS_FOREGROUND, mTab, mTab.isIncognito( ));
102 } 102 }
103 } 103 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698